From: Harvey Hunt <harvey.hunt@imgtec.com>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: <linux-mtd@lists.infradead.org>,
Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>,
<linux-kernel@vger.kernel.org>,
Alex Smith <alex.smith@imgtec.com>,
Brian Norris <computersforpeace@gmail.com>,
"David Woodhouse" <dwmw2@infradead.org>
Subject: Re: [PATCH v9 2/3] mtd: nand: jz4780: driver for NAND devices on JZ4780 SoCs
Date: Tue, 8 Dec 2015 16:13:44 +0000 [thread overview]
Message-ID: <566701B8.4050800@imgtec.com> (raw)
In-Reply-To: <20151208171247.7cfdbc98@bbrezillon>
On 08/12/15 16:12, Boris Brezillon wrote:
> On Tue, 8 Dec 2015 16:03:55 +0000
> Harvey Hunt <harvey.hunt@imgtec.com> wrote:
>
>>>
>>> static void jz4780_nand_cmd_ctrl(struct mtd_info *mtd, int cmd,
>>> unsigned int ctrl)
>>> {
>>> struct jz4780_nand_chip *nand = to_jz4780_nand_chip(mtd);
>>> struct jz4780_nand_controller *nfc = to_jz4780_nand_controller(nand->chip.controller);
>>> struct jz4780_nand_cs *cs;
>>>
>>> if (WARN_ON(nfc->selected < 0))
>>> return;
>>>
>>> cs = &nfc->cs[nfc->selected];
>>>
>>> if (ctrl & NAND_CTRL_CHANGE) {
>>> if (cmd != NAND_CMD_NONE) {
>>> if (ctrl & NAND_ALE)
>>> writeb(cmd, cs->base + OFFSET_ADDR);
>>> else if (ctrl & NAND_CLE)
>>> writeb(cmd, cs->base + OFFSET_CMD);
>>> }
>>>
>>> jz4780_nemc_assert(nfc->dev, cs->bank, ctrl & NAND_NCE);
>>> }
>>> }
>>>
>>
>> Okay, I understand your point now. I would also have to implement the
>> read/write functions to replace the defaults, correct? If so, it feels
>> strange to add functions to reimplement the default ones.
>
> I don't think you have to re-implement the {read,write}_{byte,buf,word}
> functions, because you'll still assign the ->IO_ADDR_W and ->IO_ADDR_R
> fields to cs->base + OFFSET_DATA in jz4780_nand_init_chip(), but maybe
> I'm missing something.
>
You're right, I forgot about that.
next prev parent reply other threads:[~2015-12-08 16:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 12:02 [PATCH v9 0/3] mtd: nand: jz4780: Add NAND and BCH drivers Harvey Hunt
2015-12-03 12:02 ` [PATCH v9 1/3] dt-bindings: binding for jz4780-{nand,bch} Harvey Hunt
2015-12-03 21:38 ` Rob Herring
2015-12-03 22:38 ` Brian Norris
2015-12-08 14:17 ` Boris Brezillon
2015-12-03 12:02 ` [PATCH v9 2/3] mtd: nand: jz4780: driver for NAND devices on JZ4780 SoCs Harvey Hunt
2015-12-08 14:14 ` Boris Brezillon
2015-12-08 16:03 ` Harvey Hunt
2015-12-08 16:12 ` Boris Brezillon
2015-12-08 16:13 ` Harvey Hunt [this message]
2015-12-08 16:26 ` Boris Brezillon
2015-12-08 16:36 ` Harvey Hunt
2015-12-14 16:25 ` Boris Brezillon
2015-12-16 11:00 ` Harvey Hunt
2015-12-03 12:02 ` [PATCH v9 3/3] MIPS: dts: jz4780/ci20: Add NEMC, BCH and NAND device tree nodes Harvey Hunt
2015-12-08 14:20 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566701B8.4050800@imgtec.com \
--to=harvey.hunt@imgtec.com \
--cc=Zubair.Kakakhel@imgtec.com \
--cc=alex.smith@imgtec.com \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).