From: majun <majun258@huawei.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: <Catalin.Marinas@arm.com>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <Will.Deacon@arm.com>,
<marc.zyngier@arm.com>, <jason@lakedaemon.net>,
<tglx@linutronix.de>, <lizefan@huawei.com>, <huxinwei@huawei.com>,
<dingtianhong@huawei.com>, <zhaojunhua@hisilicon.com>,
<liguozhu@hisilicon.com>, <xuwei5@hisilicon.com>,
<wei.chenwei@hisilicon.com>, <guohanjun@huawei.com>,
<wuyun.wu@huawei.com>, <guodong.xu@linaro.org>,
<haojian.zhuang@linaro.org>, <zhangfei.gao@linaro.org>,
<usman.ahmad@linaro.org>, <klimov.linux@gmail.com>,
<gabriele.paoloni@huawei.com>
Subject: Re: [PATCH v9 1/4] dt-binding:Documents of the mbigen bindings
Date: Wed, 16 Dec 2015 09:23:19 -0500 [thread overview]
Message-ID: <567173D7.6060303@huawei.com> (raw)
In-Reply-To: <20151211152629.GE20666@leverpostej>
Hi Mark:
On 2015/12/11 10:26, Mark Rutland wrote:
> Hi,
>
> On Mon, Nov 23, 2015 at 11:15:10AM +0800, MaJun wrote:
>> From: Ma Jun <majun258@huawei.com>
>>
>> Add the mbigen msi interrupt controller bindings document.
>>
>> This patch based on Mark Rutland's patch
>> https://lkml.org/lkml/2015/7/23/558
>>
>> Signed-off-by: Ma Jun <majun258@huawei.com>
>> ---
>> Documentation/devicetree/bindings/arm/mbigen.txt | 69 ++++++++++++++++++++++
>> 1 files changed, 69 insertions(+), 0 deletions(-)
>> create mode 100644 Documentation/devicetree/bindings/arm/mbigen.txt
>>
>> diff --git a/Documentation/devicetree/bindings/arm/mbigen.txt b/Documentation/devicetree/bindings/arm/mbigen.txt
>> new file mode 100644
>> index 0000000..8ae59a9
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/arm/mbigen.txt
>> @@ -0,0 +1,69 @@
>> +Hisilicon mbigen device tree bindings.
>> +=======================================
>> +
[...]
>> +- #interrupt-cells : Specifies the number of cells needed to encode an
>> + interrupt source. The value must be 2.
>> +
>> + The 1st cell is global hardware pin number of the interrupt.
>> + This value depends on the Soc design.
>
> I think a little more information is required here. Presumably the
> "global hardware pin number" is actually a pin number within the
> particular mbigen instance? i.e. it is local to this instance?
>
Maybe "global hardware pin number" is not an accurate definition of pin number and
makes people confused.
I will change it to "hardware pin number" to present the real pin number of
wired interrupt(from 0 to maximum interrupt number).
So, there is no global pin number or local pin number.
Thanks!
Majun
>> + The 2nd cell is the interrupt trigger type.
>> + The value of this cell should be:
>> + 1: rising edge triggered
>> + or
>> + 4: high level triggered
>> +
>> +Examples:
>> +
>> + mbigen_device_gmac:intc {
>> + compatible = "hisilicon,mbigen-v2";
>> + reg = <0x0 0xc0080000 0x0 0x10000>;
>> + interrupt-controller;
>> + msi-parent = <&its_dsa 0x40b1c>;
>> + num-msis = <9>;
>> + #interrupt-cells = <2>;
>> + };
>> +
>> +Devices connect to mbigen required properties:
>> +----------------------------------------------------
>> +-interrupt-parent: Specifies the mbigen device node which device connected.
>> +-interrupts:specifies the interrupt source.
>> + The 1st cell is global hardware pin number of the interrupt.
>> + This value depends on the Soc design.
>> + The 2nd cell is the interrupt trigger type(rising edge triggered or high
>> + level triggered)
>
> You should be able to refer to the usual interrupt bindings given you
> defined the format previously when describing #interrupt-cells.
>
> Thanks,
> Mark.
>
> .
>
next prev parent reply other threads:[~2015-12-16 14:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-23 3:15 [PATCH v9 0/4] irqchip:support mbigen interrupt controller MaJun
2015-11-23 3:15 ` [PATCH v9 1/4] dt-binding:Documents of the mbigen bindings MaJun
2015-12-03 16:21 ` Marc Zyngier
2015-12-08 15:01 ` majun
2015-12-11 15:26 ` Mark Rutland
2015-12-16 14:23 ` majun [this message]
2015-11-23 3:15 ` [PATCH v9 2/4] irqchip: add platform device driver for mbigen device MaJun
2015-12-03 16:22 ` Marc Zyngier
2015-11-23 3:15 ` [PATCH v9 3/4] irqchip:create irq domain for each " MaJun
2015-12-03 16:25 ` Marc Zyngier
2015-12-06 20:53 ` majun
2015-12-07 8:32 ` Marc Zyngier
2015-12-11 15:42 ` Mark Rutland
2015-12-16 14:57 ` majun
2015-12-16 15:05 ` Marc Zyngier
2015-11-23 3:15 ` [PATCH v9 4/4] irqchip:implement the mbigen irq chip operation functions MaJun
2015-12-03 16:29 ` Marc Zyngier
2015-12-16 11:22 ` [PATCH v9 0/4] irqchip:support mbigen interrupt controller Marc Zyngier
2015-12-16 14:04 ` majun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=567173D7.6060303@huawei.com \
--to=majun258@huawei.com \
--cc=Catalin.Marinas@arm.com \
--cc=Will.Deacon@arm.com \
--cc=dingtianhong@huawei.com \
--cc=gabriele.paoloni@huawei.com \
--cc=guodong.xu@linaro.org \
--cc=guohanjun@huawei.com \
--cc=haojian.zhuang@linaro.org \
--cc=huxinwei@huawei.com \
--cc=jason@lakedaemon.net \
--cc=klimov.linux@gmail.com \
--cc=liguozhu@hisilicon.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=tglx@linutronix.de \
--cc=usman.ahmad@linaro.org \
--cc=wei.chenwei@hisilicon.com \
--cc=wuyun.wu@huawei.com \
--cc=xuwei5@hisilicon.com \
--cc=zhangfei.gao@linaro.org \
--cc=zhaojunhua@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).