[PATCH] mm/slub: remove unused kmem_cache_order_objects max

[PATCH] mm/slub: remove unused kmem_cache_order_objects max

[Miaohe Lin]

max field holds the largest slab order that was ever used for a slab cache.
But it's unused now. Remove it.

Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
 include/linux/slub_def.h | 1 -
 mm/slub.c                | 2 --
 2 files changed, 3 deletions(-)

diff --git a/include/linux/slub_def.h b/include/linux/slub_def.h
index 33c5c0e3bd8d..f9c68a9dac04 100644
--- a/include/linux/slub_def.h
+++ b/include/linux/slub_def.h
@@ -105,7 +105,6 @@ struct kmem_cache {
 	struct kmem_cache_order_objects oo;
 
 	/* Allocation and freeing of slabs */
-	struct kmem_cache_order_objects max;
 	struct kmem_cache_order_objects min;
 	gfp_t allocflags;	/* gfp flags to use on each alloc */
 	int refcount;		/* Refcount for slab cache destroy */
diff --git a/mm/slub.c b/mm/slub.c
index 1f699ddfff7f..e5535020e0fd 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -4162,8 +4162,6 @@ static int calculate_sizes(struct kmem_cache *s)
 	 */
 	s->oo = oo_make(order, size);
 	s->min = oo_make(get_order(size), size);
-	if (oo_objects(s->oo) > oo_objects(s->max))
-		s->max = s->oo;
 
 	return !!oo_objects(s->oo);
 }
-- 
2.23.0

Re: [PATCH] mm/slub: remove unused kmem_cache_order_objects max

[Vlastimil Babka]

On 4/29/22 11:05, Miaohe Lin wrote:
> max field holds the largest slab order that was ever used for a slab cache.
> But it's unused now. Remove it.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>

Added to slab tree, thanks.

> ---
>  include/linux/slub_def.h | 1 -
>  mm/slub.c                | 2 --
>  2 files changed, 3 deletions(-)
> 
> diff --git a/include/linux/slub_def.h b/include/linux/slub_def.h
> index 33c5c0e3bd8d..f9c68a9dac04 100644
> --- a/include/linux/slub_def.h
> +++ b/include/linux/slub_def.h
> @@ -105,7 +105,6 @@ struct kmem_cache {
>  	struct kmem_cache_order_objects oo;
>  
>  	/* Allocation and freeing of slabs */
> -	struct kmem_cache_order_objects max;
>  	struct kmem_cache_order_objects min;
>  	gfp_t allocflags;	/* gfp flags to use on each alloc */
>  	int refcount;		/* Refcount for slab cache destroy */
> diff --git a/mm/slub.c b/mm/slub.c
> index 1f699ddfff7f..e5535020e0fd 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -4162,8 +4162,6 @@ static int calculate_sizes(struct kmem_cache *s)
>  	 */
>  	s->oo = oo_make(order, size);
>  	s->min = oo_make(get_order(size), size);
> -	if (oo_objects(s->oo) > oo_objects(s->max))
> -		s->max = s->oo;
>  
>  	return !!oo_objects(s->oo);
>  }

Re: [PATCH] mm/slub: remove unused kmem_cache_order_objects max

[Muchun Song]

On Fri, Apr 29, 2022 at 05:05:45PM +0800, Miaohe Lin wrote:
> max field holds the largest slab order that was ever used for a slab cache.
> But it's unused now. Remove it.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>

Nice cleanup.

Reviewed-by: Muchun Song <songmuchun@bytedance.com>

Re: [PATCH] mm/slub: remove unused kmem_cache_order_objects max

[David Rientjes]

On Fri, 29 Apr 2022, Miaohe Lin wrote:

> max field holds the largest slab order that was ever used for a slab cache.
> But it's unused now. Remove it.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>

Acked-by: David Rientjes <rientjes@google.com>