linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] drm: mxsfb: DRM_MXSFB should depend on ARCH_MXS || ARCH_MXC
@ 2022-07-11  9:01 Geert Uytterhoeven
  2022-07-11  9:01 ` [PATCH 2/2] drm: mxsfb: DRM_IMX_LCDIF should depend on ARCH_MXC Geert Uytterhoeven
  2022-07-11 10:36 ` [PATCH 1/2] drm: mxsfb: DRM_MXSFB should depend on ARCH_MXS || ARCH_MXC Marek Vasut
  0 siblings, 2 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2022-07-11  9:01 UTC (permalink / raw)
  To: Marek Vasut, Stefan Agner, David Airlie, Daniel Vetter, Lucas Stach
  Cc: dri-devel, linux-kernel, Geert Uytterhoeven

Freescale/NXP i.MX LCDIF and eLCDIF LCD controllers are only present on
Freescale/NXP i.MX SoCs.  Hence add a dependency on ARCH_MXS ||
ARCH_MXC, to prevent asking the user about this driver when configuring
a kernel without Freescale/NXP i.MX support.

Fixes: 45d59d704080cc0c ("drm: Add new driver for MXSFB controller")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/gpu/drm/mxsfb/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/mxsfb/Kconfig b/drivers/gpu/drm/mxsfb/Kconfig
index 873551b4552f5023..02cf19fcef315724 100644
--- a/drivers/gpu/drm/mxsfb/Kconfig
+++ b/drivers/gpu/drm/mxsfb/Kconfig
@@ -8,6 +8,7 @@ config DRM_MXSFB
 	tristate "i.MX (e)LCDIF LCD controller"
 	depends on DRM && OF
 	depends on COMMON_CLK
+	depends on ARCH_MXS || ARCH_MXC || COMPILE_TEST
 	select DRM_MXS
 	select DRM_KMS_HELPER
 	select DRM_GEM_CMA_HELPER
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] drm: mxsfb: DRM_IMX_LCDIF should depend on ARCH_MXC
  2022-07-11  9:01 [PATCH 1/2] drm: mxsfb: DRM_MXSFB should depend on ARCH_MXS || ARCH_MXC Geert Uytterhoeven
@ 2022-07-11  9:01 ` Geert Uytterhoeven
  2022-07-11 10:36   ` Marek Vasut
  2022-07-11 10:36 ` [PATCH 1/2] drm: mxsfb: DRM_MXSFB should depend on ARCH_MXS || ARCH_MXC Marek Vasut
  1 sibling, 1 reply; 4+ messages in thread
From: Geert Uytterhoeven @ 2022-07-11  9:01 UTC (permalink / raw)
  To: Marek Vasut, Stefan Agner, David Airlie, Daniel Vetter, Lucas Stach
  Cc: dri-devel, linux-kernel, Geert Uytterhoeven

The Freescale/NXP i.MX LCDIFv3 LCD controller is only present on
Freescale/NXP i.MX SoCs.  Hence add a dependency on ARCH_MXC, to prevent
asking the user about this driver when configuring a kernel without
Freescale/NXP i.MX support.

Fixes: 9db35bb349a0ef32 ("drm: lcdif: Add support for i.MX8MP LCDIF variant")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/gpu/drm/mxsfb/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/mxsfb/Kconfig b/drivers/gpu/drm/mxsfb/Kconfig
index 02cf19fcef315724..40cc9b8fb749f3e4 100644
--- a/drivers/gpu/drm/mxsfb/Kconfig
+++ b/drivers/gpu/drm/mxsfb/Kconfig
@@ -25,6 +25,7 @@ config DRM_IMX_LCDIF
 	tristate "i.MX LCDIFv3 LCD controller"
 	depends on DRM && OF
 	depends on COMMON_CLK
+	depends on ARCH_MXC || COMPILE_TEST
 	select DRM_MXS
 	select DRM_KMS_HELPER
 	select DRM_GEM_CMA_HELPER
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] drm: mxsfb: DRM_MXSFB should depend on ARCH_MXS || ARCH_MXC
  2022-07-11  9:01 [PATCH 1/2] drm: mxsfb: DRM_MXSFB should depend on ARCH_MXS || ARCH_MXC Geert Uytterhoeven
  2022-07-11  9:01 ` [PATCH 2/2] drm: mxsfb: DRM_IMX_LCDIF should depend on ARCH_MXC Geert Uytterhoeven
@ 2022-07-11 10:36 ` Marek Vasut
  1 sibling, 0 replies; 4+ messages in thread
From: Marek Vasut @ 2022-07-11 10:36 UTC (permalink / raw)
  To: Geert Uytterhoeven, Stefan Agner, David Airlie, Daniel Vetter,
	Lucas Stach
  Cc: dri-devel, linux-kernel

On 7/11/22 11:01, Geert Uytterhoeven wrote:
> Freescale/NXP i.MX LCDIF and eLCDIF LCD controllers are only present on
> Freescale/NXP i.MX SoCs.  Hence add a dependency on ARCH_MXS ||
> ARCH_MXC, to prevent asking the user about this driver when configuring
> a kernel without Freescale/NXP i.MX support.
> 
> Fixes: 45d59d704080cc0c ("drm: Add new driver for MXSFB controller")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Is the Fixes tag really justified in this case ?

Otherwise

Reviewed-by: Marek Vasut <marex@denx.de>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] drm: mxsfb: DRM_IMX_LCDIF should depend on ARCH_MXC
  2022-07-11  9:01 ` [PATCH 2/2] drm: mxsfb: DRM_IMX_LCDIF should depend on ARCH_MXC Geert Uytterhoeven
@ 2022-07-11 10:36   ` Marek Vasut
  0 siblings, 0 replies; 4+ messages in thread
From: Marek Vasut @ 2022-07-11 10:36 UTC (permalink / raw)
  To: Geert Uytterhoeven, Stefan Agner, David Airlie, Daniel Vetter,
	Lucas Stach
  Cc: dri-devel, linux-kernel

On 7/11/22 11:01, Geert Uytterhoeven wrote:
> The Freescale/NXP i.MX LCDIFv3 LCD controller is only present on
> Freescale/NXP i.MX SoCs.  Hence add a dependency on ARCH_MXC, to prevent
> asking the user about this driver when configuring a kernel without
> Freescale/NXP i.MX support.
> 
> Fixes: 9db35bb349a0ef32 ("drm: lcdif: Add support for i.MX8MP LCDIF variant")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Marek Vasut <marex@denx.de>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-07-11 11:18 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-11  9:01 [PATCH 1/2] drm: mxsfb: DRM_MXSFB should depend on ARCH_MXS || ARCH_MXC Geert Uytterhoeven
2022-07-11  9:01 ` [PATCH 2/2] drm: mxsfb: DRM_IMX_LCDIF should depend on ARCH_MXC Geert Uytterhoeven
2022-07-11 10:36   ` Marek Vasut
2022-07-11 10:36 ` [PATCH 1/2] drm: mxsfb: DRM_MXSFB should depend on ARCH_MXS || ARCH_MXC Marek Vasut

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).