From: "Wangnan (F)" <wangnan0@huawei.com>
To: Namhyung Kim <namhyung@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Jiri Olsa <jolsa@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
"David Ahern" <dsahern@gmail.com>,
Stephane Eranian <eranian@google.com>,
Andi Kleen <andi@firstfloor.org>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Subject: Re: [RFC/PATCH] perf report: Show random usage tip on the help line
Date: Tue, 5 Jan 2016 14:32:47 +0800 [thread overview]
Message-ID: <568B638F.1030208@huawei.com> (raw)
In-Reply-To: <1451972206-22481-1-git-send-email-namhyung@kernel.org>
On 2016/1/5 13:36, Namhyung Kim wrote:
> Currently perf report only shows a help message "For a higher level
> overview, try: perf report --sort comm,dso" unconditionally (even if
> the sort keys were used). Add more help tips and show randomly.
>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
That's really funny.
Some inconvenience:
1. Tip is never change during one execution of 'perf report', even if
I switch to another view using 'enter' and switch back. It should
better
if tips updated when redrawing.
2. I think add a "Tip: " prefix to the content should be better, or
users may
confuse what he/her doing causes this message
3. What about creating a tools/perf/Documentation/tips.txt and
generate tips
table dynamically?
Thank you.
next prev parent reply other threads:[~2016-01-05 6:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 5:36 [RFC/PATCH] perf report: Show random usage tip on the help line Namhyung Kim
2016-01-05 6:32 ` Wangnan (F) [this message]
2016-01-05 10:43 ` Namhyung Kim
2016-01-05 16:40 ` Arnaldo Carvalho de Melo
2016-01-05 19:19 ` Namhyung Kim
2016-01-05 20:55 ` Arnaldo Carvalho de Melo
2016-01-05 20:59 ` Andi Kleen
2016-01-05 23:29 ` Namhyung Kim
2016-01-06 1:49 ` Arnaldo Carvalho de Melo
2016-01-05 20:52 ` Andi Kleen
2016-01-05 23:37 ` Namhyung Kim
2016-01-06 1:51 ` Arnaldo Carvalho de Melo
2016-01-08 15:41 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568B638F.1030208@huawei.com \
--to=wangnan0@huawei.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=andi@firstfloor.org \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).