From: Salil Mehta <salil.mehta@huawei.com>
To: David Miller <davem@davemloft.net>, <arnd@arndb.de>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<yisen.zhuang@huawei.com>, <yankejian@huawei.com>,
<lisheng011@huawei.com>, <huangdaode@hisilicon.com>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] net: hns: avoid uninitialized variable warning:
Date: Wed, 6 Jan 2016 15:35:46 +0000 [thread overview]
Message-ID: <568D3452.80508@huawei.com> (raw)
In-Reply-To: <20160105.164320.2255971055498857833.davem@davemloft.net>
On 1/5/2016 9:43 PM, David Miller wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> Date: Fri, 01 Jan 2016 23:27:57 +0100
>
>> gcc fails to see that the use of the 'last_offset' variable
>> in hns_nic_reuse_page() is used correctly and issues a bogus
>> warning:
>>
>> drivers/net/ethernet/hisilicon/hns/hns_enet.c: In function 'hns_nic_reuse_page':
>> drivers/net/ethernet/hisilicon/hns/hns_enet.c:541:6: warning: 'last_offset' may be used uninitialized in this function [-Wmaybe-uninitialized]
>>
>> This simplifies the function to make it more obvious what is
>> going on to both readers and compilers, which makes the warning
>> go away.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> ---
>> Compile-tested only, and complex enough that this requires a proper
>> review and testing before it gets apply. Please have a look at this.
> If this goes yet another day without being reviewed, I'm just applying
> it.
>
> You hisilicon folks can't just let patches rot, you must review them
> in a timely manner or else I'm applying them without waiting for you
> to look at them.
Hi David and Arnd,
Apologies for the delay in response and the review. Most of us were on
the Annual Holidays and have just returned back.
Change looks good to me!
Best Regards
Salil
next prev parent reply other threads:[~2016-01-06 15:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-01 22:27 [PATCH] net: hns: avoid uninitialized variable warning: Arnd Bergmann
2016-01-05 21:43 ` David Miller
2016-01-06 15:35 ` Salil Mehta [this message]
2016-01-06 0:56 ` Yisen Zhuang
2016-01-06 5:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568D3452.80508@huawei.com \
--to=salil.mehta@huawei.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=huangdaode@hisilicon.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lisheng011@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=yankejian@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).