* [PATCH] s390: drop smp_mb in vdso_init
@ 2016-01-05 16:17 Michael S. Tsirkin
2016-01-07 8:41 ` Christian Borntraeger
0 siblings, 1 reply; 2+ messages in thread
From: Michael S. Tsirkin @ 2016-01-05 16:17 UTC (permalink / raw)
To: linux-kernel
Cc: Martin Schwidefsky, Heiko Carstens, Christian Borntraeger, linux-s390
The initial s390 vdso code is heavily influenced by the powerpc version
which does have a smp_wmb in vdso_init right before the vdso_ready=1
assignment. s390 has no need for that.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
Untested.
arch/s390/kernel/vdso.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/s390/kernel/vdso.c b/arch/s390/kernel/vdso.c
index 59eddb0..a1cfd37 100644
--- a/arch/s390/kernel/vdso.c
+++ b/arch/s390/kernel/vdso.c
@@ -299,8 +299,6 @@ static int __init vdso_init(void)
get_page(virt_to_page(vdso_data));
- smp_mb();
-
return 0;
}
early_initcall(vdso_init);
--
MST
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] s390: drop smp_mb in vdso_init
2016-01-05 16:17 [PATCH] s390: drop smp_mb in vdso_init Michael S. Tsirkin
@ 2016-01-07 8:41 ` Christian Borntraeger
0 siblings, 0 replies; 2+ messages in thread
From: Christian Borntraeger @ 2016-01-07 8:41 UTC (permalink / raw)
To: Michael S. Tsirkin, linux-kernel
Cc: Martin Schwidefsky, Heiko Carstens, linux-s390
On 01/05/2016 05:17 PM, Michael S. Tsirkin wrote:
> The initial s390 vdso code is heavily influenced by the powerpc version
> which does have a smp_wmb in vdso_init right before the vdso_ready=1
> assignment. s390 has no need for that.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>
> Untested.
>
> arch/s390/kernel/vdso.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/s390/kernel/vdso.c b/arch/s390/kernel/vdso.c
> index 59eddb0..a1cfd37 100644
> --- a/arch/s390/kernel/vdso.c
> +++ b/arch/s390/kernel/vdso.c
> @@ -299,8 +299,6 @@ static int __init vdso_init(void)
>
> get_page(virt_to_page(vdso_data));
>
> - smp_mb();
> -
> return 0;
> }
> early_initcall(vdso_init);
>
applied to the s390 tree.
Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-01-07 8:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-05 16:17 [PATCH] s390: drop smp_mb in vdso_init Michael S. Tsirkin
2016-01-07 8:41 ` Christian Borntraeger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).