From: Caesar Wang <caesar.upstream@gmail.com>
To: Heiko Stuebner <heiko@sntech.de>
Cc: Caesar Wang <wxt@rock-chips.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
leecam@google.com, linux-arm-kernel@lists.infradead.org,
keescook@google.com, linux-clk@vger.kernel.org,
leozwang@google.com
Subject: Re: [PATCH v2 04/12] clk: rockchip: rk3036: enable the CLK_IGNORE_UNUSED flag for sclk_i2s_out
Date: Fri, 8 Jan 2016 17:26:18 +0800 [thread overview]
Message-ID: <568F80BA.6060209@gmail.com> (raw)
In-Reply-To: <290434099.8XFZ9qmNRz@phil>
Heiko,
在 2016年01月07日 18:05, Heiko Stuebner 写道:
> Hi Caesar,
>
> Am Donnerstag, 7. Januar 2016, 16:25:47 schrieb Caesar Wang:
>> SCLk_I2S_OUT is the noc bus clock for i2s module, this clock is used by
>> extra codecs.
>>
>> Due to it shouldn't belong to any driver, but we need it enabled,
>> so just mark it as the CLK_IGNORE_UNUSED flag.
> What makes you think it shouldn't belong to any driver?
>
> In most schematics I have, i2s_clkout is going to some clock-input of the
> audio codec - probably the MCLK input on your rt5616. And while the new
> rt5616 driver does not seem to do clock handling, it should just handle the
> clock using the normal APIs.
You are right, that's seem has to find the root cause.
I'm wonder that the codec/i2s is working in kernel v4.1 patch without it.
In general, the MLCK will be handled in i2s driver if the cpu side is
master.
>
>
> Heiko
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
--
Thanks,
Caesar
next prev parent reply other threads:[~2016-01-08 9:26 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 8:25 [PATCH v2 00/12] Add the family patches to support for kylin board Caesar Wang
2016-01-07 8:25 ` [PATCH v2 01/12] ARM: dts: rockchip: set the pinctrl default setting for rk3036 i2s Caesar Wang
2016-01-09 2:17 ` Heiko Stuebner
2016-01-07 8:25 ` [PATCH v2 02/12] ARM: dts: rockchip: add the sound codec for kylin board Caesar Wang
2016-01-09 2:39 ` Heiko Stuebner
2016-01-07 8:25 ` [PATCH v2 03/12] ARM: dts: rockchip: override the clocks in i2s " Caesar Wang
2016-01-09 2:31 ` Heiko Stuebner
2016-01-11 13:38 ` Caesar Wang
2016-01-07 8:25 ` [PATCH v2 04/12] clk: rockchip: rk3036: enable the CLK_IGNORE_UNUSED flag for sclk_i2s_out Caesar Wang
2016-01-07 10:05 ` Heiko Stuebner
2016-01-08 9:26 ` Caesar Wang [this message]
2016-01-08 9:46 ` Heiko Stuebner
2016-01-13 8:10 ` Caesar Wang
2016-01-07 8:25 ` [PATCH v2 05/12] mmc: pwrseq: Document optional exteral vcc for the simple power sequence Caesar Wang
2016-01-08 12:13 ` Javier Martinez Canillas
2016-01-07 8:25 ` [PATCH v2 06/12] mmc: pwrseq: add support for power-on sequencing through DT Caesar Wang
2016-01-08 12:22 ` Javier Martinez Canillas
2016-01-09 2:42 ` Heiko Stuebner
2016-01-11 16:02 ` Javier Martinez Canillas
2016-01-15 9:15 ` Caesar Wang
2016-01-07 8:25 ` [PATCH v2 07/12] ARM: dts: rockchip: enable the high speed on sdio for kylin board Caesar Wang
2016-01-07 8:25 ` [PATCH v2 08/12] ARM: dts: rockchip: add the wifi/bt regulator " Caesar Wang
2016-01-07 8:25 ` [PATCH v2 09/12] ARM: dts: rockchip: enable the uart0 " Caesar Wang
2016-01-07 8:25 ` [PATCH v2 10/12] ARM: dts: rockchip: add the sdmmc " Caesar Wang
2016-01-07 8:25 ` [PATCH v2 11/12] ARM: dts: rockchip: add the lcdc and hdmi node for rk3036 Caesar Wang
2016-01-07 8:25 ` [PATCH v2 12/12] ARM: dts: Add pl330-broken-no-flushp quirk for rk3036 SoCs Caesar Wang
2016-01-07 10:44 ` [PATCH v2 00/12] Add the family patches to support for kylin board Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568F80BA.6060209@gmail.com \
--to=caesar.upstream@gmail.com \
--cc=heiko@sntech.de \
--cc=keescook@google.com \
--cc=leecam@google.com \
--cc=leozwang@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=ulf.hansson@linaro.org \
--cc=wxt@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).