Nokia N900: u-SD card in v4.2+

Nokia N900: u-SD card in v4.2+

[Pavel Machek]

Hi!

In v4.1, both internal MMC and u-SD cards work ok.

In v4.2, only the internal MMC is detected. In v4.3, not even internal
MMC works. In v4.4, only the internal MMC is detected.

Does it work for you? Any patches?

(I do have hack in the dts to disable back cover detection...)

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: Nokia N900: u-SD card in v4.2+

[Kishon Vijay Abraham I]

Hi,

On Thursday 07 January 2016 02:16 AM, Pavel Machek wrote:
> Hi!
> 
> In v4.1, both internal MMC and u-SD cards work ok.
> 
> In v4.2, only the internal MMC is detected. In v4.3, not even internal
> MMC works. In v4.4, only the internal MMC is detected.
> 
> Does it work for you? Any patches?

I don't have Nokia N900 to check this, but can you share your config and kernel
logs? Check if CONFIG_REGULATOR_PBIAS is present in your config.
CONFIG_REGULATOR_PBIAS is now mandatory for all omap3+ SoCs to work.

Thanks
Kishon

> 
> (I do have hack in the dts to disable back cover detection...)
> 
> 									Pavel
> 

Re: Nokia N900: u-SD card in v4.2+

[Pavel Machek]

Hi!

> On Thursday 07 January 2016 02:16 AM, Pavel Machek wrote:
> > Hi!
> > 
> > In v4.1, both internal MMC and u-SD cards work ok.
> > 
> > In v4.2, only the internal MMC is detected. In v4.3, not even internal
> > MMC works. In v4.4, only the internal MMC is detected.
> > 
> > Does it work for you? Any patches?
> 
> I don't have Nokia N900 to check this, but can you share your config and kernel
> logs? Check if CONFIG_REGULATOR_PBIAS is present in your config.
> CONFIG_REGULATOR_PBIAS is now mandatory for all omap3+ SoCs to work.

I enabled CONFIG_REGULATOR_PBIAS and both MMCs now work.

I wonder if we should add some selects, so that users updating from
old kernels don't break their system?

Thanks,
									
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: Nokia N900: u-SD card in v4.2+

[Pali Rohár]

[-- Attachment #1: Type: Text/Plain, Size: 1003 bytes --]

On Thursday 07 January 2016 12:34:09 Pavel Machek wrote:
> Hi!
> 
> > On Thursday 07 January 2016 02:16 AM, Pavel Machek wrote:
> > > Hi!
> > > 
> > > In v4.1, both internal MMC and u-SD cards work ok.
> > > 
> > > In v4.2, only the internal MMC is detected. In v4.3, not even
> > > internal MMC works. In v4.4, only the internal MMC is detected.
> > > 
> > > Does it work for you? Any patches?
> > 
> > I don't have Nokia N900 to check this, but can you share your
> > config and kernel logs? Check if CONFIG_REGULATOR_PBIAS is present
> > in your config. CONFIG_REGULATOR_PBIAS is now mandatory for all
> > omap3+ SoCs to work.
> 
> I enabled CONFIG_REGULATOR_PBIAS and both MMCs now work.
> 
> I wonder if we should add some selects, so that users updating from
> old kernels don't break their system?

Please add these selects. I had CONFIG_REGULATOR_PBIAS disabled too, 
because I just updated defconfig from older kernel version.

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: Nokia N900: u-SD card in v4.2+

[Kishon Vijay Abraham I]

Hi,

On Sunday 10 January 2016 04:14 AM, Pali Rohár wrote:
> On Thursday 07 January 2016 12:34:09 Pavel Machek wrote:
>> Hi!
>>
>>> On Thursday 07 January 2016 02:16 AM, Pavel Machek wrote:
>>>> Hi!
>>>>
>>>> In v4.1, both internal MMC and u-SD cards work ok.
>>>>
>>>> In v4.2, only the internal MMC is detected. In v4.3, not even
>>>> internal MMC works. In v4.4, only the internal MMC is detected.
>>>>
>>>> Does it work for you? Any patches?
>>>
>>> I don't have Nokia N900 to check this, but can you share your
>>> config and kernel logs? Check if CONFIG_REGULATOR_PBIAS is present
>>> in your config. CONFIG_REGULATOR_PBIAS is now mandatory for all
>>> omap3+ SoCs to work.
>>
>> I enabled CONFIG_REGULATOR_PBIAS and both MMCs now work.
>>
>> I wonder if we should add some selects, so that users updating from
>> old kernels don't break their system?
> 
> Please add these selects. I had CONFIG_REGULATOR_PBIAS disabled too, 
> because I just updated defconfig from older kernel version.

'select' is generally not recommended since it selects a config without
caring for the dependency. With adding 'depends on', MMC won't be enabled and
will end up in the same problem.

Tony has already added a Documentation noting that CONFIG_REGULATOR_PBIAS
should be enabled for MMCs to work.
commit d8e1f5ed11a39a68da00f05000466c4f6db4456e
Author: Tony Lindgren <tony@atomide.com>
Date:   Mon Oct 12 16:19:54 2015 -0700

    Documentation: ARM: List new omap MMC requirements

Maybe we should also make the error message a little more verbose to tell the
user that CONFIG_REGULATOR_PBIAS be selected?

Thanks
Kishon

Re: Nokia N900: u-SD card in v4.2+

[Pavel Machek]

On Mon 2016-01-11 14:10:23, Kishon Vijay Abraham I wrote:
> Hi,
> 
> On Sunday 10 January 2016 04:14 AM, Pali Rohár wrote:
> > On Thursday 07 January 2016 12:34:09 Pavel Machek wrote:
> >> Hi!
> >>
> >>> On Thursday 07 January 2016 02:16 AM, Pavel Machek wrote:
> >>>> Hi!
> >>>>
> >>>> In v4.1, both internal MMC and u-SD cards work ok.
> >>>>
> >>>> In v4.2, only the internal MMC is detected. In v4.3, not even
> >>>> internal MMC works. In v4.4, only the internal MMC is detected.
> >>>>
> >>>> Does it work for you? Any patches?
> >>>
> >>> I don't have Nokia N900 to check this, but can you share your
> >>> config and kernel logs? Check if CONFIG_REGULATOR_PBIAS is present
> >>> in your config. CONFIG_REGULATOR_PBIAS is now mandatory for all
> >>> omap3+ SoCs to work.
> >>
> >> I enabled CONFIG_REGULATOR_PBIAS and both MMCs now work.
> >>
> >> I wonder if we should add some selects, so that users updating from
> >> old kernels don't break their system?
> > 
> > Please add these selects. I had CONFIG_REGULATOR_PBIAS disabled too, 
> > because I just updated defconfig from older kernel version.
> 
> 'select' is generally not recommended since it selects a config without
> caring for the dependency. With adding 'depends on', MMC won't be enabled and
> will end up in the same problem.

Well... it really should "depend on". Not ideal, but you'll likely
realize what went on.

Silently compiling known-bad kernel is ... well.. bad.

> Tony has already added a Documentation noting that CONFIG_REGULATOR_PBIAS
> should be enabled for MMCs to work.
> commit d8e1f5ed11a39a68da00f05000466c4f6db4456e
> Author: Tony Lindgren <tony@atomide.com>
> Date:   Mon Oct 12 16:19:54 2015 -0700
> 
>     Documentation: ARM: List new omap MMC requirements
> 
> Maybe we should also make the error message a little more verbose to tell the
> user that CONFIG_REGULATOR_PBIAS be selected?

That would help.

As would #error if we recognize broken config.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: Nokia N900: u-SD card in v4.2+

[Tony Lindgren]

* Pavel Machek <pavel@ucw.cz> [160113 11:13]:
> On Mon 2016-01-11 14:10:23, Kishon Vijay Abraham I wrote:
> > 
> > 'select' is generally not recommended since it selects a config without
> > caring for the dependency. With adding 'depends on', MMC won't be enabled and
> > will end up in the same problem.
> 
> Well... it really should "depend on". Not ideal, but you'll likely
> realize what went on.
> 
> Silently compiling known-bad kernel is ... well.. bad.

Force selects will lead into build errors sooner or later.

> > Tony has already added a Documentation noting that CONFIG_REGULATOR_PBIAS
> > should be enabled for MMCs to work.
> > commit d8e1f5ed11a39a68da00f05000466c4f6db4456e
> > Author: Tony Lindgren <tony@atomide.com>
> > Date:   Mon Oct 12 16:19:54 2015 -0700
> > 
> >     Documentation: ARM: List new omap MMC requirements
> > 
> > Maybe we should also make the error message a little more verbose to tell the
> > user that CONFIG_REGULATOR_PBIAS be selected?
> 
> That would help.
> 
> As would #error if we recognize broken config.

Can't we just add a check to the omap_hsmmc.c? In cases where
MMC1 has the PBIAS regulator configured but not available, print
an error about missing CONFIG_REGULATOR_PBIAS error and return
-EPROBE_DEFER?

Regards,

Tony