* [PATCH] staging: comedi: dt2801: Prefer using the BIT macro
@ 2016-01-11 16:04 Bhaktipriya Shridhar
2016-01-11 17:31 ` Ian Abbott
0 siblings, 1 reply; 2+ messages in thread
From: Bhaktipriya Shridhar @ 2016-01-11 16:04 UTC (permalink / raw)
To: abbotti, hsweeten, gregkh, mahfouz.saif.elyazal, bhaktipriya96
Cc: devel, linux-kernel
As suggested by checkpatch.pl, this patch replaces bit shifting on 1 with the
BIT(x) macro.
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
drivers/staging/comedi/drivers/dt2801.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/comedi/drivers/dt2801.c b/drivers/staging/comedi/drivers/dt2801.c
index 80e38de..6c7b4d2 100644
--- a/drivers/staging/comedi/drivers/dt2801.c
+++ b/drivers/staging/comedi/drivers/dt2801.c
@@ -68,17 +68,17 @@ Configuration options:
/* Command modifiers (only used with read/write), EXTTRIG can be
used with some other commands.
*/
-#define DT_MOD_DMA (1<<4)
-#define DT_MOD_CONT (1<<5)
-#define DT_MOD_EXTCLK (1<<6)
-#define DT_MOD_EXTTRIG (1<<7)
+#define DT_MOD_DMA BIT(4)
+#define DT_MOD_CONT BIT(5)
+#define DT_MOD_EXTCLK BIT(6)
+#define DT_MOD_EXTTRIG BIT(7)
/* Bits in status register */
-#define DT_S_DATA_OUT_READY (1<<0)
-#define DT_S_DATA_IN_FULL (1<<1)
-#define DT_S_READY (1<<2)
-#define DT_S_COMMAND (1<<3)
-#define DT_S_COMPOSITE_ERROR (1<<7)
+#define DT_S_DATA_OUT_READY BIT(0)
+#define DT_S_DATA_IN_FULL BIT(1)
+#define DT_S_READY BIT(2)
+#define DT_S_COMMAND BIT(3)
+#define DT_S_COMPOSITE_ERROR BIT(7)
/* registers */
#define DT2801_DATA 0
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: comedi: dt2801: Prefer using the BIT macro
2016-01-11 16:04 [PATCH] staging: comedi: dt2801: Prefer using the BIT macro Bhaktipriya Shridhar
@ 2016-01-11 17:31 ` Ian Abbott
0 siblings, 0 replies; 2+ messages in thread
From: Ian Abbott @ 2016-01-11 17:31 UTC (permalink / raw)
To: Bhaktipriya Shridhar, hsweeten, gregkh, mahfouz.saif.elyazal
Cc: devel, linux-kernel
On 11/01/16 16:04, Bhaktipriya Shridhar wrote:
> As suggested by checkpatch.pl, this patch replaces bit shifting on 1 with the
> BIT(x) macro.
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
> ---
> drivers/staging/comedi/drivers/dt2801.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/dt2801.c b/drivers/staging/comedi/drivers/dt2801.c
> index 80e38de..6c7b4d2 100644
> --- a/drivers/staging/comedi/drivers/dt2801.c
> +++ b/drivers/staging/comedi/drivers/dt2801.c
> @@ -68,17 +68,17 @@ Configuration options:
> /* Command modifiers (only used with read/write), EXTTRIG can be
> used with some other commands.
> */
> -#define DT_MOD_DMA (1<<4)
> -#define DT_MOD_CONT (1<<5)
> -#define DT_MOD_EXTCLK (1<<6)
> -#define DT_MOD_EXTTRIG (1<<7)
> +#define DT_MOD_DMA BIT(4)
> +#define DT_MOD_CONT BIT(5)
> +#define DT_MOD_EXTCLK BIT(6)
> +#define DT_MOD_EXTTRIG BIT(7)
>
> /* Bits in status register */
> -#define DT_S_DATA_OUT_READY (1<<0)
> -#define DT_S_DATA_IN_FULL (1<<1)
> -#define DT_S_READY (1<<2)
> -#define DT_S_COMMAND (1<<3)
> -#define DT_S_COMPOSITE_ERROR (1<<7)
> +#define DT_S_DATA_OUT_READY BIT(0)
> +#define DT_S_DATA_IN_FULL BIT(1)
> +#define DT_S_READY BIT(2)
> +#define DT_S_COMMAND BIT(3)
> +#define DT_S_COMPOSITE_ERROR BIT(7)
>
> /* registers */
> #define DT2801_DATA 0
> --
> 2.1.4
>
Thanks!
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-01-11 17:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-11 16:04 [PATCH] staging: comedi: dt2801: Prefer using the BIT macro Bhaktipriya Shridhar
2016-01-11 17:31 ` Ian Abbott
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).