linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: daejun7.park@samsung.com, Greg KH <gregkh@linuxfoundation.org>,
	"avri.altman@wdc.com" <avri.altman@wdc.com>,
	"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
	"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
	"asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
	"stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
	"cang@codeaurora.org" <cang@codeaurora.org>,
	"huobean@gmail.com" <huobean@gmail.com>,
	ALIM AKHTAR <alim.akhtar@samsung.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	JinHwan Park <jh.i.park@samsung.com>,
	Javier Gonzalez <javier.gonz@samsung.com>,
	Sung-Jun Park <sungjun07.park@samsung.com>,
	Jinyoung CHOI <j-young.choi@samsung.com>,
	Dukhyun Kwon <d_hyun.kwon@samsung.com>,
	Keoseong Park <keosung.park@samsung.com>,
	Jaemyung Lee <jaemyung.lee@samsung.com>,
	Jieon Seol <jieon.seol@samsung.com>
Subject: Re: [PATCH v36 1/4] scsi: ufs: Introduce HPB feature
Date: Thu, 10 Jun 2021 09:45:50 -0700	[thread overview]
Message-ID: <5694e1e0-1c8c-12ef-3215-3d3413a86ea2@acm.org> (raw)
In-Reply-To: <20210607041755epcms2p271195b24f4a10e777d240ff5d844168f@epcms2p2>

On 6/6/21 9:17 PM, Daejun Park wrote:
> +What:		/sys/class/scsi_device/*/device/hpb_sysfs/hit_cnt
> +Date:		June 2021
> +Contact:	Daejun Park <daejun7.park@samsung.com>
> +Description:	This entry shows the number of reads that changed to HPB read.
> +
> +		The file is read only.

This patch introduces the hit_cnt attribute in the hpb_sysfs directory
and patch 4 moves that attribute to the hpb_stats directory. That is not
how sysfs attributes should be introduced. Please introduce the hit_cnt
attribute in the hpb_stats directory in this patch such that the sysfs
directory does not have to be modified in patch 4.

Thanks,

Bart.

  reply	other threads:[~2021-06-10 16:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20210607041650epcms2p29002c9d072738bbf21fb4acf31847e8e@epcms2p2>
2021-06-07  4:16 ` [PATCH v36 0/4] scsi: ufs: Add Host Performance Booster Support Daejun Park
     [not found]   ` <CGME20210607041650epcms2p29002c9d072738bbf21fb4acf31847e8e@epcms2p5>
2021-06-07  4:18     ` [PATCH v36 3/4] scsi: ufs: Prepare HPB read for cached sub-region Daejun Park
     [not found]   ` <CGME20210607041650epcms2p29002c9d072738bbf21fb4acf31847e8e@epcms2p7>
2021-06-07  4:19     ` [PATCH v36 4/4] scsi: ufs: Add HPB 2.0 support Daejun Park
2021-06-10  1:55       ` 정요한(JOUNG YOHAN) Mobile SE
2021-06-10  3:37       ` Bart Van Assche
2021-06-10  6:07         ` Greg KH
     [not found]       ` <CGME20210607041650epcms2p29002c9d072738bbf21fb4acf31847e8e@epcms2p1>
2021-06-10  6:23         ` Daejun Park
2021-06-09  9:53   ` [PATCH v36 0/4] scsi: ufs: Add Host Performance Booster Support Greg KH
2021-06-07  4:17 ` [PATCH v36 1/4] scsi: ufs: Introduce HPB feature Daejun Park
2021-06-10 16:45   ` Bart Van Assche [this message]
     [not found]   ` <CGME20210607041650epcms2p29002c9d072738bbf21fb4acf31847e8e@epcms2p6>
2021-06-11  0:28     ` Daejun Park
2021-06-07  4:18 ` [PATCH v36 2/4] scsi: ufs: L2P map management for HPB read Daejun Park
2021-06-11  1:54 ` RE: [PATCH v36 4/4] scsi: ufs: Add HPB 2.0 support Daejun Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5694e1e0-1c8c-12ef-3215-3d3413a86ea2@acm.org \
    --to=bvanassche@acm.org \
    --cc=alim.akhtar@samsung.com \
    --cc=asutoshd@codeaurora.org \
    --cc=avri.altman@wdc.com \
    --cc=cang@codeaurora.org \
    --cc=d_hyun.kwon@samsung.com \
    --cc=daejun7.park@samsung.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=huobean@gmail.com \
    --cc=j-young.choi@samsung.com \
    --cc=jaemyung.lee@samsung.com \
    --cc=javier.gonz@samsung.com \
    --cc=jejb@linux.ibm.com \
    --cc=jh.i.park@samsung.com \
    --cc=jieon.seol@samsung.com \
    --cc=keosung.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=stanley.chu@mediatek.com \
    --cc=sungjun07.park@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).