From: "정요한(JOUNG YOHAN) Mobile SE" <yohan.joung@sk.com>
To: "daejun7.park@samsung.com" <daejun7.park@samsung.com>,
Greg KH <gregkh@linuxfoundation.org>,
"avri.altman@wdc.com" <avri.altman@wdc.com>,
"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
"stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
"cang@codeaurora.org" <cang@codeaurora.org>,
"bvanassche@acm.org" <bvanassche@acm.org>,
"huobean@gmail.com" <huobean@gmail.com>,
ALIM AKHTAR <alim.akhtar@samsung.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v36 4/4] scsi: ufs: Add HPB 2.0 support
Date: Thu, 10 Jun 2021 01:55:24 +0000 [thread overview]
Message-ID: <e540ec7b6d3e4adc97780fcdf87f46aa@sk.com> (raw)
In-Reply-To: <20210607041927epcms2p707781de1678af1e1d0f4d88782125f7b@epcms2p7>
diff --git a/drivers/scsi/ufs/ufshpb.h b/drivers/scsi/ufs/ufshpb.h index 6e6a0252dc15..b1128b0ce486 100644
--- a/drivers/scsi/ufs/ufshpb.h
+++ b/drivers/scsi/ufs/ufshpb.h
@@ -30,19 +30,29 @@
#define PINNED_NOT_SET U32_MAX
/* hpb support chunk size */
-#define HPB_MULTI_CHUNK_HIGH 1
+#define HPB_LEGACY_CHUNK_HIGH 1
+#define HPB_MULTI_CHUNK_LOW 7
+#define HPB_MULTI_CHUNK_HIGH 128
According to the JEDEC spec, bMAX_ DATA_SIZE_FOR_HPB_SINGLE_CMD can be set from 4kb to 1024kb.
The transfer length should be provided up to 1020kb or 1024kb.
Why did you set HPB_MULTI_CHUNK_HIGH to 128?
It can sends the hpb command up to 512kb.
This doesn't seem to match the specs.
Thanks
Yohan.
next prev parent reply other threads:[~2021-06-10 2:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210607041650epcms2p29002c9d072738bbf21fb4acf31847e8e@epcms2p2>
2021-06-07 4:16 ` [PATCH v36 0/4] scsi: ufs: Add Host Performance Booster Support Daejun Park
[not found] ` <CGME20210607041650epcms2p29002c9d072738bbf21fb4acf31847e8e@epcms2p5>
2021-06-07 4:18 ` [PATCH v36 3/4] scsi: ufs: Prepare HPB read for cached sub-region Daejun Park
[not found] ` <CGME20210607041650epcms2p29002c9d072738bbf21fb4acf31847e8e@epcms2p7>
2021-06-07 4:19 ` [PATCH v36 4/4] scsi: ufs: Add HPB 2.0 support Daejun Park
2021-06-10 1:55 ` 정요한(JOUNG YOHAN) Mobile SE [this message]
2021-06-10 3:37 ` Bart Van Assche
2021-06-10 6:07 ` Greg KH
[not found] ` <CGME20210607041650epcms2p29002c9d072738bbf21fb4acf31847e8e@epcms2p1>
2021-06-10 6:23 ` Daejun Park
2021-06-09 9:53 ` [PATCH v36 0/4] scsi: ufs: Add Host Performance Booster Support Greg KH
2021-06-07 4:17 ` [PATCH v36 1/4] scsi: ufs: Introduce HPB feature Daejun Park
2021-06-10 16:45 ` Bart Van Assche
[not found] ` <CGME20210607041650epcms2p29002c9d072738bbf21fb4acf31847e8e@epcms2p6>
2021-06-11 0:28 ` Daejun Park
2021-06-07 4:18 ` [PATCH v36 2/4] scsi: ufs: L2P map management for HPB read Daejun Park
2021-06-11 1:54 ` RE: [PATCH v36 4/4] scsi: ufs: Add HPB 2.0 support Daejun Park
2021-06-10 2:12 정요한(JOUNG YOHAN) Mobile SE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e540ec7b6d3e4adc97780fcdf87f46aa@sk.com \
--to=yohan.joung@sk.com \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=daejun7.park@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=huobean@gmail.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).