* [PATCH] scripts/coccinelle: modernize &
@ 2016-02-17 23:16 Julia Lawall
2016-02-17 23:47 ` Nishanth Menon
2016-02-19 12:25 ` SF Markus Elfring
0 siblings, 2 replies; 5+ messages in thread
From: Julia Lawall @ 2016-02-17 23:16 UTC (permalink / raw)
To: Julia Lawall
Cc: kernel-janitors, Gilles Muller, Nicolas Palix, Michal Marek,
cocci, linux-kernel, Nishanth Menon
& is no longer allowed in column 0, since Coccinelle 1.0.4.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
scripts/coccinelle/iterators/use_after_iter.cocci | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/coccinelle/iterators/use_after_iter.cocci b/scripts/coccinelle/iterators/use_after_iter.cocci
index f085f59..ce8cc9c 100644
--- a/scripts/coccinelle/iterators/use_after_iter.cocci
+++ b/scripts/coccinelle/iterators/use_after_iter.cocci
@@ -123,7 +123,7 @@ list_remove_head(x,c,...)
|
sizeof(<+...c...+>)
|
-&c->member
+ &c->member
|
c = E
|
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] scripts/coccinelle: modernize &
2016-02-17 23:16 [PATCH] scripts/coccinelle: modernize & Julia Lawall
@ 2016-02-17 23:47 ` Nishanth Menon
2016-02-18 0:46 ` Julia Lawall
2016-02-19 13:09 ` Michal Marek
2016-02-19 12:25 ` SF Markus Elfring
1 sibling, 2 replies; 5+ messages in thread
From: Nishanth Menon @ 2016-02-17 23:47 UTC (permalink / raw)
To: Julia Lawall
Cc: kernel-janitors, Gilles Muller, Nicolas Palix, Michal Marek,
cocci, linux-kernel
On 02/17/2016 05:16 PM, Julia Lawall wrote:
> & is no longer allowed in column 0, since Coccinelle 1.0.4.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> scripts/coccinelle/iterators/use_after_iter.cocci | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/coccinelle/iterators/use_after_iter.cocci b/scripts/coccinelle/iterators/use_after_iter.cocci
> index f085f59..ce8cc9c 100644
> --- a/scripts/coccinelle/iterators/use_after_iter.cocci
> +++ b/scripts/coccinelle/iterators/use_after_iter.cocci
> @@ -123,7 +123,7 @@ list_remove_head(x,c,...)
> |
> sizeof(<+...c...+>)
> |
> -&c->member
> + &c->member
> |
> c = E
> |
>
Verified with:
spatch --version
spatch byte-code version 1.0.4-00118-gc7cf750d1c44 compiled with OCaml
version 4.01.0
Tested-by: Nishanth Menon <nm@ti.com>
--
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] scripts/coccinelle: modernize &
2016-02-17 23:47 ` Nishanth Menon
@ 2016-02-18 0:46 ` Julia Lawall
2016-02-19 13:09 ` Michal Marek
1 sibling, 0 replies; 5+ messages in thread
From: Julia Lawall @ 2016-02-18 0:46 UTC (permalink / raw)
To: Nishanth Menon
Cc: Julia Lawall, kernel-janitors, Gilles Muller, Nicolas Palix,
Michal Marek, cocci, linux-kernel
On Wed, 17 Feb 2016, Nishanth Menon wrote:
> On 02/17/2016 05:16 PM, Julia Lawall wrote:
> > & is no longer allowed in column 0, since Coccinelle 1.0.4.
> >
> > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> >
> > ---
> > scripts/coccinelle/iterators/use_after_iter.cocci | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/coccinelle/iterators/use_after_iter.cocci b/scripts/coccinelle/iterators/use_after_iter.cocci
> > index f085f59..ce8cc9c 100644
> > --- a/scripts/coccinelle/iterators/use_after_iter.cocci
> > +++ b/scripts/coccinelle/iterators/use_after_iter.cocci
> > @@ -123,7 +123,7 @@ list_remove_head(x,c,...)
> > |
> > sizeof(<+...c...+>)
> > |
> > -&c->member
> > + &c->member
> > |
> > c = E
> > |
> >
>
>
> Verified with:
> spatch --version
> spatch byte-code version 1.0.4-00118-gc7cf750d1c44 compiled with OCaml
> version 4.01.0
>
>
> Tested-by: Nishanth Menon <nm@ti.com>
Thanks!
julia
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] scripts/coccinelle: modernize &
2016-02-17 23:47 ` Nishanth Menon
2016-02-18 0:46 ` Julia Lawall
@ 2016-02-19 13:09 ` Michal Marek
1 sibling, 0 replies; 5+ messages in thread
From: Michal Marek @ 2016-02-19 13:09 UTC (permalink / raw)
To: Nishanth Menon, Julia Lawall
Cc: kernel-janitors, Gilles Muller, Nicolas Palix, cocci, linux-kernel
On 2016-02-18 00:47, Nishanth Menon wrote:
> On 02/17/2016 05:16 PM, Julia Lawall wrote:
>> & is no longer allowed in column 0, since Coccinelle 1.0.4.
>>
>> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
[...]
> Verified with:
> spatch --version
> spatch byte-code version 1.0.4-00118-gc7cf750d1c44 compiled with OCaml
> version 4.01.0
>
>
> Tested-by: Nishanth Menon <nm@ti.com>
Applied to kbuild.git#misc with Cc: stable.
Michal
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] scripts/coccinelle: modernize &
2016-02-17 23:16 [PATCH] scripts/coccinelle: modernize & Julia Lawall
2016-02-17 23:47 ` Nishanth Menon
@ 2016-02-19 12:25 ` SF Markus Elfring
1 sibling, 0 replies; 5+ messages in thread
From: SF Markus Elfring @ 2016-02-19 12:25 UTC (permalink / raw)
To: Julia Lawall
Cc: kernel-janitors, cocci, linux-kernel, Gilles Muller,
Harish Chegondi, Michal Marek, Nicolas Palix, Nishanth Menon
> & is no longer allowed in column 0, since Coccinelle 1.0.4.
This information corresponds to the support for handling of conjunctions
in the semantic patch language which was added with the software
release "Coccinelle 1.0.3".
https://systeme.lip6.fr/pipermail/cocci/2015-October/002634.html
> diff --git a/scripts/coccinelle/iterators/use_after_iter.cocci b/scripts/coccinelle/iterators/use_after_iter.cocci
> index f085f59..ce8cc9c 100644
> --- a/scripts/coccinelle/iterators/use_after_iter.cocci
> +++ b/scripts/coccinelle/iterators/use_after_iter.cocci
> @@ -123,7 +123,7 @@ list_remove_head(x,c,...)
> |
> sizeof(<+...c...+>)
> |
> -&c->member
> + &c->member
The added space character is not in the first column of this SmPL script.
* Can it be that the additional character will be transformed according to
special pretty-printing rules?
https://github.com/coccinelle/coccinelle/issues/37
* Is such a change a possible workaround for open issues around
the message "minus: parse error" (or software improvements
which were developed in the meantime)?
> |
> c = E
> |
Does the shown tweak need any further considerations?
Regards,
Markus
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-02-19 13:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-17 23:16 [PATCH] scripts/coccinelle: modernize & Julia Lawall
2016-02-17 23:47 ` Nishanth Menon
2016-02-18 0:46 ` Julia Lawall
2016-02-19 13:09 ` Michal Marek
2016-02-19 12:25 ` SF Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).