From: Steve Muckle <steve.muckle@linaro.org>
To: Michael Turquette <mturquette@baylibre.com>,
"Rafael J. Wysocki" <rafael@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Morten Rasmussen <morten.rasmussen@arm.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Juri Lelli <Juri.Lelli@arm.com>,
Patrick Bellasi <patrick.bellasi@arm.com>,
Viresh Kumar <viresh.kumar@linaro.org>
Subject: Re: [RFCv7 PATCH 02/10] cpufreq: introduce cpufreq_driver_is_slow
Date: Thu, 25 Feb 2016 17:07:01 -0800 [thread overview]
Message-ID: <56CFA535.409@linaro.org> (raw)
In-Reply-To: <20160226005029.2278.38972@quark.deferred.io>
On 02/25/2016 04:50 PM, Michael Turquette wrote:
>> > Something more sophisticated than this is needed, because one driver
>> > may actually be able to do "fast" switching in some cases and may not
>> > be able to do that in other cases.
>
> Those drivers can set the flag dynamically when they probe based on
> their ACPI tables.
I was thinking that the reference here was to a driver that may be able
to do fast switching for some transitions and not for others, say
perhaps depending on the current and target frequencies, or the state of
the regulators, or other system conditions.
Rafael has proposed a fast_switch() addition to the cpufreq API which
currently returns void. Perhaps that could be extended to return success
or failure from the driver. The driver aborts if it cannot complete the
request atomically and quickly.
The scheduler-driven governor could attempt a fast switch if the
callback is installed (and the other criteria for the fast switch are
met, such as not throttled etc, no request already in flight etc). If
the fast switch aborts, fall back to the slow path.
I suppose the governor could also just see if policy->cur has changed as
opposed to checking cpufreq_driver_fast_switch's return value. But then
we can't tell the difference between the fast transition failing because
it must be re-attempted in the slow path, and the fast transition
failing because of some other more serious reason. In the latter case
the request should probably just be dropped rather than retried in the
slow path.
next prev parent reply other threads:[~2016-02-26 1:16 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 1:22 [RFCv7 PATCH 00/10] sched: scheduler-driven CPU frequency selection Steve Muckle
2016-02-23 1:22 ` [RFCv7 PATCH 01/10] sched: Compute cpu capacity available at current frequency Steve Muckle
2016-02-23 1:41 ` Rafael J. Wysocki
2016-02-23 9:19 ` Peter Zijlstra
2016-02-26 1:37 ` Rafael J. Wysocki
2016-02-26 9:14 ` Peter Zijlstra
2016-02-23 1:22 ` [RFCv7 PATCH 02/10] cpufreq: introduce cpufreq_driver_is_slow Steve Muckle
2016-02-23 1:31 ` Rafael J. Wysocki
2016-02-26 0:50 ` Michael Turquette
2016-02-26 1:07 ` Steve Muckle [this message]
2016-02-26 1:16 ` Rafael J. Wysocki
[not found] ` <20160226185503.2278.20479@quark.deferred.io>
2016-02-26 21:00 ` Rafael J. Wysocki
2016-02-23 1:22 ` [RFCv7 PATCH 03/10] sched: scheduler-driven cpu frequency selection Steve Muckle
2016-02-25 3:55 ` Rafael J. Wysocki
2016-02-25 9:21 ` Peter Zijlstra
2016-02-25 21:04 ` Rafael J. Wysocki
2016-02-25 9:28 ` Peter Zijlstra
2016-02-25 21:08 ` Rafael J. Wysocki
2016-02-26 9:18 ` Peter Zijlstra
2016-02-27 0:08 ` Rafael J. Wysocki
2016-03-01 12:57 ` Peter Zijlstra
2016-03-01 19:44 ` Rafael J. Wysocki
2016-02-25 11:04 ` Rafael J. Wysocki
2016-02-26 0:34 ` Steve Muckle
2016-02-27 2:39 ` Rafael J. Wysocki
2016-02-27 4:17 ` Steve Muckle
2016-02-28 2:26 ` Rafael J. Wysocki
2016-03-01 14:31 ` Peter Zijlstra
2016-03-01 20:32 ` Rafael J. Wysocki
2016-03-01 13:26 ` Peter Zijlstra
2016-03-01 13:17 ` Peter Zijlstra
2016-03-02 7:49 ` Michael Turquette
2016-03-03 2:49 ` Rafael J. Wysocki
2016-03-03 3:50 ` Steve Muckle
2016-03-03 9:34 ` Juri Lelli
2016-03-03 13:03 ` Peter Zijlstra
2016-03-03 14:21 ` Ingo Molnar
2016-02-23 1:22 ` [RFCv7 PATCH 04/10] sched/fair: add triggers for OPP change requests Steve Muckle
2016-03-01 6:51 ` Ricky Liang
2016-03-03 3:55 ` Steve Muckle
2016-02-23 1:22 ` [RFCv7 PATCH 05/10] sched/{core,fair}: trigger OPP change request on fork() Steve Muckle
2016-02-23 1:22 ` [RFCv7 PATCH 06/10] sched/fair: cpufreq_sched triggers for load balancing Steve Muckle
2016-02-23 1:22 ` [RFCv7 PATCH 07/10] sched/fair: jump to max OPP when crossing UP threshold Steve Muckle
2016-02-23 1:22 ` [RFCv7 PATCH 08/10] sched: remove call of sched_avg_update from sched_rt_avg_update Steve Muckle
2016-02-23 1:22 ` [RFCv7 PATCH 09/10] sched/deadline: split rt_avg in 2 distincts metrics Steve Muckle
2016-02-23 1:22 ` [RFCv7 PATCH 10/10] sched: rt scheduler sets capacity requirement Steve Muckle
2016-02-23 1:33 ` [RFCv7 PATCH 00/10] sched: scheduler-driven CPU frequency selection Steve Muckle
2016-03-30 0:45 ` Yuyang Du
2016-03-31 1:35 ` Steve Muckle
2016-03-30 20:22 ` Yuyang Du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CFA535.409@linaro.org \
--to=steve.muckle@linaro.org \
--cc=Juri.Lelli@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=mturquette@baylibre.com \
--cc=patrick.bellasi@arm.com \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).