linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 1/1] clocksource/drivers/timer-ti-dm: Fix compile test warning
@ 2022-08-15 13:16 Tony Lindgren
  2022-08-15 13:49 ` Arnd Bergmann
  2022-08-17 19:08 ` Daniel Lezcano
  0 siblings, 2 replies; 3+ messages in thread
From: Tony Lindgren @ 2022-08-15 13:16 UTC (permalink / raw)
  To: Daniel Lezcano, Thomas Gleixner
  Cc: linux-kernel, linux-omap, linux-arm-kernel, kernel test robot,
	Arnd Bergmann

We can get a warning with COMPILE_TEST enabled for omap_timer_match
for 'omap_timer_match' defined but not used.

Fixes: ab0bbef3ae0f ("clocksource/drivers/timer-ti-dm: Make timer selectable for ARCH_K3")
Reported-by: kernel test robot <lkp@intel.com>
Suggested-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Tony Lindgren <tony@atomide.com>

---

Changes since v1:

- Remove of_match_ptr() instead of adding __maybe_unused as suggested by Arnd

---
 drivers/clocksource/timer-ti-dm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/timer-ti-dm.c b/drivers/clocksource/timer-ti-dm.c
--- a/drivers/clocksource/timer-ti-dm.c
+++ b/drivers/clocksource/timer-ti-dm.c
@@ -1081,7 +1081,7 @@ static struct platform_driver omap_dm_timer_driver = {
 	.remove = omap_dm_timer_remove,
 	.driver = {
 		.name   = "omap_timer",
-		.of_match_table = of_match_ptr(omap_timer_match),
+		.of_match_table = omap_timer_match,
 		.pm = &omap_dm_timer_pm_ops,
 	},
 };
-- 
2.37.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2 1/1] clocksource/drivers/timer-ti-dm: Fix compile test warning
  2022-08-15 13:16 [PATCH v2 1/1] clocksource/drivers/timer-ti-dm: Fix compile test warning Tony Lindgren
@ 2022-08-15 13:49 ` Arnd Bergmann
  2022-08-17 19:08 ` Daniel Lezcano
  1 sibling, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2022-08-15 13:49 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: Daniel Lezcano, Thomas Gleixner, linux-kernel, linux-omap,
	linux-arm-kernel, kernel test robot, Arnd Bergmann

On Mon, Aug 15, 2022 at 3:16 PM Tony Lindgren <tony@atomide.com> wrote:
>
> We can get a warning with COMPILE_TEST enabled for omap_timer_match
> for 'omap_timer_match' defined but not used.
>
> Fixes: ab0bbef3ae0f ("clocksource/drivers/timer-ti-dm: Make timer selectable for ARCH_K3")
> Reported-by: kernel test robot <lkp@intel.com>
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
>
> ---
>
> Changes since v1:
>
> - Remove of_match_ptr() instead of adding __maybe_unused as suggested by Arnd
>

Looks good to me,

Acked-by: Arnd Bergmann <arnd@arndb.de>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2 1/1] clocksource/drivers/timer-ti-dm: Fix compile test warning
  2022-08-15 13:16 [PATCH v2 1/1] clocksource/drivers/timer-ti-dm: Fix compile test warning Tony Lindgren
  2022-08-15 13:49 ` Arnd Bergmann
@ 2022-08-17 19:08 ` Daniel Lezcano
  1 sibling, 0 replies; 3+ messages in thread
From: Daniel Lezcano @ 2022-08-17 19:08 UTC (permalink / raw)
  To: Tony Lindgren, Thomas Gleixner
  Cc: linux-kernel, linux-omap, linux-arm-kernel, kernel test robot,
	Arnd Bergmann

On 15/08/2022 15:16, Tony Lindgren wrote:
> We can get a warning with COMPILE_TEST enabled for omap_timer_match
> for 'omap_timer_match' defined but not used.
> 
> Fixes: ab0bbef3ae0f ("clocksource/drivers/timer-ti-dm: Make timer selectable for ARCH_K3")
> Reported-by: kernel test robot <lkp@intel.com>
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> 
> ---
> 
> Changes since v1:
> 
> - Remove of_match_ptr() instead of adding __maybe_unused as suggested by Arnd

Applied for 6.0-rc, thanks



-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-08-17 19:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-15 13:16 [PATCH v2 1/1] clocksource/drivers/timer-ti-dm: Fix compile test warning Tony Lindgren
2022-08-15 13:49 ` Arnd Bergmann
2022-08-17 19:08 ` Daniel Lezcano

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).