* [PATCH] arm64: hw-breakpoint: Remove superfluous SMP function call
@ 2016-04-04 10:42 Anna-Maria Gleixner
2016-04-04 14:06 ` Sergei Shtylyov
2016-04-05 9:26 ` Suzuki K. Poulose
0 siblings, 2 replies; 4+ messages in thread
From: Anna-Maria Gleixner @ 2016-04-04 10:42 UTC (permalink / raw)
To: linux-kernel
Cc: rt, Anna-Maria Gleixner, Catalin Marinas, Will Deacon, linux-arm-kernel
Since commit 1cf4f629d9d2 ("cpu/hotplug: Move online calls to
hotplugged cpu") it is ensured that callbacks of CPU_ONLINE and
CPU_DOWN_PREPARE are processed on the hotplugged cpu. Due to this SMP
function calls are no longer required.
Replace smp_call_function_single() with a direct call of
hw_breakpoint_reset(). To keep the calling convention, interrupts are
explicitely disabled around the call.
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
---
arch/arm64/kernel/hw_breakpoint.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
--- a/arch/arm64/kernel/hw_breakpoint.c
+++ b/arch/arm64/kernel/hw_breakpoint.c
@@ -886,9 +886,11 @@ static int hw_breakpoint_reset_notify(st
unsigned long action,
void *hcpu)
{
- int cpu = (long)hcpu;
- if ((action & ~CPU_TASKS_FROZEN) == CPU_ONLINE)
- smp_call_function_single(cpu, hw_breakpoint_reset, NULL, 1);
+ if ((action & ~CPU_TASKS_FROZEN) == CPU_ONLINE) {
+ local_irq_disable();
+ hw_breakpoint_reset(NULL);
+ local_irq_enable();
+ }
return NOTIFY_OK;
}
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: hw-breakpoint: Remove superfluous SMP function call
2016-04-04 10:42 [PATCH] arm64: hw-breakpoint: Remove superfluous SMP function call Anna-Maria Gleixner
@ 2016-04-04 14:06 ` Sergei Shtylyov
2016-04-05 9:26 ` Suzuki K. Poulose
1 sibling, 0 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2016-04-04 14:06 UTC (permalink / raw)
To: Anna-Maria Gleixner, linux-kernel
Cc: linux-arm-kernel, Catalin Marinas, rt, Will Deacon
On 4/4/2016 1:42 PM, Anna-Maria Gleixner wrote:
> Since commit 1cf4f629d9d2 ("cpu/hotplug: Move online calls to
> hotplugged cpu") it is ensured that callbacks of CPU_ONLINE and
> CPU_DOWN_PREPARE are processed on the hotplugged cpu. Due to this SMP
CPU. My spell checker also trips over "hotplugged"...
> function calls are no longer required.
>
> Replace smp_call_function_single() with a direct call of
> hw_breakpoint_reset(). To keep the calling convention, interrupts are
> explicitely disabled around the call.
Explicitly.
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: hw-breakpoint: Remove superfluous SMP function call
2016-04-04 10:42 [PATCH] arm64: hw-breakpoint: Remove superfluous SMP function call Anna-Maria Gleixner
2016-04-04 14:06 ` Sergei Shtylyov
@ 2016-04-05 9:26 ` Suzuki K. Poulose
2016-04-05 9:39 ` Anna-Maria Gleixner
1 sibling, 1 reply; 4+ messages in thread
From: Suzuki K. Poulose @ 2016-04-05 9:26 UTC (permalink / raw)
To: Anna-Maria Gleixner, linux-kernel
Cc: rt, Catalin Marinas, Will Deacon, linux-arm-kernel
On 04/04/16 11:42, Anna-Maria Gleixner wrote:
> Since commit 1cf4f629d9d2 ("cpu/hotplug: Move online calls to
> hotplugged cpu") it is ensured that callbacks of CPU_ONLINE and
> CPU_DOWN_PREPARE are processed on the hotplugged cpu. Due to this SMP
> function calls are no longer required.
>
> Replace smp_call_function_single() with a direct call of
> hw_breakpoint_reset(). To keep the calling convention, interrupts are
> explicitely disabled around the call.
While you are at it, could you please also fix a similar instance
in arch/arm64/kernel/debug-monitors.c: hw_breakpoint_reset_notify() ?
Thanks
Suzuki
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: hw-breakpoint: Remove superfluous SMP function call
2016-04-05 9:26 ` Suzuki K. Poulose
@ 2016-04-05 9:39 ` Anna-Maria Gleixner
0 siblings, 0 replies; 4+ messages in thread
From: Anna-Maria Gleixner @ 2016-04-05 9:39 UTC (permalink / raw)
To: Suzuki K. Poulose
Cc: linux-kernel, rt, Catalin Marinas, Will Deacon, linux-arm-kernel
On Tue, 5 Apr 2016, Suzuki K. Poulose wrote:
> On 04/04/16 11:42, Anna-Maria Gleixner wrote:
> > Since commit 1cf4f629d9d2 ("cpu/hotplug: Move online calls to
> > hotplugged cpu") it is ensured that callbacks of CPU_ONLINE and
> > CPU_DOWN_PREPARE are processed on the hotplugged cpu. Due to this SMP
> > function calls are no longer required.
> >
> > Replace smp_call_function_single() with a direct call of
> > hw_breakpoint_reset(). To keep the calling convention, interrupts are
> > explicitely disabled around the call.
>
> While you are at it, could you please also fix a similar instance
> in arch/arm64/kernel/debug-monitors.c: hw_breakpoint_reset_notify() ?
I already sent a patch for it, but I misspelled the arm mailinglist
address... I bounced it to the mailinglist.
Anna-Maria
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-04-05 9:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-04 10:42 [PATCH] arm64: hw-breakpoint: Remove superfluous SMP function call Anna-Maria Gleixner
2016-04-04 14:06 ` Sergei Shtylyov
2016-04-05 9:26 ` Suzuki K. Poulose
2016-04-05 9:39 ` Anna-Maria Gleixner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).