[PATCH] ARM: OMAP: wakeupgen: Add comment for unhandled FROZEN transitions

[PATCH] ARM: OMAP: wakeupgen: Add comment for unhandled FROZEN transitions

[Anna-Maria Gleixner]

FROZEN hotplug notifiers are not handled and do not have to be. Insert
a comment to remember that the lack of the FROZEN transitions is no
accident.

Cc: Tony Lindgren <tony@atomide.com>
Cc: Santosh Shilimkar <ssantosh@kernel.org>
Cc: linux-omap@vger.kernel.org
Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
---
 arch/arm/mach-omap2/omap-wakeupgen.c |    5 +++++
 1 file changed, 5 insertions(+)

--- a/arch/arm/mach-omap2/omap-wakeupgen.c
+++ b/arch/arm/mach-omap2/omap-wakeupgen.c
@@ -320,6 +320,11 @@ static int irq_cpu_hotplug_notify(struct
 {
 	unsigned int cpu = (unsigned int)hcpu;
 
+	/*
+	 * Corresponding FROZEN transitions do not have to be handled,
+	 * they are handled by at a higher level
+	 * (drivers/cpuidle/coupled.c).
+	 */
 	switch (action) {
 	case CPU_ONLINE:
 		wakeupgen_irqmask_all(cpu, 0);

Re: [PATCH] ARM: OMAP: wakeupgen: Add comment for unhandled FROZEN transitions

[santosh shilimkar]

On 4/4/2016 5:55 AM, Anna-Maria Gleixner wrote:
> FROZEN hotplug notifiers are not handled and do not have to be. Insert
> a comment to remember that the lack of the FROZEN transitions is no
> accident.
>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Santosh Shilimkar <ssantosh@kernel.org>
> Cc: linux-omap@vger.kernel.org
> Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
> ---
Acked-by: Santosh Shilimkar <ssantosh@kernel.org>

Re: [PATCH] ARM: OMAP: wakeupgen: Add comment for unhandled FROZEN transitions

[Tony Lindgren]

* santosh shilimkar <santosh.shilimkar@oracle.com> [160404 09:06]:
> On 4/4/2016 5:55 AM, Anna-Maria Gleixner wrote:
> >FROZEN hotplug notifiers are not handled and do not have to be. Insert
> >a comment to remember that the lack of the FROZEN transitions is no
> >accident.
> >
> >Cc: Tony Lindgren <tony@atomide.com>
> >Cc: Santosh Shilimkar <ssantosh@kernel.org>
> >Cc: linux-omap@vger.kernel.org
> >Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
> >---
> Acked-by: Santosh Shilimkar <ssantosh@kernel.org>

Yeah looks good to me too, will apply for v4.7 when I get through the
pending fixes here first.

Regards,

Tony

Re: [PATCH] ARM: OMAP: wakeupgen: Add comment for unhandled FROZEN transitions

[Tony Lindgren]

* Tony Lindgren <tony@atomide.com> [160407 10:04]:
> * santosh shilimkar <santosh.shilimkar@oracle.com> [160404 09:06]:
> > On 4/4/2016 5:55 AM, Anna-Maria Gleixner wrote:
> > >FROZEN hotplug notifiers are not handled and do not have to be. Insert
> > >a comment to remember that the lack of the FROZEN transitions is no
> > >accident.
> > >
> > >Cc: Tony Lindgren <tony@atomide.com>
> > >Cc: Santosh Shilimkar <ssantosh@kernel.org>
> > >Cc: linux-omap@vger.kernel.org
> > >Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
> > >---
> > Acked-by: Santosh Shilimkar <ssantosh@kernel.org>
> 
> Yeah looks good to me too, will apply for v4.7 when I get through the
> pending fixes here first.

Applying into omap-for-v4.7/soc thanks.

Tony