linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mtd: gpmi: fix raw_buffer pointer double free issue
@ 2016-04-04 17:25 Han Xu
  2016-04-04 18:18 ` Richard Weinberger
  0 siblings, 1 reply; 5+ messages in thread
From: Han Xu @ 2016-04-04 17:25 UTC (permalink / raw)
  To: han.xu, boris.brezillon, richard, dwmw2, computersforpeace
  Cc: linux-mtd, linux-kernel

fix the raw_buffer pointer double free issue found by coverify.

Signed-off-by: Han Xu <han.xu@nxp.com>
---
 drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
index 8122c69..dcb60b0 100644
--- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
+++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
@@ -797,6 +797,7 @@ static void gpmi_free_dma_buffer(struct gpmi_nand_data *this)
 
 	this->cmd_buffer	= NULL;
 	this->data_buffer_dma	= NULL;
+	this->raw_buffer	= NULL;
 	this->page_buffer_virt	= NULL;
 	this->page_buffer_size	=  0;
 }
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] mtd: gpmi: fix raw_buffer pointer double free issue
  2016-04-04 17:25 [PATCH] mtd: gpmi: fix raw_buffer pointer double free issue Han Xu
@ 2016-04-04 18:18 ` Richard Weinberger
  0 siblings, 0 replies; 5+ messages in thread
From: Richard Weinberger @ 2016-04-04 18:18 UTC (permalink / raw)
  To: Han Xu, boris.brezillon, dwmw2, computersforpeace; +Cc: linux-mtd, linux-kernel

Am 04.04.2016 um 19:25 schrieb Han Xu:
> fix the raw_buffer pointer double free issue found by coverify.

Can you please include the coverity message in you changelog?

> Signed-off-by: Han Xu <han.xu@nxp.com>
> ---
>  drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> index 8122c69..dcb60b0 100644
> --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> @@ -797,6 +797,7 @@ static void gpmi_free_dma_buffer(struct gpmi_nand_data *this)
>  
>  	this->cmd_buffer	= NULL;
>  	this->data_buffer_dma	= NULL;
> +	this->raw_buffer	= NULL;
>  	this->page_buffer_virt	= NULL;
>  	this->page_buffer_size	=  0;

So, gpmi_free_dma_buffer() is called twice and therefore we need to NULL all
these pointers?

Thanks,
//richard

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] mtd: gpmi: fix raw_buffer pointer double free issue
  2016-04-04 20:41 Han Xu
  2016-04-04 21:31 ` Richard Weinberger
@ 2016-04-05 15:43 ` Boris Brezillon
  1 sibling, 0 replies; 5+ messages in thread
From: Boris Brezillon @ 2016-04-05 15:43 UTC (permalink / raw)
  To: Han Xu; +Cc: richard, dwmw2, computersforpeace, linux-mtd, linux-kernel

On Mon, 4 Apr 2016 15:41:29 -0500
Han Xu <han.xu@nxp.com> wrote:

> fix the raw_buffer pointer double free issue found by coverify.
> 
> CID 18344 (#2 of 2): Double free (USE_AFTER_FREE)
> 3. double_free: Calling gpmi_alloc_dma_buffer frees pointer
> this->raw_buffer which has already been freed
> 
> Signed-off-by: Han Xu <han.xu@nxp.com>

Applied.

Thanks,

Boris

> ---
> 
> changes in v2:
>  - add coverity check log
> ---
>  drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> index 8122c69..dcb60b0 100644
> --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> @@ -797,6 +797,7 @@ static void gpmi_free_dma_buffer(struct gpmi_nand_data *this)
>  
>  	this->cmd_buffer	= NULL;
>  	this->data_buffer_dma	= NULL;
> +	this->raw_buffer	= NULL;
>  	this->page_buffer_virt	= NULL;
>  	this->page_buffer_size	=  0;
>  }



-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] mtd: gpmi: fix raw_buffer pointer double free issue
  2016-04-04 20:41 Han Xu
@ 2016-04-04 21:31 ` Richard Weinberger
  2016-04-05 15:43 ` Boris Brezillon
  1 sibling, 0 replies; 5+ messages in thread
From: Richard Weinberger @ 2016-04-04 21:31 UTC (permalink / raw)
  To: Han Xu, boris.brezillon, dwmw2, computersforpeace; +Cc: linux-mtd, linux-kernel

Am 04.04.2016 um 22:41 schrieb Han Xu:
> fix the raw_buffer pointer double free issue found by coverify.
> 
> CID 18344 (#2 of 2): Double free (USE_AFTER_FREE)
> 3. double_free: Calling gpmi_alloc_dma_buffer frees pointer
> this->raw_buffer which has already been freed
> 
> Signed-off-by: Han Xu <han.xu@nxp.com>
> ---
> 
> changes in v2:
>  - add coverity check log
> ---
>  drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> index 8122c69..dcb60b0 100644
> --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> @@ -797,6 +797,7 @@ static void gpmi_free_dma_buffer(struct gpmi_nand_data *this)
>  
>  	this->cmd_buffer	= NULL;
>  	this->data_buffer_dma	= NULL;
> +	this->raw_buffer	= NULL;
>  	this->page_buffer_virt	= NULL;
>  	this->page_buffer_size	=  0;

Reviewed-by: Richard Weinberger <richard@nod.at>

Aside of that, the driver should IMHO be fixed to not call
gpmi_free_dma_buffer() multiple times on the same buffer...

Thanks,
//richard

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH] mtd: gpmi: fix raw_buffer pointer double free issue
@ 2016-04-04 20:41 Han Xu
  2016-04-04 21:31 ` Richard Weinberger
  2016-04-05 15:43 ` Boris Brezillon
  0 siblings, 2 replies; 5+ messages in thread
From: Han Xu @ 2016-04-04 20:41 UTC (permalink / raw)
  To: han.xu, boris.brezillon, richard, dwmw2, computersforpeace
  Cc: linux-mtd, linux-kernel

fix the raw_buffer pointer double free issue found by coverify.

CID 18344 (#2 of 2): Double free (USE_AFTER_FREE)
3. double_free: Calling gpmi_alloc_dma_buffer frees pointer
this->raw_buffer which has already been freed

Signed-off-by: Han Xu <han.xu@nxp.com>
---

changes in v2:
 - add coverity check log
---
 drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
index 8122c69..dcb60b0 100644
--- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
+++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
@@ -797,6 +797,7 @@ static void gpmi_free_dma_buffer(struct gpmi_nand_data *this)
 
 	this->cmd_buffer	= NULL;
 	this->data_buffer_dma	= NULL;
+	this->raw_buffer	= NULL;
 	this->page_buffer_virt	= NULL;
 	this->page_buffer_size	=  0;
 }
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-04-05 15:43 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-04 17:25 [PATCH] mtd: gpmi: fix raw_buffer pointer double free issue Han Xu
2016-04-04 18:18 ` Richard Weinberger
2016-04-04 20:41 Han Xu
2016-04-04 21:31 ` Richard Weinberger
2016-04-05 15:43 ` Boris Brezillon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).