* [PATCH v3] serial: 8250_dw: fix wrong logic in dw8250_check_lcr()
@ 2016-04-05 3:32 Kefeng Wang
2016-04-05 4:02 ` Greg Kroah-Hartman
2016-04-05 5:53 ` [PATCH v4] " Kefeng Wang
0 siblings, 2 replies; 9+ messages in thread
From: Kefeng Wang @ 2016-04-05 3:32 UTC (permalink / raw)
To: Noam Camus, Greg Kroah-Hartman
Cc: Andy Shevchenko, Heikki Krogerus, linux-serial, linux-kernel,
guohanjun, xuwei5, Kefeng Wang
Commit cdcea058e510 ("serial: 8250_dw: Avoid serial_outx code duplicate
with new dw8250_check_lcr()") introduce a wrong logic when write val to
LCR reg. When CONFIG_64BIT enabled, __raw_writeq is used unconditionally.
The __raw_readq/__raw_writeq is introduced by commit bca2092d7897 ("serial:
8250_dw: Use 64-bit access for OCTEON.") for OCTEON, so for !PORT_OCTEON,
we better to use coincident write func.
Fixes: cdcea058e510("serial: 8250_dw: Avoid serial_outx code duplicate with new dw8250_check_lcr()")
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
Keep #ifdef CONFIG_64BIT to ensure it built under arch lacking readq/writeq.
drivers/tty/serial/8250/8250_dw.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
index a3fb95d..47d1f3e 100644
--- a/drivers/tty/serial/8250/8250_dw.c
+++ b/drivers/tty/serial/8250/8250_dw.c
@@ -104,15 +104,16 @@ static void dw8250_check_lcr(struct uart_port *p, int value)
dw8250_force_idle(p);
#ifdef CONFIG_64BIT
- __raw_writeq(value & 0xff, offset);
-#else
+ if (p->type == PORT_OCTEON)
+ __raw_writeq(value & 0xff, offset);
+ else
+#endif
if (p->iotype == UPIO_MEM32)
writel(value, offset);
else if (p->iotype == UPIO_MEM32BE)
iowrite32be(value, offset);
else
writeb(value, offset);
-#endif
}
/*
* FIXME: this deadlocks if port->lock is already held
--
2.6.0.GIT
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v3] serial: 8250_dw: fix wrong logic in dw8250_check_lcr()
2016-04-05 3:32 [PATCH v3] serial: 8250_dw: fix wrong logic in dw8250_check_lcr() Kefeng Wang
@ 2016-04-05 4:02 ` Greg Kroah-Hartman
2016-04-05 4:55 ` Kefeng Wang
2016-04-05 5:53 ` [PATCH v4] " Kefeng Wang
1 sibling, 1 reply; 9+ messages in thread
From: Greg Kroah-Hartman @ 2016-04-05 4:02 UTC (permalink / raw)
To: Kefeng Wang
Cc: Noam Camus, Andy Shevchenko, Heikki Krogerus, linux-serial,
linux-kernel, guohanjun, xuwei5
On Tue, Apr 05, 2016 at 11:32:46AM +0800, Kefeng Wang wrote:
> Commit cdcea058e510 ("serial: 8250_dw: Avoid serial_outx code duplicate
> with new dw8250_check_lcr()") introduce a wrong logic when write val to
> LCR reg. When CONFIG_64BIT enabled, __raw_writeq is used unconditionally.
>
> The __raw_readq/__raw_writeq is introduced by commit bca2092d7897 ("serial:
> 8250_dw: Use 64-bit access for OCTEON.") for OCTEON, so for !PORT_OCTEON,
> we better to use coincident write func.
>
> Fixes: cdcea058e510("serial: 8250_dw: Avoid serial_outx code duplicate with new dw8250_check_lcr()")
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
> Keep #ifdef CONFIG_64BIT to ensure it built under arch lacking readq/writeq.
>
> drivers/tty/serial/8250/8250_dw.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
What changed between all of these versions? Always document that below
the --- line otherwise I think they are all the same and I'll just
delete them all :)
v4 please.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v3] serial: 8250_dw: fix wrong logic in dw8250_check_lcr()
2016-04-05 4:02 ` Greg Kroah-Hartman
@ 2016-04-05 4:55 ` Kefeng Wang
0 siblings, 0 replies; 9+ messages in thread
From: Kefeng Wang @ 2016-04-05 4:55 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Noam Camus, Andy Shevchenko, Heikki Krogerus, linux-serial,
linux-kernel, guohanjun, xuwei5
On 2016/4/5 12:02, Greg Kroah-Hartman wrote:
> On Tue, Apr 05, 2016 at 11:32:46AM +0800, Kefeng Wang wrote:
>> Commit cdcea058e510 ("serial: 8250_dw: Avoid serial_outx code duplicate
>> with new dw8250_check_lcr()") introduce a wrong logic when write val to
>> LCR reg. When CONFIG_64BIT enabled, __raw_writeq is used unconditionally.
>>
>> The __raw_readq/__raw_writeq is introduced by commit bca2092d7897 ("serial:
>> 8250_dw: Use 64-bit access for OCTEON.") for OCTEON, so for !PORT_OCTEON,
>> we better to use coincident write func.
>>
>> Fixes: cdcea058e510("serial: 8250_dw: Avoid serial_outx code duplicate with new dw8250_check_lcr()")
>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
>> ---
>> Keep #ifdef CONFIG_64BIT to ensure it built under arch lacking readq/writeq.
>>
>> drivers/tty/serial/8250/8250_dw.c | 7 ++++---
>> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> What changed between all of these versions? Always document that below
> the --- line otherwise I think they are all the same and I'll just
> delete them all :)
Thanks for your guidance, will add log if with different versions to show what changes.
>
> v4 please.
Ok, thanks again.
>
> thanks,
>
> greg k-h
>
> .
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v4] serial: 8250_dw: fix wrong logic in dw8250_check_lcr()
2016-04-05 3:32 [PATCH v3] serial: 8250_dw: fix wrong logic in dw8250_check_lcr() Kefeng Wang
2016-04-05 4:02 ` Greg Kroah-Hartman
@ 2016-04-05 5:53 ` Kefeng Wang
2016-04-05 10:50 ` Andy Shevchenko
2016-05-02 9:19 ` [PATCH v5] " Kefeng Wang
1 sibling, 2 replies; 9+ messages in thread
From: Kefeng Wang @ 2016-04-05 5:53 UTC (permalink / raw)
To: Noam Camus, Greg Kroah-Hartman
Cc: Andy Shevchenko, Heikki Krogerus, linux-serial, linux-kernel,
guohanjun, xuwei5, wangkefeng.wang
Commit cdcea058e510 ("serial: 8250_dw: Avoid serial_outx code duplicate
with new dw8250_check_lcr()") introduce a wrong logic when write val to
LCR reg. When CONFIG_64BIT enabled, __raw_writeq is used unconditionally.
The __raw_readq/__raw_writeq is introduced by commit bca2092d7897 ("serial:
8250_dw: Use 64-bit access for OCTEON.") for OCTEON, so for !PORT_OCTEON,
we better to use coincident write func.
Fixes: cdcea058e510("serial: 8250_dw: Avoid serial_outx code duplicate with new dw8250_check_lcr()")
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
Changes since v3:
- Add patch change log, suggested by Greg Kroah-Hartman.
Changes since v2:
- Add #ifdef CONFIG_64BIT back, ensure it can be built under configuration lacking readq/writeq.
Changes since v1:
- Repace '#ifdef CONFIG_64BIT' with IS_ENABLED(CONFIG_64BIT).
- Enrich patch log, and add Fixes tag.
drivers/tty/serial/8250/8250_dw.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
index a3fb95d..47d1f3e 100644
--- a/drivers/tty/serial/8250/8250_dw.c
+++ b/drivers/tty/serial/8250/8250_dw.c
@@ -104,15 +104,16 @@ static void dw8250_check_lcr(struct uart_port *p, int value)
dw8250_force_idle(p);
#ifdef CONFIG_64BIT
- __raw_writeq(value & 0xff, offset);
-#else
+ if (p->type == PORT_OCTEON)
+ __raw_writeq(value & 0xff, offset);
+ else
+#endif
if (p->iotype == UPIO_MEM32)
writel(value, offset);
else if (p->iotype == UPIO_MEM32BE)
iowrite32be(value, offset);
else
writeb(value, offset);
-#endif
}
/*
* FIXME: this deadlocks if port->lock is already held
--
2.6.0.GIT
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v4] serial: 8250_dw: fix wrong logic in dw8250_check_lcr()
2016-04-05 5:53 ` [PATCH v4] " Kefeng Wang
@ 2016-04-05 10:50 ` Andy Shevchenko
2016-04-07 8:33 ` Kefeng Wang
2016-05-02 9:19 ` [PATCH v5] " Kefeng Wang
1 sibling, 1 reply; 9+ messages in thread
From: Andy Shevchenko @ 2016-04-05 10:50 UTC (permalink / raw)
To: Kefeng Wang, Noam Camus, Greg Kroah-Hartman
Cc: Heikki Krogerus, linux-serial, linux-kernel, guohanjun, xuwei5
On Tue, 2016-04-05 at 13:53 +0800, Kefeng Wang wrote:
> Commit cdcea058e510 ("serial: 8250_dw: Avoid serial_outx code
> duplicate
> with new dw8250_check_lcr()") introduce a wrong logic when write val
> to
> LCR reg. When CONFIG_64BIT enabled, __raw_writeq is used
> unconditionally.
>
> The __raw_readq/__raw_writeq is introduced by commit bca2092d7897
> ("serial:
> 8250_dw: Use 64-bit access for OCTEON.") for OCTEON, so for
> !PORT_OCTEON,
> we better to use coincident write func.
>
> Fixes: cdcea058e510("serial: 8250_dw: Avoid serial_outx code
> duplicate with new dw8250_check_lcr()")
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
>
> Changes since v3:
> - Add patch change log, suggested by Greg Kroah-Hartman.
> Changes since v2:
> - Add #ifdef CONFIG_64BIT back, ensure it can be built under
Oh, true. Since it's a native IO we can't use writeq() helper from io-
64-nonatomic-*.
> configuration lacking readq/writeq.
> Changes since v1:
> - Repace '#ifdef CONFIG_64BIT' with IS_ENABLED(CONFIG_64BIT).
> - Enrich patch log, and add Fixes tag.
>
>
> drivers/tty/serial/8250/8250_dw.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/tty/serial/8250/8250_dw.c
> b/drivers/tty/serial/8250/8250_dw.c
> index a3fb95d..47d1f3e 100644
> --- a/drivers/tty/serial/8250/8250_dw.c
> +++ b/drivers/tty/serial/8250/8250_dw.c
> @@ -104,15 +104,16 @@ static void dw8250_check_lcr(struct uart_port
> *p, int value)
> dw8250_force_idle(p);
>
> #ifdef CONFIG_64BIT
> - __raw_writeq(value & 0xff, offset);
> -#else
> + if (p->type == PORT_OCTEON)
> + __raw_writeq(value & 0xff, offset);
> + else
> +#endif
> if (p->iotype == UPIO_MEM32)
> writel(value, offset);
> else if (p->iotype == UPIO_MEM32BE)
> iowrite32be(value, offset);
> else
> writeb(value, offset);
> -#endif
So, this changes logic to write the value on any 64 platform, using
different (non-64-bit) accessors, so, the case to fix is
actually "64BIT && !PORT_OCTEON". Perhaps commit message should be
amended to point that clearly.
> }
> /*
> * FIXME: this deadlocks if port->lock is already held
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v4] serial: 8250_dw: fix wrong logic in dw8250_check_lcr()
2016-04-05 10:50 ` Andy Shevchenko
@ 2016-04-07 8:33 ` Kefeng Wang
2016-04-19 8:29 ` Kefeng Wang
2016-04-29 0:44 ` Greg Kroah-Hartman
0 siblings, 2 replies; 9+ messages in thread
From: Kefeng Wang @ 2016-04-07 8:33 UTC (permalink / raw)
To: Andy Shevchenko, Noam Camus, Greg Kroah-Hartman
Cc: Heikki Krogerus, linux-serial, linux-kernel, guohanjun, xuwei5
On 2016/4/5 18:50, Andy Shevchenko wrote:
> On Tue, 2016-04-05 at 13:53 +0800, Kefeng Wang wrote:
>> Commit cdcea058e510 ("serial: 8250_dw: Avoid serial_outx code
>> duplicate
>> with new dw8250_check_lcr()") introduce a wrong logic when write val
>> to
>> LCR reg. When CONFIG_64BIT enabled, __raw_writeq is used
>> unconditionally.
>>
>> The __raw_readq/__raw_writeq is introduced by commit bca2092d7897
>> ("serial:
>> 8250_dw: Use 64-bit access for OCTEON.") for OCTEON, so for
>> !PORT_OCTEON,
>> we better to use coincident write func.
>>
>> Fixes: cdcea058e510("serial: 8250_dw: Avoid serial_outx code
>> duplicate with new dw8250_check_lcr()")
>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
>> ---
>>
>> Changes since v3:
>> - Add patch change log, suggested by Greg Kroah-Hartman.
>> Changes since v2:
>> - Add #ifdef CONFIG_64BIT back, ensure it can be built under
>
> Oh, true. Since it's a native IO we can't use writeq() helper from io-
> 64-nonatomic-*.
>
>> configuration lacking readq/writeq.
>> Changes since v1:
>> - Repace '#ifdef CONFIG_64BIT' with IS_ENABLED(CONFIG_64BIT).
>> - Enrich patch log, and add Fixes tag.
[...]
>
> So, this changes logic to write the value on any 64 platform, using
> different (non-64-bit) accessors, so, the case to fix is
> actually "64BIT && !PORT_OCTEON". Perhaps commit message should be
> amended to point that clearly.
Yes, it's more clear. thanks for review and point it out.
To Greg, should I resend it or can you help me to change the patch log when you merge it. Thanks.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v4] serial: 8250_dw: fix wrong logic in dw8250_check_lcr()
2016-04-07 8:33 ` Kefeng Wang
@ 2016-04-19 8:29 ` Kefeng Wang
2016-04-29 0:44 ` Greg Kroah-Hartman
1 sibling, 0 replies; 9+ messages in thread
From: Kefeng Wang @ 2016-04-19 8:29 UTC (permalink / raw)
To: Andy Shevchenko, Noam Camus, Greg Kroah-Hartman
Cc: Heikki Krogerus, linux-serial, linux-kernel, guohanjun, xuwei5
Hi Greg, ping...
On 2016/4/7 16:33, Kefeng Wang wrote:
>
>
> On 2016/4/5 18:50, Andy Shevchenko wrote:
>> On Tue, 2016-04-05 at 13:53 +0800, Kefeng Wang wrote:
>>> Commit cdcea058e510 ("serial: 8250_dw: Avoid serial_outx code
>>> duplicate
>>> with new dw8250_check_lcr()") introduce a wrong logic when write val
>>> to
>>> LCR reg. When CONFIG_64BIT enabled, __raw_writeq is used
>>> unconditionally.
>>>
>>> The __raw_readq/__raw_writeq is introduced by commit bca2092d7897
>>> ("serial:
>>> 8250_dw: Use 64-bit access for OCTEON.") for OCTEON, so for
>>> !PORT_OCTEON,
>>> we better to use coincident write func.
>>>
>>> Fixes: cdcea058e510("serial: 8250_dw: Avoid serial_outx code
>>> duplicate with new dw8250_check_lcr()")
>>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
>>> ---
>>>
>>> Changes since v3:
>>> - Add patch change log, suggested by Greg Kroah-Hartman.
>>> Changes since v2:
>>> - Add #ifdef CONFIG_64BIT back, ensure it can be built under
>>
>> Oh, true. Since it's a native IO we can't use writeq() helper from io-
>> 64-nonatomic-*.
>>
>>> configuration lacking readq/writeq.
>>> Changes since v1:
>>> - Repace '#ifdef CONFIG_64BIT' with IS_ENABLED(CONFIG_64BIT).
>>> - Enrich patch log, and add Fixes tag.
> [...]
>>
>> So, this changes logic to write the value on any 64 platform, using
>> different (non-64-bit) accessors, so, the case to fix is
>> actually "64BIT && !PORT_OCTEON". Perhaps commit message should be
>> amended to point that clearly.
>
> Yes, it's more clear. thanks for review and point it out.
>
> To Greg, should I resend it or can you help me to change the patch log when you merge it. Thanks.
>
>
>
>
> .
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v4] serial: 8250_dw: fix wrong logic in dw8250_check_lcr()
2016-04-07 8:33 ` Kefeng Wang
2016-04-19 8:29 ` Kefeng Wang
@ 2016-04-29 0:44 ` Greg Kroah-Hartman
1 sibling, 0 replies; 9+ messages in thread
From: Greg Kroah-Hartman @ 2016-04-29 0:44 UTC (permalink / raw)
To: Kefeng Wang
Cc: Andy Shevchenko, Noam Camus, Heikki Krogerus, linux-serial,
linux-kernel, guohanjun, xuwei5
On Thu, Apr 07, 2016 at 04:33:34PM +0800, Kefeng Wang wrote:
>
>
> On 2016/4/5 18:50, Andy Shevchenko wrote:
> > On Tue, 2016-04-05 at 13:53 +0800, Kefeng Wang wrote:
> >> Commit cdcea058e510 ("serial: 8250_dw: Avoid serial_outx code
> >> duplicate
> >> with new dw8250_check_lcr()") introduce a wrong logic when write val
> >> to
> >> LCR reg. When CONFIG_64BIT enabled, __raw_writeq is used
> >> unconditionally.
> >>
> >> The __raw_readq/__raw_writeq is introduced by commit bca2092d7897
> >> ("serial:
> >> 8250_dw: Use 64-bit access for OCTEON.") for OCTEON, so for
> >> !PORT_OCTEON,
> >> we better to use coincident write func.
> >>
> >> Fixes: cdcea058e510("serial: 8250_dw: Avoid serial_outx code
> >> duplicate with new dw8250_check_lcr()")
> >> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> >> ---
> >>
> >> Changes since v3:
> >> - Add patch change log, suggested by Greg Kroah-Hartman.
> >> Changes since v2:
> >> - Add #ifdef CONFIG_64BIT back, ensure it can be built under
> >
> > Oh, true. Since it's a native IO we can't use writeq() helper from io-
> > 64-nonatomic-*.
> >
> >> configuration lacking readq/writeq.
> >> Changes since v1:
> >> - Repace '#ifdef CONFIG_64BIT' with IS_ENABLED(CONFIG_64BIT).
> >> - Enrich patch log, and add Fixes tag.
> [...]
> >
> > So, this changes logic to write the value on any 64 platform, using
> > different (non-64-bit) accessors, so, the case to fix is
> > actually "64BIT && !PORT_OCTEON". Perhaps commit message should be
> > amended to point that clearly.
>
> Yes, it's more clear. thanks for review and point it out.
>
> To Greg, should I resend it or can you help me to change the patch log when you merge it. Thanks.
Please resend it in the form you want it to be.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v5] serial: 8250_dw: fix wrong logic in dw8250_check_lcr()
2016-04-05 5:53 ` [PATCH v4] " Kefeng Wang
2016-04-05 10:50 ` Andy Shevchenko
@ 2016-05-02 9:19 ` Kefeng Wang
1 sibling, 0 replies; 9+ messages in thread
From: Kefeng Wang @ 2016-05-02 9:19 UTC (permalink / raw)
To: noamc, gregkh
Cc: andriy.shevchenko, heikki.krogerus, linux-serial, linux-kernel,
guohanjun, wangkefeng.wang
Commit cdcea058e510 ("serial: 8250_dw: Avoid serial_outx code duplicate
with new dw8250_check_lcr()") introduce a wrong logic when write val to
LCR reg. When CONFIG_64BIT enabled, __raw_writeq is used unconditionally.
The __raw_readq/__raw_writeq is introduced by commit bca2092d7897 ("serial:
8250_dw: Use 64-bit access for OCTEON.") for OCTEON.
So for 64BIT && !PORT_OCTEON, we better to use coincident write function.
Fixes: cdcea058e510("serial: 8250_dw: Avoid serial_outx code duplicate with new dw8250_check_lcr()")
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
Changes since v4:
- Update change log, suggested by Andy Shevchenko.
Changes since v3:
- Add patch change log, suggested by Greg Kroah-Hartman.
Changes since v2:
- Add #ifdef CONFIG_64BIT back, ensure it can be built under configuration lacking readq/writeq.
Changes since v1:
- Repace '#ifdef CONFIG_64BIT' with IS_ENABLED(CONFIG_64BIT).
- Enrich patch log, and add Fixes tag.
drivers/tty/serial/8250/8250_dw.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
index a3fb95d..47d1f3e 100644
--- a/drivers/tty/serial/8250/8250_dw.c
+++ b/drivers/tty/serial/8250/8250_dw.c
@@ -104,15 +104,16 @@ static void dw8250_check_lcr(struct uart_port *p, int value)
dw8250_force_idle(p);
#ifdef CONFIG_64BIT
- __raw_writeq(value & 0xff, offset);
-#else
+ if (p->type == PORT_OCTEON)
+ __raw_writeq(value & 0xff, offset);
+ else
+#endif
if (p->iotype == UPIO_MEM32)
writel(value, offset);
else if (p->iotype == UPIO_MEM32BE)
iowrite32be(value, offset);
else
writeb(value, offset);
-#endif
}
/*
* FIXME: this deadlocks if port->lock is already held
--
2.6.0.GIT
^ permalink raw reply related [flat|nested] 9+ messages in thread
end of thread, other threads:[~2016-05-02 9:14 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-05 3:32 [PATCH v3] serial: 8250_dw: fix wrong logic in dw8250_check_lcr() Kefeng Wang
2016-04-05 4:02 ` Greg Kroah-Hartman
2016-04-05 4:55 ` Kefeng Wang
2016-04-05 5:53 ` [PATCH v4] " Kefeng Wang
2016-04-05 10:50 ` Andy Shevchenko
2016-04-07 8:33 ` Kefeng Wang
2016-04-19 8:29 ` Kefeng Wang
2016-04-29 0:44 ` Greg Kroah-Hartman
2016-05-02 9:19 ` [PATCH v5] " Kefeng Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).