* [PATCH] m68k/gpio: remove arch specific sysfs bus device
@ 2016-04-06 2:32 Greg Ungerer
2016-04-06 6:57 ` Linus Walleij
0 siblings, 1 reply; 3+ messages in thread
From: Greg Ungerer @ 2016-04-06 2:32 UTC (permalink / raw)
To: linux-m68k, linux, linux-gpio, linux-kernel, gnurou, linus.walleij
Cc: Greg Ungerer
From: Greg Ungerer <gerg@gumby.(none)>
The ColdFire architecture specific gpio support code registers a sysfs
bus device named "gpio". This clashes with the new generic API device
added in commit 3c702e99 ("gpio: add a userspace chardev ABI for GPIOs").
The old ColdFire sysfs gpio device was never used for anything specific,
and no links or other nodes were created under it. The new API sysfs gpio
device has all the same default sysfs links (device, drivers, etc) and
they are properly populated.
Remove the old ColdFire sysfs gpio registration.
Signed-off-by: Greg Ungerer <gerg@uclinux.org>
---
arch/m68k/coldfire/gpio.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/arch/m68k/coldfire/gpio.c b/arch/m68k/coldfire/gpio.c
index 8832083..b515809 100644
--- a/arch/m68k/coldfire/gpio.c
+++ b/arch/m68k/coldfire/gpio.c
@@ -158,11 +158,6 @@ static int mcfgpio_to_irq(struct gpio_chip *chip, unsigned offset)
return -EINVAL;
}
-static struct bus_type mcfgpio_subsys = {
- .name = "gpio",
- .dev_name = "gpio",
-};
-
static struct gpio_chip mcfgpio_chip = {
.label = "mcfgpio",
.request = mcfgpio_request,
@@ -178,8 +173,7 @@ static struct gpio_chip mcfgpio_chip = {
static int __init mcfgpio_sysinit(void)
{
- gpiochip_add_data(&mcfgpio_chip, NULL);
- return subsys_system_register(&mcfgpio_subsys, NULL);
+ return gpiochip_add_data(&mcfgpio_chip, NULL);
}
core_initcall(mcfgpio_sysinit);
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] m68k/gpio: remove arch specific sysfs bus device
2016-04-06 2:32 [PATCH] m68k/gpio: remove arch specific sysfs bus device Greg Ungerer
@ 2016-04-06 6:57 ` Linus Walleij
2016-04-06 19:31 ` Greg Ungerer
0 siblings, 1 reply; 3+ messages in thread
From: Linus Walleij @ 2016-04-06 6:57 UTC (permalink / raw)
To: Greg Ungerer
Cc: linux-m68k, Guenter Roeck, linux-gpio, linux-kernel, Alexandre Courbot
On Wed, Apr 6, 2016 at 4:32 AM, Greg Ungerer <gerg@uclinux.org> wrote:
> From: Greg Ungerer <gerg@gumby.(none)>
>
> The ColdFire architecture specific gpio support code registers a sysfs
> bus device named "gpio". This clashes with the new generic API device
> added in commit 3c702e99 ("gpio: add a userspace chardev ABI for GPIOs").
>
> The old ColdFire sysfs gpio device was never used for anything specific,
> and no links or other nodes were created under it. The new API sysfs gpio
> device has all the same default sysfs links (device, drivers, etc) and
> they are properly populated.
>
> Remove the old ColdFire sysfs gpio registration.
>
> Signed-off-by: Greg Ungerer <gerg@uclinux.org>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] m68k/gpio: remove arch specific sysfs bus device
2016-04-06 6:57 ` Linus Walleij
@ 2016-04-06 19:31 ` Greg Ungerer
0 siblings, 0 replies; 3+ messages in thread
From: Greg Ungerer @ 2016-04-06 19:31 UTC (permalink / raw)
To: Linus Walleij
Cc: linux-m68k, Guenter Roeck, linux-gpio, linux-kernel, Alexandre Courbot
On 06/04/16 16:57, Linus Walleij wrote:
> On Wed, Apr 6, 2016 at 4:32 AM, Greg Ungerer <gerg@uclinux.org> wrote:
>
>> From: Greg Ungerer <gerg@gumby.(none)>
>>
>> The ColdFire architecture specific gpio support code registers a sysfs
>> bus device named "gpio". This clashes with the new generic API device
>> added in commit 3c702e99 ("gpio: add a userspace chardev ABI for GPIOs").
>>
>> The old ColdFire sysfs gpio device was never used for anything specific,
>> and no links or other nodes were created under it. The new API sysfs gpio
>> device has all the same default sysfs links (device, drivers, etc) and
>> they are properly populated.
>>
>> Remove the old ColdFire sysfs gpio registration.
>>
>> Signed-off-by: Greg Ungerer <gerg@uclinux.org>
>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
Thanks Linus. I will push via the m68knommu git tree.
Regards
Greg
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-04-06 19:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-06 2:32 [PATCH] m68k/gpio: remove arch specific sysfs bus device Greg Ungerer
2016-04-06 6:57 ` Linus Walleij
2016-04-06 19:31 ` Greg Ungerer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).