From: Robin Murphy <robin.murphy@arm.com>
To: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Cc: Mark Rutland <mark.rutland@arm.com>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Rob Herring <robh+dt@kernel.org>,
Richard Purdie <rpurdie@rpsys.net>,
Kumar Gala <galak@codeaurora.org>,
Jacek Anaszewski <j.anaszewski@samsung.com>
Subject: Re: [PATCH v2 2/3] devicetree: leds: Introduce "panic-indicator" optional property
Date: Thu, 14 Apr 2016 17:46:43 +0100 [thread overview]
Message-ID: <570FC973.2040708@arm.com> (raw)
In-Reply-To: <1460570899-24642-3-git-send-email-ezequiel@vanguardiasur.com.ar>
Hi Ezequiel,
On 13/04/16 19:08, Ezequiel Garcia wrote:
> It's desirable to specify which LEDs are to be blinked on a kernel
> panic. Therefore, introduce a devicetree boolean property to mark
> which LEDs should be treated this way, if possible.
>
> Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
> ---
> Documentation/devicetree/bindings/leds/common.txt | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/leds/common.txt b/Documentation/devicetree/bindings/leds/common.txt
> index 68419843e32f..7b646a7808ce 100644
> --- a/Documentation/devicetree/bindings/leds/common.txt
> +++ b/Documentation/devicetree/bindings/leds/common.txt
> @@ -37,6 +37,9 @@ Optional properties for child nodes:
> property is mandatory for the LEDs in the non-flash modes
> (e.g. torch or indicator).
>
> +- panic-indicator : This properties specifies that the LED should be used,
s/properties/property/
Maybe phrasing it as "should also be used" might make the intention a
bit clearer, as well.
Robin.
> + if at all possible, as a panic indicator.
> +
> Required properties for flash LED child nodes:
> - flash-max-microamp : Maximum flash LED supply current in microamperes.
> - flash-max-timeout-us : Maximum timeout in microseconds after which the flash
>
next prev parent reply other threads:[~2016-04-14 16:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 18:08 [PATCH v2 0/3] Extend the LED panic trigger Ezequiel Garcia
2016-04-13 18:08 ` [PATCH v2 1/3] leds: triggers: Allow to switch the trigger to "panic" on a kernel panic Ezequiel Garcia
2016-04-13 18:08 ` [PATCH v2 2/3] devicetree: leds: Introduce "panic-indicator" optional property Ezequiel Garcia
2016-04-14 16:33 ` Rob Herring
2016-04-14 16:46 ` Robin Murphy [this message]
2016-04-13 18:08 ` [PATCH v2 3/3] leds: gpio: Support the "panic-indicator" firmware property Ezequiel Garcia
2016-04-14 8:57 ` Jacek Anaszewski
2016-04-19 16:18 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570FC973.2040708@arm.com \
--to=robin.murphy@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=j.anaszewski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).