From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: qiujiang <qiujiang@huawei.com>, <linus.walleij@linaro.org>,
<gnurou@gmail.com>
Cc: <linux-acpi@vger.kernel.org>, <charles.chenxin@huawei.com>,
<linux-kernel@vger.kernel.org>, <linuxarm@huawei.com>,
<linux-gpio@vger.kernel.org>, <andy.shevchenko@gmail.com>,
<jamie@jamieiles.com>, <mika.westerberg@linux.intel.com>,
<delicious.quinoa@gmail.com>
Subject: Re: [PATCH v7 2/3] gpio: dwapb: convert device node to fwnode
Date: Fri, 15 Apr 2016 10:29:53 +0800 [thread overview]
Message-ID: <57105221.2030202@huawei.com> (raw)
In-Reply-To: <1459926480-32966-3-git-send-email-qiujiang@huawei.com>
On 2016/4/6 15:07, qiujiang wrote:
> This patch converts device node to fwnode for dwapb driver, so
> as to provide a unified fwnode for DT and ACPI bindings.
>
> Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: qiujiang <qiujiang@huawei.com>
> ---
> drivers/gpio/gpio-dwapb.c | 37 ++++++++++++++++----------------
> drivers/mfd/intel_quark_i2c_gpio.c | 2 +-
> include/linux/platform_data/gpio-dwapb.h | 2 +-
> 3 files changed, 20 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
> index 91afec8..3c4d8e6 100644
> --- a/drivers/gpio/gpio-dwapb.c
> +++ b/drivers/gpio/gpio-dwapb.c
> @@ -22,6 +22,7 @@
> #include <linux/of_address.h>
> #include <linux/of_irq.h>
> #include <linux/platform_device.h>
> +#include <linux/property.h>
> #include <linux/spinlock.h>
> #include <linux/platform_data/gpio-dwapb.h>
> #include <linux/slab.h>
> @@ -290,14 +291,14 @@ static void dwapb_configure_irqs(struct dwapb_gpio *gpio,
> struct dwapb_port_property *pp)
> {
> struct gpio_chip *gc = &port->gc;
> - struct device_node *node = pp->node;
> + struct fwnode_handle *fwnode = pp->fwnode;
> struct irq_chip_generic *irq_gc = NULL;
> unsigned int hwirq, ngpio = gc->ngpio;
> struct irq_chip_type *ct;
> int err, i;
>
> - gpio->domain = irq_domain_add_linear(node, ngpio,
> - &irq_generic_chip_ops, gpio);
> + gpio->domain = irq_domain_create_linear(fwnode, ngpio,
> + &irq_generic_chip_ops, gpio);
> if (!gpio->domain)
> return;
>
> @@ -414,7 +415,8 @@ static int dwapb_gpio_add_port(struct dwapb_gpio *gpio,
> }
>
> #ifdef CONFIG_OF_GPIO
> - port->gc.of_node = pp->node;
> + port->gc.of_node = is_of_node(pp->fwnode) ?
> + to_of_node(pp->fwnode) : NULL;
It is enough to use port->gc.of_node = to_of_node(pp->fwnode);
next prev parent reply other threads:[~2016-04-15 2:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-06 7:07 [PATCH v7 0/3] gpio: dwapb: add gpio-signaled acpi event support for power button qiujiang
2016-04-06 7:07 ` [PATCH v7 1/3] gpio: dwapb: remove name from dwapb_port_property qiujiang
2016-04-06 12:57 ` Andy Shevchenko
2016-04-07 11:45 ` Jiang Qiu
2016-04-06 7:07 ` [PATCH v7 2/3] gpio: dwapb: convert device node to fwnode qiujiang
2016-04-06 13:01 ` Andy Shevchenko
2016-04-07 11:14 ` Jiang Qiu
2016-04-15 2:29 ` Kefeng Wang [this message]
2016-04-06 7:08 ` [PATCH v7 3/3] gpio: dwapb: add gpio-signaled acpi event support qiujiang
2016-04-08 8:26 ` Linus Walleij
2016-04-08 8:38 ` Mika Westerberg
2016-04-11 12:43 ` Jiang Qiu
2016-04-12 6:46 ` Mika Westerberg
2016-04-12 6:55 ` Jiang Qiu
2016-04-15 7:40 ` Linus Walleij
2016-04-15 7:58 ` Jiang Qiu
2016-04-11 13:00 ` Linus Walleij
2016-04-11 12:33 ` Jiang Qiu
2016-04-06 13:03 ` [PATCH v7 0/3] gpio: dwapb: add gpio-signaled acpi event support for power button Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57105221.2030202@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=andy.shevchenko@gmail.com \
--cc=charles.chenxin@huawei.com \
--cc=delicious.quinoa@gmail.com \
--cc=gnurou@gmail.com \
--cc=jamie@jamieiles.com \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mika.westerberg@linux.intel.com \
--cc=qiujiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).