From: Linus Walleij <linus.walleij@linaro.org>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Jiang Qiu <qiujiang@huawei.com>,
Alexandre Courbot <gnurou@gmail.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Alan Tull <delicious.quinoa@gmail.com>,
Jamie Iles <jamie@jamieiles.com>,
charles.chenxin@huawei.com,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linuxarm <linuxarm@huawei.com>
Subject: Re: [PATCH v7 3/3] gpio: dwapb: add gpio-signaled acpi event support
Date: Fri, 15 Apr 2016 09:40:05 +0200 [thread overview]
Message-ID: <CACRpkdY=i9BVYEpu0svmKOQJURH2nQ5iwCM0895fODmkVuPBew@mail.gmail.com> (raw)
In-Reply-To: <20160412064657.GF1714@lahna.fi.intel.com>
On Tue, Apr 12, 2016 at 8:46 AM, Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
> On Mon, Apr 11, 2016 at 08:43:22PM +0800, Jiang Qiu wrote:
>> > Currently it just complains if something goes wrong. The GPIO driver
>> > itself can still work just fine (including interrupts).
>> >
>> > I'm fine to change it to return an error code.
>> Agree, if add a error code for acpi_gpiochip_request_interrupts(), it looks more pretty.
>>
>> However, this function is common for other part, maybe cause any other effects if I
>> do this change, did you think so?
>
> I'm thinking what the callers are going to do with the error code.
> Basically it means that we were not able to attach and configure ACPI
> event GPIOs. It does not prevent GPIO drivers from functioning so they
> probably just print out some warning message and continue probing, and
> we already warn in acpi_gpiochip_request_interrupts() if something fails.
>
> Unless Linus W insists, let's just keep it as is for now :)
I'm fine with it, don' worry.
I'm just waiting for this patch set to mature so I can apply
it.
Yours,
Linus Walleij
next prev parent reply other threads:[~2016-04-15 7:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-06 7:07 [PATCH v7 0/3] gpio: dwapb: add gpio-signaled acpi event support for power button qiujiang
2016-04-06 7:07 ` [PATCH v7 1/3] gpio: dwapb: remove name from dwapb_port_property qiujiang
2016-04-06 12:57 ` Andy Shevchenko
2016-04-07 11:45 ` Jiang Qiu
2016-04-06 7:07 ` [PATCH v7 2/3] gpio: dwapb: convert device node to fwnode qiujiang
2016-04-06 13:01 ` Andy Shevchenko
2016-04-07 11:14 ` Jiang Qiu
2016-04-15 2:29 ` Kefeng Wang
2016-04-06 7:08 ` [PATCH v7 3/3] gpio: dwapb: add gpio-signaled acpi event support qiujiang
2016-04-08 8:26 ` Linus Walleij
2016-04-08 8:38 ` Mika Westerberg
2016-04-11 12:43 ` Jiang Qiu
2016-04-12 6:46 ` Mika Westerberg
2016-04-12 6:55 ` Jiang Qiu
2016-04-15 7:40 ` Linus Walleij [this message]
2016-04-15 7:58 ` Jiang Qiu
2016-04-11 13:00 ` Linus Walleij
2016-04-11 12:33 ` Jiang Qiu
2016-04-06 13:03 ` [PATCH v7 0/3] gpio: dwapb: add gpio-signaled acpi event support for power button Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdY=i9BVYEpu0svmKOQJURH2nQ5iwCM0895fODmkVuPBew@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=andy.shevchenko@gmail.com \
--cc=charles.chenxin@huawei.com \
--cc=delicious.quinoa@gmail.com \
--cc=gnurou@gmail.com \
--cc=jamie@jamieiles.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mika.westerberg@linux.intel.com \
--cc=qiujiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).