From: "Matias Bjørling" <m@bjorling.me>
To: "Javier González" <jg@lightnvm.io>
Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH 1/3] lightnvm: do not free unused metadata on rrpc
Date: Wed, 27 Apr 2016 20:56:37 +0200 [thread overview]
Message-ID: <57210B65.5020800@bjorling.me> (raw)
In-Reply-To: <1461778138-23116-1-git-send-email-javier@javigon.com>
On 04/27/2016 07:28 PM, Javier González wrote:
> rrpc does not save any metadata on a given request. Thus, do not attempt
> to free the metadata dma region.
>
> Signed-off-by: Javier González <javier@cnexlabs.com>
> ---
> drivers/lightnvm/rrpc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/lightnvm/rrpc.c b/drivers/lightnvm/rrpc.c
> index c7fef71..ffcfee6 100644
> --- a/drivers/lightnvm/rrpc.c
> +++ b/drivers/lightnvm/rrpc.c
> @@ -711,8 +711,6 @@ static void rrpc_end_io(struct nvm_rq *rqd)
>
> if (npages > 1)
> nvm_dev_dma_free(rrpc->dev, rqd->ppa_list, rqd->dma_ppa_list);
> - if (rqd->metadata)
> - nvm_dev_dma_free(rrpc->dev, rqd->metadata, rqd->dma_metadata);
>
> mempool_free(rqd, rrpc->rq_pool);
> }
>
Thanks. Applied for 4.7.
next prev parent reply other threads:[~2016-04-27 18:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-27 17:28 [PATCH 1/3] lightnvm: do not free unused metadata on rrpc Javier González
2016-04-27 17:28 ` [PATCH 2/3] lightnvm: enable metadata to be sent to device Javier González
2016-04-28 13:47 ` Matias Bjørling
2016-04-27 17:28 ` [PATCH 3/3] lightnvm: rename dma helper functions Javier González
2016-04-27 18:54 ` Matias Bjørling
2016-04-27 20:17 ` Javier González
2016-04-27 18:56 ` Matias Bjørling [this message]
2016-04-28 13:41 ` [PATCH 1/3] lightnvm: do not free unused metadata on rrpc Matias Bjørling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57210B65.5020800@bjorling.me \
--to=m@bjorling.me \
--cc=jg@lightnvm.io \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).