linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Javier González" <javigon.napster@gmail.com>
To: "Matias Bjørling" <m@bjorling.me>
Cc: "Javier González" <jg@lightnvm.io>,
	mb@lightnvm.io, linux-kernel@vger.kernel.org,
	linux-block@vger.kernel.org,
	"Javier González" <javier@cnexlabs.com>
Subject: Re: [PATCH 3/3] lightnvm: rename dma helper functions
Date: Wed, 27 Apr 2016 22:17:11 +0200	[thread overview]
Message-ID: <974FE028-A0AD-44D8-9CF9-D690EC08C0CF@gmail.com> (raw)
In-Reply-To: <57210AEA.8010206@bjorling.me>


>>      if (dev->ops->max_phys_sect > 1) {
>> -        dev->ppalist_pool = dev->ops->create_dma_pool(dev, "ppalist");
>> -        if (!dev->ppalist_pool) {
>> +        dev->dma_page_pool = dev->ops->create_dma_pool(dev, "ppalist");
> 
> rename to dmapool or something similar?
> 
>> +        if (!dev->dma_page_pool) {
>>              pr_err("nvm: could not create ppa pool\n");
> 
> Make sure to fix up the text here as well. Else it looks good.
> 
>>              ret = -ENOMEM;
> 

Thanks. I'll fix it and resubmit tomorrow. 

Javier. 

  reply	other threads:[~2016-04-27 20:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-27 17:28 [PATCH 1/3] lightnvm: do not free unused metadata on rrpc Javier González
2016-04-27 17:28 ` [PATCH 2/3] lightnvm: enable metadata to be sent to device Javier González
2016-04-28 13:47   ` Matias Bjørling
2016-04-27 17:28 ` [PATCH 3/3] lightnvm: rename dma helper functions Javier González
2016-04-27 18:54   ` Matias Bjørling
2016-04-27 20:17     ` Javier González [this message]
2016-04-27 18:56 ` [PATCH 1/3] lightnvm: do not free unused metadata on rrpc Matias Bjørling
2016-04-28 13:41 ` Matias Bjørling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=974FE028-A0AD-44D8-9CF9-D690EC08C0CF@gmail.com \
    --to=javigon.napster@gmail.com \
    --cc=javier@cnexlabs.com \
    --cc=jg@lightnvm.io \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m@bjorling.me \
    --cc=mb@lightnvm.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).