[PATCH v3 0/2] phy: rcar-gen2, rcar-gen3-usb2: add fallback binding

[PATCH v3 0/2] phy: rcar-gen2, rcar-gen3-usb2: add fallback binding

[Simon Horman]

Add fallback compatibility strings for rcar phy drivers.

In the case of Renesas R-Car hardware we know that there are generations of
SoCs, e.g. Gen 2 and Gen 3. But beyond that its not clear what the
relationship between IP blocks might be. For example, I believe that
r8a7790 is older than r8a7791 but that doesn't imply that the latter is a
descendant of the former or vice versa.

We can, however, by examining the documentation and behaviour of the
hardware at run-time observe that the current driver implementation appears
to be compatible with the IP blocks on SoCs within a given generation.

For the above reasons and convenience when enabling new SoCs a
per-generation fallback compatibility string scheme being adopted for
drivers for Renesas SoCs.

Changes in v3:
* Added Acks
* Corrected whitespace in examples

Changes in v2:
* Update new compatibility strings to match the preferred scheme for
  ordering elements
* Rebase

Simon Horman (2):
  phy: rcar-gen2: add fallback binding
  phy: rcar-gen3-usb2: add fallback binding

 Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt      |  8 +++++++-
 Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt | 10 ++++++++--
 drivers/phy/phy-rcar-gen2.c                                  |  1 +
 drivers/phy/phy-rcar-gen3-usb2.c                             |  1 +
 4 files changed, 17 insertions(+), 3 deletions(-)

-- 
2.1.4

[PATCH v3 1/2] phy: rcar-gen2: add fallback binding

[Simon Horman]

In the case of Renesas R-Car hardware we know that there are generations of
SoCs, e.g. Gen 2 and Gen 3. But beyond that its not clear what the
relationship between IP blocks might be. For example, I believe that
r8a7790 is older than r8a7791 but that doesn't imply that the latter is a
descendant of the former or vice versa.

We can, however, by examining the documentation and behaviour of the
hardware at run-time observe that the current driver implementation appears
to be compatible with the IP blocks on SoCs within a given generation.

For the above reasons and convenience when enabling new SoCs a
per-generation fallback compatibility string scheme being adopted for
drivers for Renesas SoCs.

Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Rob Herring <robh@kernel.org>
---
v3
* Added Acks from Geert Uytterhoeven and Rob Herring
* Correct whitespace in example

v2
* Use renesas,rcar-gen2-usb-phy rather than renesas,usb-phy-gen2 as
  the new compatibility string to fit in with the preferred scheme
  for new compatibility string names.
---
 Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt | 8 +++++++-
 drivers/phy/phy-rcar-gen2.c                             | 1 +
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt b/Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt
index d564ba4f1cf6..91da947ae9b6 100644
--- a/Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt
+++ b/Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt
@@ -7,6 +7,12 @@ Required properties:
 - compatible: "renesas,usb-phy-r8a7790" if the device is a part of R8A7790 SoC.
 	      "renesas,usb-phy-r8a7791" if the device is a part of R8A7791 SoC.
 	      "renesas,usb-phy-r8a7794" if the device is a part of R8A7794 SoC.
+	      "renesas,rcar-gen2-usb-phy" for a generic R-Car Gen2 compatible device.
+
+	      When compatible with the generic version, nodes must list the
+	      SoC-specific version corresponding to the platform first
+	      followed by the generic version.
+
 - reg: offset and length of the register block.
 - #address-cells: number of address cells for the USB channel subnodes, must
 		  be <1>.
@@ -34,7 +40,7 @@ the USB channel; see the selector meanings below:
 Example (Lager board):
 
 	usb-phy@e6590100 {
-		compatible = "renesas,usb-phy-r8a7790";
+		compatible = "renesas,usb-phy-r8a7790", "renesas,rcar-gen2-usb-phy";
 		reg = <0 0xe6590100 0 0x100>;
 		#address-cells = <1>;
 		#size-cells = <0>;
diff --git a/drivers/phy/phy-rcar-gen2.c b/drivers/phy/phy-rcar-gen2.c
index c7a05996d5c1..97d4dd6ea924 100644
--- a/drivers/phy/phy-rcar-gen2.c
+++ b/drivers/phy/phy-rcar-gen2.c
@@ -195,6 +195,7 @@ static const struct of_device_id rcar_gen2_phy_match_table[] = {
 	{ .compatible = "renesas,usb-phy-r8a7790" },
 	{ .compatible = "renesas,usb-phy-r8a7791" },
 	{ .compatible = "renesas,usb-phy-r8a7794" },
+	{ .compatible = "renesas,rcar-gen2-usb-phy" },
 	{ }
 };
 MODULE_DEVICE_TABLE(of, rcar_gen2_phy_match_table);
-- 
2.1.4

[PATCH v3 2/2] phy: rcar-gen3-usb2: add fallback binding

[Simon Horman]

In the case of Renesas R-Car hardware we know that there are generations of
SoCs, e.g. Gen 2 and Gen 3. But beyond that its not clear what the
relationship between IP blocks might be. For example, I believe that
r8a7790 is older than r8a7791 but that doesn't imply that the latter is a
descendant of the former or vice versa.

We can, however, by examining the documentation and behaviour of the
hardware at run-time observe that the current driver implementation appears
to be compatible with the IP blocks on SoCs within a given generation.

For the above reasons and convenience when enabling new SoCs a
per-generation fallback compatibility string scheme being adopted for
drivers for Renesas SoCs.

Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Rob Herring <robh@kernel.org>
Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
v3
* Added Acks from Geert Uytterhoeven, Rob Herring and Shimoda-san
* Corrected whitespace in examples

v2
* Use renesas,rcar-gen3-usb2-phy rather than renesas,usb2-phy-gen3 as
  the new compatibility string to fit in with the preferred scheme
  for new compatibility string names.
---
 Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt | 10 ++++++++--
 drivers/phy/phy-rcar-gen3-usb2.c                             |  1 +
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt b/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt
index eaf7e9b7ce6b..f9511ad95b94 100644
--- a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt
+++ b/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt
@@ -6,6 +6,12 @@ This file provides information on what the device node for the R-Car generation
 Required properties:
 - compatible: "renesas,usb2-phy-r8a7795" if the device is a part of an R8A7795
 	      SoC.
+	      "renesas,rcar-gen3-usb2-phy" for a generic R-Car Gen3 compatible device.
+
+	      When compatible with the generic version, nodes must list the
+	      SoC-specific version corresponding to the platform first
+	      followed by the generic version.
+
 - reg: offset and length of the partial USB 2.0 Host register block.
 - clocks: clock phandle and specifier pair(s).
 - #phy-cells: see phy-bindings.txt in the same directory, must be <0>.
@@ -19,14 +25,14 @@ channel as USB OTG:
 Example (R-Car H3):
 
 	usb-phy@ee080200 {
-		compatible = "renesas,usb2-phy-r8a7795";
+		compatible = "renesas,usb2-phy-r8a7795", "renesas,rcar-gen3-usb2-phy";
 		reg = <0 0xee080200 0 0x700>;
 		interrupts = <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>;
 		clocks = <&mstp7_clks R8A7795_CLK_EHCI0>;
 	};
 
 	usb-phy@ee0a0200 {
-		compatible = "renesas,usb2-phy-r8a7795";
+		compatible = "renesas,usb2-phy-r8a7795", "renesas,rcar-gen3-usb2-phy";
 		reg = <0 0xee0a0200 0 0x700>;
 		clocks = <&mstp7_clks R8A7795_CLK_EHCI0>;
 	};
diff --git a/drivers/phy/phy-rcar-gen3-usb2.c b/drivers/phy/phy-rcar-gen3-usb2.c
index bc4f7dd821aa..257be74f93f5 100644
--- a/drivers/phy/phy-rcar-gen3-usb2.c
+++ b/drivers/phy/phy-rcar-gen3-usb2.c
@@ -251,6 +251,7 @@ static irqreturn_t rcar_gen3_phy_usb2_irq(int irq, void *_ch)
 
 static const struct of_device_id rcar_gen3_phy_usb2_match_table[] = {
 	{ .compatible = "renesas,usb2-phy-r8a7795" },
+	{ .compatible = "renesas,rcar-gen3-usb2-phy" },
 	{ }
 };
 MODULE_DEVICE_TABLE(of, rcar_gen3_phy_usb2_match_table);
-- 
2.1.4

Re: [PATCH v3 0/2] phy: rcar-gen2, rcar-gen3-usb2: add fallback binding

[Simon Horman]

On Mon, Mar 07, 2016 at 10:58:39AM +0900, Simon Horman wrote:
> Add fallback compatibility strings for rcar phy drivers.
> 
> In the case of Renesas R-Car hardware we know that there are generations of
> SoCs, e.g. Gen 2 and Gen 3. But beyond that its not clear what the
> relationship between IP blocks might be. For example, I believe that
> r8a7790 is older than r8a7791 but that doesn't imply that the latter is a
> descendant of the former or vice versa.
> 
> We can, however, by examining the documentation and behaviour of the
> hardware at run-time observe that the current driver implementation appears
> to be compatible with the IP blocks on SoCs within a given generation.
> 
> For the above reasons and convenience when enabling new SoCs a
> per-generation fallback compatibility string scheme being adopted for
> drivers for Renesas SoCs.

Hi Kishon,

I am wondering if you could consider applying this series.

Thanks!

> 
> Changes in v3:
> * Added Acks
> * Corrected whitespace in examples
> 
> Changes in v2:
> * Update new compatibility strings to match the preferred scheme for
>   ordering elements
> * Rebase
> 
> Simon Horman (2):
>   phy: rcar-gen2: add fallback binding
>   phy: rcar-gen3-usb2: add fallback binding
> 
>  Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt      |  8 +++++++-
>  Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt | 10 ++++++++--
>  drivers/phy/phy-rcar-gen2.c                                  |  1 +
>  drivers/phy/phy-rcar-gen3-usb2.c                             |  1 +
>  4 files changed, 17 insertions(+), 3 deletions(-)
> 
> -- 
> 2.1.4
> 

Re: [PATCH v3 0/2] phy: rcar-gen2, rcar-gen3-usb2: add fallback binding

[Kishon Vijay Abraham I]

Hi,

On Friday 25 March 2016 07:39 AM, Simon Horman wrote:
> On Mon, Mar 07, 2016 at 10:58:39AM +0900, Simon Horman wrote:
>> Add fallback compatibility strings for rcar phy drivers.
>>
>> In the case of Renesas R-Car hardware we know that there are generations of
>> SoCs, e.g. Gen 2 and Gen 3. But beyond that its not clear what the
>> relationship between IP blocks might be. For example, I believe that
>> r8a7790 is older than r8a7791 but that doesn't imply that the latter is a
>> descendant of the former or vice versa.
>>
>> We can, however, by examining the documentation and behaviour of the
>> hardware at run-time observe that the current driver implementation appears
>> to be compatible with the IP blocks on SoCs within a given generation.
>>
>> For the above reasons and convenience when enabling new SoCs a
>> per-generation fallback compatibility string scheme being adopted for
>> drivers for Renesas SoCs.
> 
> Hi Kishon,
> 
> I am wondering if you could consider applying this series.

This doesn't appear to be a fix. So will be queuing this for the next merge window.

Thanks
Kishon

> 
> Thanks!
> 
>>
>> Changes in v3:
>> * Added Acks
>> * Corrected whitespace in examples
>>
>> Changes in v2:
>> * Update new compatibility strings to match the preferred scheme for
>>   ordering elements
>> * Rebase
>>
>> Simon Horman (2):
>>   phy: rcar-gen2: add fallback binding
>>   phy: rcar-gen3-usb2: add fallback binding
>>
>>  Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt      |  8 +++++++-
>>  Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt | 10 ++++++++--
>>  drivers/phy/phy-rcar-gen2.c                                  |  1 +
>>  drivers/phy/phy-rcar-gen3-usb2.c                             |  1 +
>>  4 files changed, 17 insertions(+), 3 deletions(-)
>>
>> -- 
>> 2.1.4
>>

Re: [PATCH v3 0/2] phy: rcar-gen2, rcar-gen3-usb2: add fallback binding

[Kishon Vijay Abraham I]

On Thursday 07 April 2016 03:17 PM, Kishon Vijay Abraham I wrote:
> Hi,
> 
> On Friday 25 March 2016 07:39 AM, Simon Horman wrote:
>> On Mon, Mar 07, 2016 at 10:58:39AM +0900, Simon Horman wrote:
>>> Add fallback compatibility strings for rcar phy drivers.
>>>
>>> In the case of Renesas R-Car hardware we know that there are generations of
>>> SoCs, e.g. Gen 2 and Gen 3. But beyond that its not clear what the
>>> relationship between IP blocks might be. For example, I believe that
>>> r8a7790 is older than r8a7791 but that doesn't imply that the latter is a
>>> descendant of the former or vice versa.
>>>
>>> We can, however, by examining the documentation and behaviour of the
>>> hardware at run-time observe that the current driver implementation appears
>>> to be compatible with the IP blocks on SoCs within a given generation.
>>>
>>> For the above reasons and convenience when enabling new SoCs a
>>> per-generation fallback compatibility string scheme being adopted for
>>> drivers for Renesas SoCs.
>>
>> Hi Kishon,
>>
>> I am wondering if you could consider applying this series.
> 
> This doesn't appear to be a fix. So will be queuing this for the next merge window.

merged, thanks.

-Kishon

> 
> Thanks
> Kishon
> 
>>
>> Thanks!
>>
>>>
>>> Changes in v3:
>>> * Added Acks
>>> * Corrected whitespace in examples
>>>
>>> Changes in v2:
>>> * Update new compatibility strings to match the preferred scheme for
>>>   ordering elements
>>> * Rebase
>>>
>>> Simon Horman (2):
>>>   phy: rcar-gen2: add fallback binding
>>>   phy: rcar-gen3-usb2: add fallback binding
>>>
>>>  Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt      |  8 +++++++-
>>>  Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt | 10 ++++++++--
>>>  drivers/phy/phy-rcar-gen2.c                                  |  1 +
>>>  drivers/phy/phy-rcar-gen3-usb2.c                             |  1 +
>>>  4 files changed, 17 insertions(+), 3 deletions(-)
>>>
>>> -- 
>>> 2.1.4
>>>