From: William Wu <william.wu@rock-chips.com>
To: Felipe Balbi <balbi@kernel.org>, Brian Norris <briannorris@chromium.org>
Cc: gregkh@linuxfoundation.org, heiko@sntech.de, dianders@google.com,
kever.yang@rock-chips.com, huangtao@rock-chips.com,
frank.wang@rock-chips.com, eddie.cai@rock-chips.com,
John.Youn@synopsys.com, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH 1/4] usb: dwc3: of-simple: add compatible for rockchip
Date: Tue, 10 May 2016 16:14:30 +0800 [thread overview]
Message-ID: <57319866.9010404@rock-chips.com> (raw)
In-Reply-To: <87ziry759d.fsf@linux.intel.com>
Dear Felipe and Brian,
On 05/10/2016 03:15 PM, Felipe Balbi wrote:
> Hi,
>
> Brian Norris <briannorris@chromium.org> writes:
>> Hi William,
>>
>> Did you leave off linux-rockchip@lists.infradead.org intentionally? IMO,
>> it's nice to have that list in CC, so interested parties can follow your
>> work, even if they aren't as fortunate as me to have been CC'd on your
>> patch directly.
Actually, I don't know the linux-rockchip@lists.infradead.org before.
I'll add the list in CC next patch version.
Thanks~
>>
>> On Mon, May 09, 2016 at 07:46:14PM +0800, William Wu wrote:
>>> Signed-off-by: William Wu <william.wu@rock-chips.com>
>>> ---
>>> drivers/usb/dwc3/dwc3-of-simple.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c
>>> index 9743353..1f3665b 100644
>>> --- a/drivers/usb/dwc3/dwc3-of-simple.c
>>> +++ b/drivers/usb/dwc3/dwc3-of-simple.c
>>> @@ -162,6 +162,7 @@ static const struct dev_pm_ops dwc3_of_simple_dev_pm_ops = {
>>> static const struct of_device_id of_dwc3_simple_match[] = {
>>> { .compatible = "qcom,dwc3" },
>>> { .compatible = "xlnx,zynqmp-dwc3" },
>>> + { .compatible = "rockchip,dwc3" },
>> Add to Documentation/devicetree/bindings/. Do we need a new
>> Documentation/devicetree/bindings/usb/rockchip,dwc3.txt, to match the
>> pattern of qcom and xlnx? Or can we just add to dwc3.txt, since so far,
>> all bindings are documented in the common file?
> dwc3.txt is for dwc3.ko. We need separate files for rockchip, xilinx and
> qualcomn :-)
I have already prepared a new
Documentation/devicetree/bindings/usb/rockchip,dwc3.txt,
But considering that rockchip,dwc3.txt should contains phys node
description which are
not ready yet, so I don't add the dt-bindings patch here.
Is it better to add the dt-bindings patch(rockchip,dwc3.txt) without
phys node description here?
If it is, I'll add rockchip,dwc3.txt next patch verison.
And I have some doubts about the name format of the usb dwc3 documents.
I notice that there are at least two types of name format:
1. dwc3-xx.txt (e.g. dwc3-st.txt )
2. xx, dwc3.txt (e.g. qcom,dwc3.txt)
Which one do you prefer?
>
next prev parent reply other threads:[~2016-05-10 8:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-09 11:46 [PATCH 0/4] support rockchip dwc3 driver William Wu
2016-05-09 11:46 ` [PATCH 1/4] usb: dwc3: of-simple: add compatible for rockchip William Wu
2016-05-09 15:16 ` Doug Anderson
2016-05-10 7:14 ` Felipe Balbi
2016-05-10 7:39 ` William Wu
2016-05-10 8:11 ` Felipe Balbi
2016-05-10 8:27 ` William Wu
2016-05-09 19:24 ` Brian Norris
2016-05-10 7:15 ` Felipe Balbi
2016-05-10 8:14 ` William Wu [this message]
2016-05-09 11:46 ` [PATCH 2/4] usb: dwc3: add dis_u2_freeclk_exists_quirk William Wu
2016-05-09 11:46 ` [PATCH 3/4] usb: dwc3: make usb2 phy interface configurable in DT William Wu
2016-05-09 12:18 ` Felipe Balbi
2016-05-09 13:28 ` William Wu
2016-05-09 13:32 ` Felipe Balbi
2016-05-09 11:46 ` [PATCH 4/4] usb: dwc3: add dis_del_phy_power_chg_quirk William Wu
2016-05-13 9:24 ` [PATCH v2 0/5] support rockchip dwc3 driver William Wu
2016-05-13 9:24 ` [PATCH v2 1/5] usb: dwc3: of-simple: add compatible for rockchip William Wu
2016-05-13 9:24 ` [PATCH v2 2/5] usb: dwc3: add dis_u2_freeclk_exists_quirk William Wu
2016-05-13 9:24 ` [PATCH v2 3/5] usb: dwc3: add phyif_utmi_quirk William Wu
2016-05-13 9:25 ` [PATCH v2 4/5] usb: dwc3: add dis_del_phy_power_chg_quirk William Wu
2016-05-13 9:30 ` [PATCH v2 0/5] support rockchip dwc3 driver Heiko Stuebner
2016-05-13 9:37 ` Felipe Balbi
2016-05-13 9:48 ` William Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57319866.9010404@rock-chips.com \
--to=william.wu@rock-chips.com \
--cc=John.Youn@synopsys.com \
--cc=balbi@kernel.org \
--cc=briannorris@chromium.org \
--cc=dianders@google.com \
--cc=eddie.cai@rock-chips.com \
--cc=frank.wang@rock-chips.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=kever.yang@rock-chips.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).