linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* 4.1.24-stable: iwlwifi patch applied to wrong file
@ 2016-05-11 17:54 Jens Rottmann
  2016-05-11 18:11 ` Sasha Levin
  0 siblings, 1 reply; 2+ messages in thread
From: Jens Rottmann @ 2016-05-11 17:54 UTC (permalink / raw)
  To: Sasha Levin, stable; +Cc: Emmanuel Grumbach, linux-kernel

Hi again,

in 4.1.24-stable commit fdfdfc7cdf (iwlwifi: pcie: lower the debug level
for RSA semaphore access) was applied to the wrong file. It patched
drivers/net/wireless/intel/iwlwifi/pcie/trans.c whereas it should have
patched drivers/net/wireless/iwlwifi/pcie/trans.c instead.

drivers/net/wireless/intel/iwlwifi/pcie/trans.c is a useless artifact
created by a faulty patch, which went into 4.1.18 (d9d42b679e36 iwlwifi:
pcie: properly configure the debug buffer size for 8000) I already
reported this a while ago ("4.1.18 introduced spurious copy of renamed
iwlwifi trans.c").

For 4.1.25 please delete drivers/net/wireless/intel/iwlwifi/pcie/trans.c
and reapply the "lower the debug level" patch to the correct file.

Thanks,
Jens

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: 4.1.24-stable: iwlwifi patch applied to wrong file
  2016-05-11 17:54 4.1.24-stable: iwlwifi patch applied to wrong file Jens Rottmann
@ 2016-05-11 18:11 ` Sasha Levin
  0 siblings, 0 replies; 2+ messages in thread
From: Sasha Levin @ 2016-05-11 18:11 UTC (permalink / raw)
  To: Jens Rottmann, stable; +Cc: Emmanuel Grumbach, linux-kernel

On 05/11/2016 01:54 PM, Jens Rottmann wrote:
> Hi again,
> 
> in 4.1.24-stable commit fdfdfc7cdf (iwlwifi: pcie: lower the debug level
> for RSA semaphore access) was applied to the wrong file. It patched
> drivers/net/wireless/intel/iwlwifi/pcie/trans.c whereas it should have
> patched drivers/net/wireless/iwlwifi/pcie/trans.c instead.
> 
> drivers/net/wireless/intel/iwlwifi/pcie/trans.c is a useless artifact
> created by a faulty patch, which went into 4.1.18 (d9d42b679e36 iwlwifi:
> pcie: properly configure the debug buffer size for 8000) I already
> reported this a while ago ("4.1.18 introduced spurious copy of renamed
> iwlwifi trans.c").
> 
> For 4.1.25 please delete drivers/net/wireless/intel/iwlwifi/pcie/trans.c
> and reapply the "lower the debug level" patch to the correct file.

Oh I thought that I removed that file after the previous mail about it :/

Fixed in queue now, and I'll make sure it's right before shipping .25


Thanks,
Sasha

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-05-11 19:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-11 17:54 4.1.24-stable: iwlwifi patch applied to wrong file Jens Rottmann
2016-05-11 18:11 ` Sasha Levin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).