Re: [PATCH v7 0/3] ASoC: cygnus: Add audio support for Broadcom Cygnus SoC

Re: [PATCH v7 0/3] ASoC: cygnus: Add audio support for Broadcom Cygnus SoC

[Florian Fainelli]

On 05/17/2016 12:46 PM, Simran Rai wrote:
> From: Simran <ssimran@lbrmn-ssimran-lnxub64.ric.broadcom.com>

Please fix your git email address and resubmit.
-- 
Florian

Re: [PATCH v7 0/3] ASoC: cygnus: Add audio support for Broadcom Cygnus SoC

[Scott Branden]

Looks good Simran.

Mark, anything else for us to do before this driver can be accepted 
upstream?

On 16-05-17 12:46 PM, Simran Rai wrote:
> From: Simran <ssimran@lbrmn-ssimran-lnxub64.ric.broadcom.com>
>
> Hi,
>
> This patchset contains audio support for Broadcom's Cygnus SoC.
> It contains DT bindings and core audio driver. The audio driver supports
> both capture and playback of Audio PCM samples over I2S/TDM interface and
> provides playback support over SPDIF interface.
>
> This patchset is derived from a previously submitted patchset:
> http://lkml.iu.edu/hypermail/linux/kernel/1503.3/05434.html
>
> This patchset has been tested on Cygnus wireless audio bcm958305K board.
> It is based on v4.6-rc1 and is available from github:
>
> repo: https://github.com/Broadcom/cygnus-linux/tree/cygnus-sound-v7
>
> Changes from v6:
> - DT bindings acknowledged by Rob Herring
> Changes from v5:
> - Fix code style, e.g. change "if" statements to "switch" statements
> - Fix SPDIF output enable register field
> - Set BUFFER_PAIR_ENABLE for both mono, stereo and TDM modes
> - Reflect PCM bit formats for SPDIF, SSP and TDM as supported by
> hardware
> Changes from v4:
> - Fix power suspend function and add power resume function
> - Move clock initialization code from audio driver to clock framework
> Changes from v3:
> - Fix the subject lines to match the style for the subsystem
> Changes from v2:
> - Split patchset 2/2 from v2 into patchsets 2/3 and 3/3.
> - Remove SND_SOC_CYGNUS_DIAG. Diagnostics can be performed using
> standard kernel trace infrastructure.
> - Fix interrupt handler. Acknowledge only those interrupts that are
> handledby ISR.
> - Modify configure_vco() and the pll_macro_entry() struct to make it
> better readable. The functionality did not change.
> - Remove casts on macros
> - Remove surround sound channel grouping from the driver.
> Changes from v1:
> - Address code review comments. Fix print format of type size_t and
> pointer.
>
> Simran Rai (3):
>    ASoC: cygnus: Add DT bindings for Broadcom Cygnus audio
>    ASoC: cygnus: Add Cygnus audio DAI driver
>    ASoC: cygnus: Add Cygnus audio DMA driver
>
>   .../bindings/sound/brcm,cygnus-audio.txt           |   67 +
>   sound/soc/bcm/Kconfig                              |    9 +
>   sound/soc/bcm/Makefile                             |    5 +
>   sound/soc/bcm/cygnus-pcm.c                         |  861 +++++++++++
>   sound/soc/bcm/cygnus-ssp.c                         | 1529 ++++++++++++++++++++
>   sound/soc/bcm/cygnus-ssp.h                         |  139 ++
>   6 files changed, 2610 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/sound/brcm,cygnus-audio.txt
>   create mode 100644 sound/soc/bcm/cygnus-pcm.c
>   create mode 100644 sound/soc/bcm/cygnus-ssp.c
>   create mode 100644 sound/soc/bcm/cygnus-ssp.h
>

Re: [PATCH v7 0/3] ASoC: cygnus: Add audio support for Broadcom Cygnus SoC

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 1042 bytes --]

On Thu, May 19, 2016 at 01:35:46PM -0700, Scott Branden wrote:
> Looks good Simran.
> 
> Mark, anything else for us to do before this driver can be accepted
> upstream?

It's a new driver submitted in the first week of the merge window, I've
not looked at it yet.

Please don't top post, reply in line with needed context.  This allows
readers to readily follow the flow of conversation and understand what
you are talking about and also helps ensure that everything in the
discussion is being addressed.

Please don't send content free pings and please allow a reasonable time
for review.  People get busy, go on holiday, attend conferences and so 
on so unless there is some reason for urgency (like critical bug fixes)
please allow at least a couple of weeks for review.  If there have been
review comments then people may be waiting for those to be addressed.
Sending content free pings just adds to the mail volume (if they are
seen at all) and if something has gone wrong you'll have to resend the
patches anyway.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[PATCH v7 0/3] ASoC: cygnus: Add audio support for Broadcom Cygnus SoC

[Simran Rai]

Hi,

This patchset contains audio support for Broadcom's Cygnus SoC.
It contains DT bindings and core audio driver. The audio driver supports
both capture and playback of Audio PCM samples over I2S/TDM interface and
provides playback support over SPDIF interface.

This patchset is derived from a previously submitted patchset:
http://lkml.iu.edu/hypermail/linux/kernel/1503.3/05434.html

This patchset has been tested on Cygnus wireless audio bcm958305K board.
It is based on v4.6-rc1 and is available from github:

repo: https://github.com/Broadcom/cygnus-linux/tree/cygnus-sound-v7

Changes from v6:
- DT bindings acknowledged by Rob Herring
Changes from v5:
- Fix code style, e.g. change "if" statements to "switch" statements
- Fix SPDIF output enable register field
- Set BUFFER_PAIR_ENABLE for both mono, stereo and TDM modes
- Reflect PCM bit formats for SPDIF, SSP and TDM as supported by
hardware
Changes from v4:
- Fix power suspend function and add power resume function
- Move clock initialization code from audio driver to clock framework
Changes from v3:
- Fix the subject lines to match the style for the subsystem
Changes from v2:
- Split patchset 2/2 from v2 into patchsets 2/3 and 3/3.
- Remove SND_SOC_CYGNUS_DIAG. Diagnostics can be performed using
standard kernel trace infrastructure.
- Fix interrupt handler. Acknowledge only those interrupts that are
handledby ISR.
- Modify configure_vco() and the pll_macro_entry() struct to make it
better readable. The functionality did not change.
- Remove casts on macros
- Remove surround sound channel grouping from the driver.
Changes from v1:
- Address code review comments. Fix print format of type size_t and
pointer.

Simran Rai (3):
  ASoC: cygnus: Add DT bindings for Broadcom Cygnus audio
  ASoC: cygnus: Add Cygnus audio DAI driver
  ASoC: cygnus: Add Cygnus audio DMA driver

 .../bindings/sound/brcm,cygnus-audio.txt           |   67 +
 sound/soc/bcm/Kconfig                              |    9 +
 sound/soc/bcm/Makefile                             |    5 +
 sound/soc/bcm/cygnus-pcm.c                         |  861 +++++++++++
 sound/soc/bcm/cygnus-ssp.c                         | 1529 ++++++++++++++++++++
 sound/soc/bcm/cygnus-ssp.h                         |  139 ++
 6 files changed, 2610 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/brcm,cygnus-audio.txt
 create mode 100644 sound/soc/bcm/cygnus-pcm.c
 create mode 100644 sound/soc/bcm/cygnus-ssp.c
 create mode 100644 sound/soc/bcm/cygnus-ssp.h

-- 
1.9.1