Re: [PATCH] pinctrl: mediatek: fix dual-edge code defect

* Re: [PATCH] pinctrl: mediatek: fix dual-edge code defect
       [not found] <1463815419-11719-1-git-send-email-hongkun.cao@mediatek.com>
@ 2016-05-23 10:39 ` Matthias Brugger
  2016-05-31  8:13 ` Linus Walleij
  1 sibling, 0 replies; 2+ messages in thread
From: Matthias Brugger @ 2016-05-23 10:39 UTC (permalink / raw)
  To: hongkun.cao, robh+dt, pawel.moll, mark.rutland, ijc+devicetree,
	galak, linux, linus.walleij, erin.lo
  Cc: devicetree, srv_heupstream, hongzhou.yang, linux-kernel,
	linux-gpio, inux-mediatek, yingjoe.chen, linux-arm-kernel

On 21/05/16 09:23, hongkun.cao@mediatek.com wrote:
> From: "hongkun.cao" <hongkun.cao@mediatek.com>
>
> When a dual-edge irq is triggered, an incorrect irq will be reported on
> condition that the external signal is not stable and this incorrect irq
> has been registered.
> Correct the register offset.
>

I'm not sure what you want to say. From what I can see the without this 
fix, the the wrong IRQ will be cleared and raised. Is this what you are 
addressing?

If so:
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>

> Signed-off-by: hongkun.cao <hongkun.cao@mediatek.com>
> ---
>   drivers/pinctrl/mediatek/pinctrl-mtk-common.c |    5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
> index 2bbe6f7..92ae49f 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
> @@ -1255,9 +1255,10 @@ static void mtk_eint_irq_handler(struct irq_desc *desc)
>   	const struct mtk_desc_pin *pin;
>
>   	chained_irq_enter(chip, desc);
> -	for (eint_num = 0; eint_num < pctl->devdata->ap_num; eint_num += 32) {
> +	for (eint_num = 0;
> +	     eint_num < pctl->devdata->ap_num;
> +	     eint_num += 32, reg += 4) {
>   		status = readl(reg);
> -		reg += 4;
>   		while (status) {
>   			offset = __ffs(status);
>   			index = eint_num + offset;
>

^ permalink raw reply	[flat|nested] 2+ messages in thread