* [PATCH v2 1/2] mmc: dw_mmc: remove redundant of set_bit and clear_bit @ 2016-05-27 6:36 ` Shawn Lin 2016-05-29 23:18 ` Jaehoon Chung 0 siblings, 1 reply; 2+ messages in thread From: Shawn Lin @ 2016-05-27 6:36 UTC (permalink / raw) To: Jaehoon Chung, Ulf Hansson Cc: linux-mmc, linux-kernel, Doug Anderson, linux-rockchip, Shawn Lin dw_mci_get_cd have already dealt with these for both of internal card-detect and gpio card-detect. Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> --- Changes in v2: None drivers/mmc/host/dw_mmc.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c index 829a6ee..cb30e91 100644 --- a/drivers/mmc/host/dw_mmc.c +++ b/drivers/mmc/host/dw_mmc.c @@ -2616,10 +2616,7 @@ static int dw_mci_init_slot(struct dw_mci *host, unsigned int id) mmc->max_seg_size = mmc->max_req_size; } - if (dw_mci_get_cd(mmc)) - set_bit(DW_MMC_CARD_PRESENT, &slot->flags); - else - clear_bit(DW_MMC_CARD_PRESENT, &slot->flags); + dw_mci_get_cd(mmc); ret = mmc_add_host(mmc); if (ret) -- 2.3.7 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 1/2] mmc: dw_mmc: remove redundant of set_bit and clear_bit 2016-05-27 6:36 ` [PATCH v2 1/2] mmc: dw_mmc: remove redundant of set_bit and clear_bit Shawn Lin @ 2016-05-29 23:18 ` Jaehoon Chung 0 siblings, 0 replies; 2+ messages in thread From: Jaehoon Chung @ 2016-05-29 23:18 UTC (permalink / raw) To: Shawn Lin, Ulf Hansson Cc: linux-mmc, linux-kernel, Doug Anderson, linux-rockchip Hi Shawn, Applied on my repository. Thanks! Best Regards, Jaehoon Chung On 05/27/2016 03:36 PM, Shawn Lin wrote: > dw_mci_get_cd have already dealt with these for > both of internal card-detect and gpio card-detect. > > Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> > > --- > > Changes in v2: None > > drivers/mmc/host/dw_mmc.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > index 829a6ee..cb30e91 100644 > --- a/drivers/mmc/host/dw_mmc.c > +++ b/drivers/mmc/host/dw_mmc.c > @@ -2616,10 +2616,7 @@ static int dw_mci_init_slot(struct dw_mci *host, unsigned int id) > mmc->max_seg_size = mmc->max_req_size; > } > > - if (dw_mci_get_cd(mmc)) > - set_bit(DW_MMC_CARD_PRESENT, &slot->flags); > - else > - clear_bit(DW_MMC_CARD_PRESENT, &slot->flags); > + dw_mci_get_cd(mmc); > > ret = mmc_add_host(mmc); > if (ret) > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-05-29 23:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20160527063715epcas1p1584a3a6340d55ca1d912dc93f2d89bab@epcas1p1.samsung.com>
2016-05-27 6:36 ` [PATCH v2 1/2] mmc: dw_mmc: remove redundant of set_bit and clear_bit Shawn Lin
2016-05-29 23:18 ` Jaehoon Chung
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).