From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Joe Perches <joe@perches.com>
Cc: "Jan H. Schönherr" <schnhrr@cs.tu-berlin.de>,
"Daniel J Blueman" <daniel@numascale-asia.com>,
"Len Brown" <lenb@kernel.org>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] acpi: Fix logging when no pci_irq is allocated
Date: Wed, 21 Nov 2012 22:25:12 +0100 [thread overview]
Message-ID: <5752160.0Aavql38JJ@vostro.rjw.lan> (raw)
In-Reply-To: <1353531235.24807.39.camel@joe-AO722>
On Wednesday, November 21, 2012 12:53:55 PM Joe Perches wrote:
> On Wed, 2012-11-21 at 21:50 +0100, Rafael J. Wysocki wrote:
> > On Wednesday, November 21, 2012 05:46:04 AM Joe Perches wrote:
> > > On Wed, 2012-11-21 at 16:43 +0800, Daniel J Blueman wrote:
> > > > Previously a new line is implicitly added in the no GSI case:
> > > >
> > > > [ 7.185182] pci 0001:00:12.0: can't derive routing for PCI INT A
> > > > [ 7.191352] pci 0001:00:12.0: PCI INT A: no GSI
> > > > [ 7.195956] - using ISA IRQ 10
> > > >
> > > > The code thus prints a blank line where no legacy IRQ is available:
> > > >
> > > > [ 1.650124] pci 0000:00:14.0: can't derive routing for PCI INT A
> > > > [ 1.650126] pci 0000:00:14.0: PCI INT A: no GSI
> > > > [ 1.650126]
> > > > [ 1.650180] pci 0000:00:14.0: can't derive routing for PCI INT A
> > > >
> > > > Fix this by making the newline explicit and removing the superfluous
> > > > one.
> > >
> > > This breaks the logging code below it when there is an ISA irq.
> > >
> > > The below works, but is a workaround for a defect in the printk
> > > subsystem introduced by a logging change that will be fixed in
> > > a near future release.
> >
> > What exactly do you mean by "near future"?
>
> I mean Jan Schönherr's patches that should fix this are
> likely to be picked up one day.
>
> https://lkml.org/lkml/2012/11/13/678
Till then, we need the patch you sent, right? And it won't hurt to apply it
anyway?
Rafael
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
next prev parent reply other threads:[~2012-11-21 21:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 8:43 [PATCH RESEND] Fix printing when no interrupt is allocated Daniel J Blueman
2012-11-21 13:46 ` [PATCH RESEND] acpi: Fix logging when no pci_irq " Joe Perches
2012-11-21 20:50 ` Rafael J. Wysocki
2012-11-21 20:53 ` Joe Perches
2012-11-21 21:25 ` Rafael J. Wysocki [this message]
2012-11-21 21:24 ` Joe Perches
2012-11-22 0:14 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5752160.0Aavql38JJ@vostro.rjw.lan \
--to=rjw@sisk.pl \
--cc=daniel@numascale-asia.com \
--cc=joe@perches.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=schnhrr@cs.tu-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).