From: Keerthy <a0393675@ti.com>
To: Caesar Wang <wxt@rock-chips.com>, <edubezval@gmail.com>,
<linux-pm@vger.kernel.org>
Cc: Heiko Stuebner <heiko@sntech.de>, <dianders@chromium.org>,
<briannorris@google.com>, <smbarber@google.com>,
<linux-rockchip@lists.infradead.org>, <cf@rock-chips.com>,
<huangtao@rock-chips.com>, <dmitry.torokhov@gmail.com>,
<javi.merino@arm.com>, <peter@piie.net>,
Sascha Hauer <s.hauer@pengutronix.de>,
Zhang Rui <rui.zhang@intel.com>, Keerthy <j-keerthy@ti.com>,
<linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>
Subject: Re: [PATCH v5 3/5] thermal: streamline get_trend callbacks
Date: Tue, 7 Jun 2016 11:44:46 +0530 [thread overview]
Message-ID: <57566656.4010002@ti.com> (raw)
In-Reply-To: <1465213489-14898-4-git-send-email-wxt@rock-chips.com>
On Monday 06 June 2016 05:14 PM, Caesar Wang wrote:
> From: Sascha Hauer <s.hauer@pengutronix.de>
>
> The .get_trend callback in struct thermal_zone_device_ops has
> the prototype:
> int (*get_trend) (struct thermal_zone_device *, int,
> enum thermal_trend *);
> whereas the .get_trend callback in struct thermal_zone_of_device_ops
> has:
> int (*get_trend)(void *, long *);
>
> Streamline both prototypes and add the trip argument to the OF callback
> aswell and use enum thermal_trend * instead of an integer pointer.
>
> While the OF prototype may be the better one, this should be decided at
> framework level and not on OF level.
Tested this patch on omap5-uevm using emulation feature and saw that
cooling state was getting updated correctly w.r.t trip point tempereatures.
A minor comment below apart from that.
Reviewed-by: Keerthy <j-keerthy@ti.com>
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
> Cc: Zhang Rui <rui.zhang@intel.com>
> Cc: Eduardo Valentin <edubezval@gmail.com>
> Cc: linux-pm@vger.kernel.org
> ---
>
> Changes in v5: None
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
>
> drivers/thermal/of-thermal.c | 11 +---------
> drivers/thermal/ti-soc-thermal/ti-thermal-common.c | 25 +++++++---------------
> include/linux/thermal.h | 2 +-
> 3 files changed, 10 insertions(+), 28 deletions(-)
>
> diff --git a/drivers/thermal/of-thermal.c b/drivers/thermal/of-thermal.c
> index 2d2a06f..ba72c35 100644
> --- a/drivers/thermal/of-thermal.c
> +++ b/drivers/thermal/of-thermal.c
> @@ -202,24 +202,15 @@ static int of_thermal_get_trend(struct thermal_zone_device *tz, int trip,
> enum thermal_trend *trend)
> {
> struct __thermal_zone *data = tz->devdata;
> - long dev_trend;
> int r;
int r = 0;
>
> if (!data->ops->get_trend)
> return -EINVAL;
>
> - r = data->ops->get_trend(data->sensor_data, &dev_trend);
> + r = data->ops->get_trend(data->sensor_data, trip, trend);
> if (r)
> return r;
no need of this if check just
return r;
>
> - /* TODO: These intervals might have some thresholds, but in core code */
> - if (dev_trend > 0)
> - *trend = THERMAL_TREND_RAISING;
> - else if (dev_trend < 0)
> - *trend = THERMAL_TREND_DROPPING;
> - else
> - *trend = THERMAL_TREND_STABLE;
> -
> return 0;
> }
>
> diff --git a/drivers/thermal/ti-soc-thermal/ti-thermal-common.c b/drivers/thermal/ti-soc-thermal/ti-thermal-common.c
> index 15c0a9a..4a6757c 100644
> --- a/drivers/thermal/ti-soc-thermal/ti-thermal-common.c
> +++ b/drivers/thermal/ti-soc-thermal/ti-thermal-common.c
> @@ -239,7 +239,7 @@ static int ti_thermal_get_trip_temp(struct thermal_zone_device *thermal,
> return 0;
> }
>
> -static int __ti_thermal_get_trend(void *p, long *trend)
> +static int __ti_thermal_get_trend(void *p, int trip, enum thermal_trend *trend)
> {
> struct ti_thermal_data *data = p;
> struct ti_bandgap *bgp;
> @@ -252,22 +252,6 @@ static int __ti_thermal_get_trend(void *p, long *trend)
> if (ret)
> return ret;
>
> - *trend = tr;
> -
> - return 0;
> -}
> -
> -/* Get the temperature trend callback functions for thermal zone */
> -static int ti_thermal_get_trend(struct thermal_zone_device *thermal,
> - int trip, enum thermal_trend *trend)
> -{
> - int ret;
> - long tr;
> -
> - ret = __ti_thermal_get_trend(thermal->devdata, &tr);
> - if (ret)
> - return ret;
> -
> if (tr > 0)
> *trend = THERMAL_TREND_RAISING;
> else if (tr < 0)
> @@ -278,6 +262,13 @@ static int ti_thermal_get_trend(struct thermal_zone_device *thermal,
> return 0;
> }
>
> +/* Get the temperature trend callback functions for thermal zone */
> +static int ti_thermal_get_trend(struct thermal_zone_device *thermal,
> + int trip, enum thermal_trend *trend)
> +{
> + return __ti_thermal_get_trend(thermal->devdata, trip, trend);
> +}
> +
> /* Get critical temperature callback functions for thermal zone */
> static int ti_thermal_get_crit_temp(struct thermal_zone_device *thermal,
> int *temp)
> diff --git a/include/linux/thermal.h b/include/linux/thermal.h
> index 2440b8d..d3ce3a5 100644
> --- a/include/linux/thermal.h
> +++ b/include/linux/thermal.h
> @@ -352,7 +352,7 @@ struct thermal_genl_event {
> */
> struct thermal_zone_of_device_ops {
> int (*get_temp)(void *, int *);
> - int (*get_trend)(void *, long *);
> + int (*get_trend)(void *, int, enum thermal_trend *);
> int (*set_trips)(void *, int, int);
> int (*set_emul_temp)(void *, int);
> int (*set_trip_temp)(void *, int, int);
>
next prev parent reply other threads:[~2016-06-07 6:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 11:44 [PATCH v5 0/5] Thermal: Support for hardware-tracked trip points Caesar Wang
2016-06-06 11:44 ` [PATCH v5 1/5] thermal: Add support " Caesar Wang
2016-06-06 12:47 ` Javi Merino
2016-06-22 3:15 ` Zhang Rui
2016-07-02 1:39 ` Eduardo Valentin
2016-06-06 11:44 ` [PATCH v5 2/5] thermal: of: implement .set_trips for device tree thermal zones Caesar Wang
2016-06-06 11:44 ` [PATCH v5 3/5] thermal: streamline get_trend callbacks Caesar Wang
2016-06-07 6:14 ` Keerthy [this message]
2016-06-07 12:44 ` Caesar Wang
2016-06-06 11:44 ` [PATCH v5 4/5] thermal: bang-bang governor: act on lower trip boundary Caesar Wang
2016-06-06 11:44 ` [PATCH v5 5/5] thermal: rockchip: add the set_trips function Caesar Wang
[not found] ` <57689B82.3000902@gmail.com>
2016-06-22 3:25 ` [PATCH v5 0/5] Thermal: Support for hardware-tracked trip points Zhang Rui
2016-06-22 11:19 ` Caesar Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57566656.4010002@ti.com \
--to=a0393675@ti.com \
--cc=briannorris@google.com \
--cc=cf@rock-chips.com \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=edubezval@gmail.com \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=j-keerthy@ti.com \
--cc=javi.merino@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=peter@piie.net \
--cc=rui.zhang@intel.com \
--cc=s.hauer@pengutronix.de \
--cc=smbarber@google.com \
--cc=wxt@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).