From: Javi Merino <javi.merino@arm.com>
To: Caesar Wang <wxt@rock-chips.com>
Cc: edubezval@gmail.com, linux-pm@vger.kernel.org,
Heiko Stuebner <heiko@sntech.de>,
dianders@chromium.org, briannorris@google.com,
smbarber@google.com, linux-rockchip@lists.infradead.org,
cf@rock-chips.com, huangtao@rock-chips.com,
dmitry.torokhov@gmail.com, peter@piie.net,
Sascha Hauer <s.hauer@pengutronix.de>,
Zhang Rui <rui.zhang@intel.com>, Jonathan Corbet <corbet@lwn.net>,
Andy Champ <andycham@amazon.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
Durgadoss R <durgadoss.r@intel.com>, Ni Wade <wni@nvidia.com>,
Leo Yan <leo.yan@linaro.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/5] thermal: Add support for hardware-tracked trip points
Date: Mon, 6 Jun 2016 13:47:00 +0100 [thread overview]
Message-ID: <20160606124700.GB2897@e104805> (raw)
In-Reply-To: <1465213489-14898-2-git-send-email-wxt@rock-chips.com>
On Mon, Jun 06, 2016 at 07:44:45PM +0800, Caesar Wang wrote:
> From: Sascha Hauer <s.hauer@pengutronix.de>
>
> This adds support for hardware-tracked trip points to the device tree
> thermal sensor framework.
>
> The framework supports an arbitrary number of trip points. Whenever
> the current temperature is updated, the trip points immediately
> below and above the current temperature are found. A .set_trips
> callback is then called with the temperatures. If there is no trip
> point above or below the current temperature, the passed trip
> temperature will be -INT_MAX or INT_MAX respectively. In this callback,
> the driver should program the hardware such that it is notified
> when either of these trip points are triggered. When a trip point
> is triggered, the driver should call `thermal_zone_device_update'
> for the respective thermal zone. This will cause the trip points
> to be updated again.
>
> If .set_trips is not implemented, the framework behaves as before.
>
> This patch is based on an earlier version from Mikko Perttunen
> <mikko.perttunen@kapsi.fi>
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
> Cc: Zhang Rui <rui.zhang@intel.com>
> Cc: Eduardo Valentin <edubezval@gmail.com>
> Cc: linux-pm@vger.kernel.org
>
> ---
>
> Changes in v5:
> - add the lock for thermal_zone_set_trips function.
Looks good to me!
Reviewed-by: Javi Merino <javi.merino@arm.com>
> - change based on next kernel.
>
> Changes in v4:
> - Missing the lock added in v3.
>
> Changes in v3:
> - as Javi comments on https://patchwork.kernel.org/patch/9001281/.
> - add the lock for preventing the called from multi placce
> - add the note for pre_low/high_trip.
>
> Changes in v2:
> - update the sysfs-api.txt for set_trips.
>
> Documentation/thermal/sysfs-api.txt | 7 +++++
> drivers/thermal/thermal_core.c | 54 +++++++++++++++++++++++++++++++++++++
> drivers/thermal/thermal_sysfs.c | 3 +++
> include/linux/thermal.h | 10 +++++++
> 4 files changed, 74 insertions(+)
>
next prev parent reply other threads:[~2016-06-06 12:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 11:44 [PATCH v5 0/5] Thermal: Support for hardware-tracked trip points Caesar Wang
2016-06-06 11:44 ` [PATCH v5 1/5] thermal: Add support " Caesar Wang
2016-06-06 12:47 ` Javi Merino [this message]
2016-06-22 3:15 ` Zhang Rui
2016-07-02 1:39 ` Eduardo Valentin
2016-06-06 11:44 ` [PATCH v5 2/5] thermal: of: implement .set_trips for device tree thermal zones Caesar Wang
2016-06-06 11:44 ` [PATCH v5 3/5] thermal: streamline get_trend callbacks Caesar Wang
2016-06-07 6:14 ` Keerthy
2016-06-07 12:44 ` Caesar Wang
2016-06-06 11:44 ` [PATCH v5 4/5] thermal: bang-bang governor: act on lower trip boundary Caesar Wang
2016-06-06 11:44 ` [PATCH v5 5/5] thermal: rockchip: add the set_trips function Caesar Wang
[not found] ` <57689B82.3000902@gmail.com>
2016-06-22 3:25 ` [PATCH v5 0/5] Thermal: Support for hardware-tracked trip points Zhang Rui
2016-06-22 11:19 ` Caesar Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160606124700.GB2897@e104805 \
--to=javi.merino@arm.com \
--cc=andycham@amazon.com \
--cc=briannorris@google.com \
--cc=cf@rock-chips.com \
--cc=corbet@lwn.net \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=durgadoss.r@intel.com \
--cc=edubezval@gmail.com \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=ldewangan@nvidia.com \
--cc=leo.yan@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=peter@piie.net \
--cc=rui.zhang@intel.com \
--cc=s.hauer@pengutronix.de \
--cc=smbarber@google.com \
--cc=wni@nvidia.com \
--cc=wxt@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).