From: Jon Hunter <jonathanh@nvidia.com>
To: Kevin Hilman <khilman@baylibre.com>
Cc: Grygorii Strashko <grygorii.strashko@ti.com>,
Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
Marc Zyngier <marc.zyngier@arm.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
"Stephen Warren" <swarren@wwwdotorg.org>,
Thierry Reding <thierry.reding@gmail.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Linus Walleij <linus.walleij@linaro.org>,
<linux-tegra@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V5 4/9] genirq: Add runtime power management support for IRQ chips
Date: Fri, 10 Jun 2016 09:05:41 +0100 [thread overview]
Message-ID: <575A74D5.4050905@nvidia.com> (raw)
In-Reply-To: <7htwh2c6o9.fsf@baylibre.com>
On 09/06/16 23:56, Kevin Hilman wrote:
> Jon Hunter <jonathanh@nvidia.com> writes:
>
>> On 06/06/16 15:36, Grygorii Strashko wrote:
>>> On 06/06/2016 05:30 PM, Jon Hunter wrote:
>>>>
>>>> On 06/06/16 15:13, Grygorii Strashko wrote:
>>>>> On 06/06/2016 02:53 PM, Jon Hunter wrote:
>>>>>> Some IRQ chips may be located in a power domain outside of the CPU
>>>>>> subsystem and hence will require device specific runtime power
>>>>>> management. In order to support such IRQ chips, add a pointer for a
>>>>>> device structure to the irq_chip structure, and if this pointer is
>>>>>> populated by the IRQ chip driver and CONFIG_PM is selected in the kernel
>>>>>> configuration, then the pm_runtime_get/put APIs for this chip will be
>>>>>> called when an IRQ is requested/freed, respectively.
>>>>>>
>>>>>> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
>>>>>> Reviewed-by: Kevin Hilman <khilman@baylibre.com>
>>>>>> Reviewed-by: Marc Zyngier <marc.zyngier@arm.com>
>>>>>> ---
>>>>>> include/linux/irq.h | 4 ++++
>>>>>> kernel/irq/chip.c | 35 +++++++++++++++++++++++++++++++++++
>>>>>> kernel/irq/internals.h | 1 +
>>>>>> kernel/irq/manage.c | 31 ++++++++++++++++++++++++++++++-
>>>>>> 4 files changed, 70 insertions(+), 1 deletion(-)
>>>>>>
>>>>>> diff --git a/include/linux/irq.h b/include/linux/irq.h
>>>>>> index 4d758a7c604a..6c92a847394d 100644
>>>>>> --- a/include/linux/irq.h
>>>>>> +++ b/include/linux/irq.h
>>>>>> @@ -315,6 +315,7 @@ static inline irq_hw_number_t irqd_to_hwirq(struct irq_data *d)
>>>>>> /**
>>>>>> * struct irq_chip - hardware interrupt chip descriptor
>>>>>> *
>>>>>> + * @parent_device: pointer to parent device for irqchip
>>>>>> * @name: name for /proc/interrupts
>>>>>> * @irq_startup: start up the interrupt (defaults to ->enable if NULL)
>>>>>> * @irq_shutdown: shut down the interrupt (defaults to ->disable if NULL)
>>>>>> @@ -354,6 +355,7 @@ static inline irq_hw_number_t irqd_to_hwirq(struct irq_data *d)
>>>>>> * @flags: chip specific flags
>>>>>> */
>>>>>> struct irq_chip {
>>>>>> + struct device *parent_device;
>>>>>> const char *name;
>>>>>> unsigned int (*irq_startup)(struct irq_data *data);
>>>>>> void (*irq_shutdown)(struct irq_data *data);
>>>>>> @@ -488,6 +490,8 @@ extern void handle_bad_irq(struct irq_desc *desc);
>>>>>> extern void handle_nested_irq(unsigned int irq);
>>>>>>
>>>>>> extern int irq_chip_compose_msi_msg(struct irq_data *data, struct msi_msg *msg);
>>>>>> +extern int irq_chip_pm_get(struct irq_data *data);
>>>>>> +extern int irq_chip_pm_put(struct irq_data *data);
>>>>>> #ifdef CONFIG_IRQ_DOMAIN_HIERARCHY
>>>>>> extern void irq_chip_enable_parent(struct irq_data *data);
>>>>>> extern void irq_chip_disable_parent(struct irq_data *data);
>>>>>> diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
>>>>>> index 2f9f2b0e79f2..b09226e895c7 100644
>>>>>> --- a/kernel/irq/chip.c
>>>>>> +++ b/kernel/irq/chip.c
>>>>>> @@ -1093,3 +1093,38 @@ int irq_chip_compose_msi_msg(struct irq_data *data, struct msi_msg *msg)
>>>>>>
>>>>>> return 0;
>>>>>> }
>>>>>> +
>>>>>> +/**
>>>>>> + * irq_chip_pm_get - Enable power for an IRQ chip
>>>>>> + * @data: Pointer to interrupt specific data
>>>>>> + *
>>>>>> + * Enable the power to the IRQ chip referenced by the interrupt data
>>>>>> + * structure.
>>>>>> + */
>>>>>> +int irq_chip_pm_get(struct irq_data *data)
>>>>>> +{
>>>>>> + int retval = 0;
>>>>>> +
>>>>>> + if (IS_ENABLED(CONFIG_PM) && data->chip->parent_device)
>>>>>> + retval = pm_runtime_get_sync(data->chip->parent_device);
>>>>>
>>>>> Sry, for the late comment - above require pm_runtime_put_noidle(data->chip->parent_device);
>>>>> in case of failure.
>>>>
>>>> No problem. Sorry, can you elaborate? I am not familiar with the
>>>> _put_noidle().
>>>>
>>>
>>> Question here in use counter - pm_runtime_get_sync() will increment usage_count
>>> always and it will not decrement it in case of failure.
>>> pm_runtime_put_noidle() expected to restore usage_count state (-1).
>>
>> Thanks was not aware of that.
>>
>> Kevin, Marc, given that you have reviewed this one, are you ok with the
>> above change Grygorii is proposing?
>
> Yes, that's the right thing to do on error.
Thanks. I have added this in V6. Please take a look and add your
reviewed-by again if all looks good.
Cheers
Jon
--
nvpublic
next prev parent reply other threads:[~2016-06-10 8:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 11:53 [PATCH V5 0/9] Add support for Tegra210 AGIC Jon Hunter
2016-06-06 11:53 ` [PATCH V5 1/9] irqdomain: Fix handling of type settings for existing mappings Jon Hunter
2016-06-06 11:53 ` [PATCH V5 2/9] genirq: Look-up trigger type if not specified by caller Jon Hunter
2016-06-06 11:53 ` [PATCH V5 3/9] irqdomain: Don't set type when mapping an IRQ Jon Hunter
2016-06-06 11:53 ` [PATCH V5 4/9] genirq: Add runtime power management support for IRQ chips Jon Hunter
2016-06-06 14:13 ` Grygorii Strashko
2016-06-06 14:30 ` Jon Hunter
2016-06-06 14:36 ` Grygorii Strashko
2016-06-06 15:06 ` Jon Hunter
2016-06-06 16:08 ` Marc Zyngier
2016-06-09 22:56 ` Kevin Hilman
2016-06-10 8:05 ` Jon Hunter [this message]
2016-06-06 11:53 ` [PATCH V5 5/9] irqchip/gic: Isolate early GIC initialisation code Jon Hunter
2016-06-06 11:53 ` [PATCH V5 6/9] irqchip/gic: Add helper function for chip initialisation Jon Hunter
2016-06-06 11:53 ` [PATCH V5 7/9] irqchip/gic: Prepare for adding platform driver Jon Hunter
2016-06-06 12:39 ` Jon Hunter
2016-06-06 11:53 ` [PATCH V5 8/9] dt-bindings: arm-gic: Add documentation for Tegra210 AGIC Jon Hunter
2016-06-06 11:53 ` [PATCH V5 9/9] irqchip/gic: Add platform driver for non-root GICs that require RPM Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=575A74D5.4050905@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=geert@linux-m68k.org \
--cc=grygorii.strashko@ti.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jason@lakedaemon.net \
--cc=khilman@baylibre.com \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).