* Re: [PATCH 06/12] hsi: Only descend into hsi directory when CONFIG_HSI is set [not found] <20160613200211.14790-7-afd@ti.com> @ 2016-06-14 0:36 ` kbuild test robot 2016-06-14 16:13 ` [PATCH] hsi: Build hsi_boardinfo.c into hsi core if enabled Andrew F. Davis 0 siblings, 1 reply; 3+ messages in thread From: kbuild test robot @ 2016-06-14 0:36 UTC (permalink / raw) To: Andrew F. Davis Cc: kbuild-all, Russell King, Miguel Ojeda Sandonis, Linus Walleij, Sebastian Reichel, Wolfram Sang, Richard Purdie, Jacek Anaszewski, Rusty Russell, Benjamin Herrenschmidt, Mauro Carvalho Chehab, Ulf Hansson, Lauro Ramos Venancio, Aloisio Almeida Jr, Samuel Ortiz, Ingo Molnar, linux-pwm, lguest, linux-wireless, linux-mmc, linux-kernel, Andrew F . Davis, linux-gpio, linux-i2c, linuxppc-dev, linux-leds, linux-media [-- Attachment #1: Type: text/plain, Size: 886 bytes --] Hi, [auto build test ERROR on gpio/for-next] [also build test ERROR on v4.7-rc3 next-20160609] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Andrew-F-Davis/gpio-Only-descend-into-gpio-directory-when-CONFIG_GPIOLIB-is-set/20160614-061705 base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git for-next config: i386-randconfig-sb0-06140627 (attached as .config) compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): >> ERROR: "hsi_board_list" [drivers/hsi/hsi.ko] undefined! --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation [-- Attachment #2: .config.gz --] [-- Type: application/octet-stream, Size: 24709 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] hsi: Build hsi_boardinfo.c into hsi core if enabled 2016-06-14 0:36 ` [PATCH 06/12] hsi: Only descend into hsi directory when CONFIG_HSI is set kbuild test robot @ 2016-06-14 16:13 ` Andrew F. Davis 2016-06-15 12:48 ` Sebastian Reichel 0 siblings, 1 reply; 3+ messages in thread From: Andrew F. Davis @ 2016-06-14 16:13 UTC (permalink / raw) To: kbuild test robot Cc: kbuild-all, Russell King, Miguel Ojeda Sandonis, Linus Walleij, Sebastian Reichel, Wolfram Sang, Richard Purdie, Jacek Anaszewski, Rusty Russell, Benjamin Herrenschmidt, Mauro Carvalho Chehab, Ulf Hansson, Lauro Ramos Venancio, Aloisio Almeida Jr, Samuel Ortiz, Ingo Molnar, linux-pwm, lguest, linux-wireless, linux-mmc, linux-kernel, linux-gpio, linux-i2c, linuxppc-dev, linux-leds, linux-media If the HSI core is built as a module hsi_boardinfo may still be built-in as its Kconfig type is bool, which can cause build issues. Fix this by building this code into the HSI core when enabled. Reported-by: kbuild test robot <lkp@intel.com> Signed-off-by: Andrew F. Davis <afd@ti.com> --- This build error seems to be due to Kconfig symbol CONFIG_HSI_BOARDINFO being a bool but depending on a tristate (CONFIG_HSI). This is normally okay when it is just a flag to enable a feature in source, but the helper code file hsi_boardinfo.c is built as a separate entity when enabled. This patch is probably how it was intended, and is more like how others do this kind of thing. This patch should be applied before the parent patch: drivers/hsi/Makefile | 3 ++- drivers/hsi/{hsi.c => hsi_core.c} | 0 2 files changed, 2 insertions(+), 1 deletion(-) rename drivers/hsi/{hsi.c => hsi_core.c} (100%) diff --git a/drivers/hsi/Makefile b/drivers/hsi/Makefile index 360371e..9694478 100644 --- a/drivers/hsi/Makefile +++ b/drivers/hsi/Makefile @@ -1,7 +1,8 @@ # # Makefile for HSI # -obj-$(CONFIG_HSI_BOARDINFO) += hsi_boardinfo.o obj-$(CONFIG_HSI) += hsi.o +hsi-objs := hsi_core.o +hsi-$(CONFIG_HSI_BOARDINFO) += hsi_boardinfo.o obj-y += controllers/ obj-y += clients/ diff --git a/drivers/hsi/hsi.c b/drivers/hsi/hsi_core.c similarity index 100% rename from drivers/hsi/hsi.c rename to drivers/hsi/hsi_core.c -- 2.8.3 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] hsi: Build hsi_boardinfo.c into hsi core if enabled 2016-06-14 16:13 ` [PATCH] hsi: Build hsi_boardinfo.c into hsi core if enabled Andrew F. Davis @ 2016-06-15 12:48 ` Sebastian Reichel 0 siblings, 0 replies; 3+ messages in thread From: Sebastian Reichel @ 2016-06-15 12:48 UTC (permalink / raw) To: Andrew F. Davis Cc: kbuild test robot, kbuild-all, Russell King, Miguel Ojeda Sandonis, Linus Walleij, Wolfram Sang, Richard Purdie, Jacek Anaszewski, Rusty Russell, Benjamin Herrenschmidt, Mauro Carvalho Chehab, Ulf Hansson, Lauro Ramos Venancio, Aloisio Almeida Jr, Samuel Ortiz, Ingo Molnar, linux-pwm, lguest, linux-wireless, linux-mmc, linux-kernel, linux-gpio, linux-i2c, linuxppc-dev, linux-leds, linux-media [-- Attachment #1: Type: text/plain, Size: 908 bytes --] Hi Andrew, On Tue, Jun 14, 2016 at 11:13:04AM -0500, Andrew F. Davis wrote: > If the HSI core is built as a module hsi_boardinfo may still > be built-in as its Kconfig type is bool, which can cause build > issues. Fix this by building this code into the HSI core when > enabled. > > Reported-by: kbuild test robot <lkp@intel.com> > Signed-off-by: Andrew F. Davis <afd@ti.com> > --- > This build error seems to be due to Kconfig symbol CONFIG_HSI_BOARDINFO > being a bool but depending on a tristate (CONFIG_HSI). This is normally > okay when it is just a flag to enable a feature in source, but the > helper code file hsi_boardinfo.c is built as a separate entity when > enabled. This patch is probably how it was intended, and is more like > how others do this kind of thing. > > This patch should be applied before the parent patch: Thanks, I applied both patches. -- Sebastian [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-15 12:48 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <20160613200211.14790-7-afd@ti.com> 2016-06-14 0:36 ` [PATCH 06/12] hsi: Only descend into hsi directory when CONFIG_HSI is set kbuild test robot 2016-06-14 16:13 ` [PATCH] hsi: Build hsi_boardinfo.c into hsi core if enabled Andrew F. Davis 2016-06-15 12:48 ` Sebastian Reichel
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).