linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Mark Brown <broonie@kernel.org>,
	alsa-devel@alsa-project.org, Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	plai@codeaurora.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v3 1/2] ASoC: msm8916: Add codec Device Tree bindings.
Date: Wed, 15 Jun 2016 10:16:20 +0100	[thread overview]
Message-ID: <57611CE4.3050400@linaro.org> (raw)
In-Reply-To: <20160614161227.GA10893@kwestfie-linux.qualcomm.com>


Thanks for review comments,
On 14/06/16 17:12, Kenneth Westfield wrote:
> On Fri, Jun 10, 2016 at 11:18:44AM -0700, Srinivas Kandagatla wrote:
>> diff --git a/Documentation/devicetree/bindings/sound/qcom,msm8916-wcd.txt
>> b/Documentation/devicetree/bindings/sound/qcom,msm8916-wcd.txt
>> new file mode 100644
>> index 0000000..0559c1f
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/sound/qcom,msm8916-wcd.txt
>> @@ -0,0 +1,103 @@
>> +msm8916 audio CODEC audio CODEC
>> +
>> +Codec IP is divided into two parts, first analog which is integrated in
>> pmic pm8916
>> +and secondly digital part which is integrated into application processor.
>> Codec register
>> +controls are also split across pmic an lpass. Analog part is controlled
>> via spmi bus to pmic.
>
> Cleaning up the description:
>
> msm8916 audio CODEC
>
> Codec IP is divided into two parts:
>    * analog, which is integrated into pmic pm8916
>    * digital, which is integrated into LPASS on the SOC
> Codec registers are also split across pmic and LPASS.
> Analog codec is controlled via spmi bus to pmic.
>
>> +## Bindings for codec core on pmic:
>> +
>> +Required properties
>> + - compatible = "qcom,msm8916-pmic-wcd-codec";
>
> OK.  Looking at this again, I think its better just to drop the pmic.
>
Yep..
>> +  "spk_cnp_int" - Speaker click and pop interrupt
>> +  "spk_clip_int" - Speaker clip interrupt
>> +  "spk_ocp_int" - Speaker over current protect interrupt.
>> +  "ins_rem_det1" - jack insert removal detect interrupt 1.
>> +  "but_rel_det" - button release interrupt
>> +  "but_press_det" - button press event
>> +  "ins_rem_det" - jack insert removal detect interrup
>> +  "mbhc_int"	- multi button headset interrupt.
>> +  "ear_ocp_int" - Earphone over current protect interrupt.
>> +  "hphr_ocp_int" - Headphone R over current protect interrupt.
>> +  "hphl_ocp_det" - Headphone L over current protect interrupt
>> +  "ear_cnp_int" - earphone cnp interrupt.
>> +  "hphr_cnp_int" - hphr click and pop interrupt.
>> +  "hphl_cnp_int" - hphl click and pop interrupt
>
> Please use labels that more closely match the HW spec:
>    "cdc_spk_cnp_int"
>    "cdc_spk_clip_int"
>    "cdc_spk_ocp_int"
>    "mbhc_ins_rem_det1"
>    "mbhc_but_rel_det"
>    "mbhc_but_press_det"
>    "mbhc_ins_rem_det"
>    "mbhc_switch_int"
>    "cdc_ear_ocp_int"
>    "cdc_hphr_ocp_int"
>    "cdc_hphl_ocp_int"
>    "cdc_ear_cnp_int"
>    "cdc_hphr_cnp_int"
>    "cdc_hphl_cnp_int"
>
Yes, we can do that to match the specs.

  reply	other threads:[~2016-06-15  9:16 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-10 18:18 [PATCH v3 0/2] ASoC: Add support to Qualcomm msm8916-wcd codec Srinivas Kandagatla
2016-06-10 18:18 ` [PATCH v3 1/2] ASoC: msm8916: Add codec Device Tree bindings Srinivas Kandagatla
2016-06-14 15:23   ` Mark Brown
2016-06-15  9:16     ` Srinivas Kandagatla
2016-06-14 16:12   ` Kenneth Westfield
2016-06-15  9:16     ` Srinivas Kandagatla [this message]
2016-06-10 18:18 ` [PATCH v3 2/2] ASoC: msm8916: Add msm8916-wcd codec driver Srinivas Kandagatla
2016-06-14 15:59   ` Mark Brown
2016-06-15  9:16     ` Srinivas Kandagatla
2016-06-15  9:31       ` Mark Brown
2016-06-15 20:07         ` Kenneth Westfield
2016-06-16 13:19           ` Srinivas Kandagatla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57611CE4.3050400@linaro.org \
    --to=srinivas.kandagatla@linaro.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=perex@perex.cz \
    --cc=plai@codeaurora.org \
    --cc=robh+dt@kernel.org \
    --cc=tiwai@suse.com \
    --subject='Re: [PATCH v3 1/2] ASoC: msm8916: Add codec Device Tree bindings.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).