From: Mark Brown <broonie@kernel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: alsa-devel@alsa-project.org, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
kwestfie@codeaurora.org, plai@codeaurora.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v3 1/2] ASoC: msm8916: Add codec Device Tree bindings.
Date: Tue, 14 Jun 2016 16:23:18 +0100 [thread overview]
Message-ID: <20160614152318.GR2282@sirena.org.uk> (raw)
In-Reply-To: <1465582725-30183-2-git-send-email-srinivas.kandagatla@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1029 bytes --]
On Fri, Jun 10, 2016 at 07:18:44PM +0100, Srinivas Kandagatla wrote:
> +Codec IP is divided into two parts, first analog which is integrated in pmic pm8916
> +and secondly digital part which is integrated into application processor. Codec register
> +controls are also split across pmic an lpass. Analog part is controlled via spmi bus to pmic.
Please keep things wrapped at less than 80 columns.
> + - interrupt-parent : The parent interrupt controller.
> + - interrupts: List of interrupts in given SPMI peripheral.
> + - interrupt-names: Names specified to above list of interrupts in same
> + order. List of supported interrupt names are:
> + "spk_cnp_int" - Speaker click and pop interrupt
Please format this more clearly so these don't look like properties,
more indentation would be good.
> + - vddio-supply: phandle to VDD_CDC_IO regulator device tree node.
> + - vdd-tx-rx-supply: phandle to VDD_CDC_TX/RX/CX regulator device tree node.
You should name the supplies with the same name as the datasheet uses.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-06-14 15:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-10 18:18 [PATCH v3 0/2] ASoC: Add support to Qualcomm msm8916-wcd codec Srinivas Kandagatla
2016-06-10 18:18 ` [PATCH v3 1/2] ASoC: msm8916: Add codec Device Tree bindings Srinivas Kandagatla
2016-06-14 15:23 ` Mark Brown [this message]
2016-06-15 9:16 ` Srinivas Kandagatla
2016-06-14 16:12 ` Kenneth Westfield
2016-06-15 9:16 ` Srinivas Kandagatla
2016-06-10 18:18 ` [PATCH v3 2/2] ASoC: msm8916: Add msm8916-wcd codec driver Srinivas Kandagatla
2016-06-14 15:59 ` Mark Brown
2016-06-15 9:16 ` Srinivas Kandagatla
2016-06-15 9:31 ` Mark Brown
2016-06-15 20:07 ` Kenneth Westfield
2016-06-16 13:19 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160614152318.GR2282@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=kwestfie@codeaurora.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=perex@perex.cz \
--cc=plai@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).