* [PATCH] selftests/exec: Makefile is a run-time dependency, add it to the install list
@ 2016-06-15 18:36 Yannick Brosseau
2016-06-15 20:11 ` Shuah Khan
0 siblings, 1 reply; 2+ messages in thread
From: Yannick Brosseau @ 2016-06-15 18:36 UTC (permalink / raw)
To: shuahkh, linux-kselftest, linux-kernel; +Cc: kernel-team, Yannick Brosseau
The execveat test try to exec the Makefile file and expect an EACCES results. When running
the test in the installed destination it would fail with ENOENT since the file is
not there.
Add Makefile to the TEST_FILES list so it's copied at install time.
Signed-off-by: Yannick Brosseau <scientist@fb.com>
---
tools/testing/selftests/exec/Makefile | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/exec/Makefile b/tools/testing/selftests/exec/Makefile
index 4e400eb..d430060 100644
--- a/tools/testing/selftests/exec/Makefile
+++ b/tools/testing/selftests/exec/Makefile
@@ -18,7 +18,8 @@ execveat.denatured: execveat
$(CC) $(CFLAGS) -o $@ $^
TEST_PROGS := execveat
-TEST_FILES := $(DEPS)
+# Makefile is a run-time dependency, since it's accessed by the execveat test
+TEST_FILES := $(DEPS) Makefile
include ../lib.mk
--
2.8.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] selftests/exec: Makefile is a run-time dependency, add it to the install list
2016-06-15 18:36 [PATCH] selftests/exec: Makefile is a run-time dependency, add it to the install list Yannick Brosseau
@ 2016-06-15 20:11 ` Shuah Khan
0 siblings, 0 replies; 2+ messages in thread
From: Shuah Khan @ 2016-06-15 20:11 UTC (permalink / raw)
To: Yannick Brosseau, linux-kselftest, linux-kernel; +Cc: kernel-team, Shuah Khan
On 06/15/2016 12:36 PM, Yannick Brosseau wrote:
> The execveat test try to exec the Makefile file and expect an EACCES results. When running
> the test in the installed destination it would fail with ENOENT since the file is
> not there.
> Add Makefile to the TEST_FILES list so it's copied at install time.
>
> Signed-off-by: Yannick Brosseau <scientist@fb.com>
> ---
> tools/testing/selftests/exec/Makefile | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/exec/Makefile b/tools/testing/selftests/exec/Makefile
> index 4e400eb..d430060 100644
> --- a/tools/testing/selftests/exec/Makefile
> +++ b/tools/testing/selftests/exec/Makefile
> @@ -18,7 +18,8 @@ execveat.denatured: execveat
> $(CC) $(CFLAGS) -o $@ $^
>
> TEST_PROGS := execveat
> -TEST_FILES := $(DEPS)
> +# Makefile is a run-time dependency, since it's accessed by the execveat test
> +TEST_FILES := $(DEPS) Makefile
>
> include ../lib.mk
>
>
Thanks. Applied and queued for the next rc in linux-kselftest fixes branch
-- Shuah
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-15 20:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-15 18:36 [PATCH] selftests/exec: Makefile is a run-time dependency, add it to the install list Yannick Brosseau
2016-06-15 20:11 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).