linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] staging:vt6656:card.c:Fix comment block issue
@ 2016-06-11 20:08 Rithvik Patibandla
  2016-06-15 20:27 ` Luis de Bethencourt
  0 siblings, 1 reply; 2+ messages in thread
From: Rithvik Patibandla @ 2016-06-11 20:08 UTC (permalink / raw)
  To: forest; +Cc: gregkh, habdul, devel, linux-kernel

Fix "Block comments use * on subsequent lines" and "Block comments use
*/ on trailing lines" warnings thrown by checkpatch.pl

Signed-off-by: Rithvik Patibandla <rithvikp98@gmail.com>
---
 drivers/staging/vt6656/card.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/vt6656/card.c b/drivers/staging/vt6656/card.c
index a382fc6..607834c 100644
--- a/drivers/staging/vt6656/card.c
+++ b/drivers/staging/vt6656/card.c
@@ -47,7 +47,8 @@
 #include "usbpipe.h"
 
 /* const u16 cwRXBCNTSFOff[MAX_RATE] =
-   {17, 34, 96, 192, 34, 23, 17, 11, 8, 5, 4, 3}; */
+ *   {17, 34, 96, 192, 34, 23, 17, 11, 8, 5, 4, 3};
+ */
 
 static const u16 cwRXBCNTSFOff[MAX_RATE] = {
 	192, 96, 34, 17, 34, 23, 17, 11, 8, 5, 4, 3
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] staging:vt6656:card.c:Fix comment block issue
  2016-06-11 20:08 [PATCH] staging:vt6656:card.c:Fix comment block issue Rithvik Patibandla
@ 2016-06-15 20:27 ` Luis de Bethencourt
  0 siblings, 0 replies; 2+ messages in thread
From: Luis de Bethencourt @ 2016-06-15 20:27 UTC (permalink / raw)
  To: Rithvik Patibandla, forest; +Cc: devel, gregkh, habdul, linux-kernel

On 11/06/16 21:08, Rithvik Patibandla wrote:
> Fix "Block comments use * on subsequent lines" and "Block comments use
> */ on trailing lines" warnings thrown by checkpatch.pl
> 
> Signed-off-by: Rithvik Patibandla <rithvikp98@gmail.com>
> ---
>  drivers/staging/vt6656/card.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/vt6656/card.c b/drivers/staging/vt6656/card.c
> index a382fc6..607834c 100644
> --- a/drivers/staging/vt6656/card.c
> +++ b/drivers/staging/vt6656/card.c
> @@ -47,7 +47,8 @@
>  #include "usbpipe.h"
>  
>  /* const u16 cwRXBCNTSFOff[MAX_RATE] =
> -   {17, 34, 96, 192, 34, 23, 17, 11, 8, 5, 4, 3}; */
> + *   {17, 34, 96, 192, 34, 23, 17, 11, 8, 5, 4, 3};
> + */
>  
>  static const u16 cwRXBCNTSFOff[MAX_RATE] = {
>  	192, 96, 34, 17, 34, 23, 17, 11, 8, 5, 4, 3
> 

Hi Rithvik,

The following warning is indeed fixed :) This patch looks good.

WARNING: Block comments use * on subsequent lines
#50: FILE: drivers/staging/vt6656/card.c:50:
+/* const u16 cwRXBCNTSFOff[MAX_RATE] =
+   {17, 34, 96, 192, 34, 23, 17, 11, 8, 5, 4, 3}; */


There are 32 other checks that checkpatch complains about in that file.
Please send fixes for those as well.

Luis

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-06-15 20:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-11 20:08 [PATCH] staging:vt6656:card.c:Fix comment block issue Rithvik Patibandla
2016-06-15 20:27 ` Luis de Bethencourt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).