* [PATCH] scripts/gdb: add constants.py to .gitignore
@ 2016-06-20 20:00 Omar Sandoval
2016-06-21 20:56 ` Kieran Bingham
0 siblings, 1 reply; 2+ messages in thread
From: Omar Sandoval @ 2016-06-20 20:00 UTC (permalink / raw)
To: Jan Kiszka, Kieran Bingham; +Cc: linux-kernel
From: Omar Sandoval <osandov@fb.com>
Since scripts/gdb/linux/constants.py is autogenerated, this should have
been added to .gitignore when it was introduced.
Fixes: f197d75fcad1 ("scripts/gdb: provide linux constants")
Signed-off-by: Omar Sandoval <osandov@fb.com>
---
.gitignore | 3 +++
1 file changed, 3 insertions(+)
diff --git a/.gitignore b/.gitignore
index 0c320bf02586..5cdccb07e3a3 100644
--- a/.gitignore
+++ b/.gitignore
@@ -112,3 +112,6 @@ all.config
# Kdevelop4
*.kdev4
+
+# Generated for CONFIG_GDB_SCRIPTS
+/scripts/gdb/linux/constants.py
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scripts/gdb: add constants.py to .gitignore
2016-06-20 20:00 [PATCH] scripts/gdb: add constants.py to .gitignore Omar Sandoval
@ 2016-06-21 20:56 ` Kieran Bingham
0 siblings, 0 replies; 2+ messages in thread
From: Kieran Bingham @ 2016-06-21 20:56 UTC (permalink / raw)
To: Omar Sandoval, Jan Kiszka; +Cc: linux-kernel
Hi Omar,
Thanks for spotting, and submitting this.
On 20/06/16 21:00, Omar Sandoval wrote:
> From: Omar Sandoval <osandov@fb.com>
>
> Since scripts/gdb/linux/constants.py is autogenerated, this should have
> been added to .gitignore when it was introduced.
Absolutely! - This never hit me, as I always build out-of-tree
> Fixes: f197d75fcad1 ("scripts/gdb: provide linux constants")
> Signed-off-by: Omar Sandoval <osandov@fb.com>
Unfortunately - Nacked on the principle of the comment in the top of the
.gitignore file:
# NOTE! Don't add files that are generated in specific
# subdirectories here. Add them in the ".gitignore" file
# in that subdirectory instead.
Could you fix this up (meaning add to the .gitignore under
scripts/gdb/linux) and resend please?
Then I'll add to my queue to send as fixes for current.
(which I'm hoping to get sent before the weekend, or at the weekend)
> ---
> .gitignore | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/.gitignore b/.gitignore
> index 0c320bf02586..5cdccb07e3a3 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -112,3 +112,6 @@ all.config
>
> # Kdevelop4
> *.kdev4
> +
> +# Generated for CONFIG_GDB_SCRIPTS
> +/scripts/gdb/linux/constants.py
>
--
Regards
Kieran Bingham
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-21 22:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-20 20:00 [PATCH] scripts/gdb: add constants.py to .gitignore Omar Sandoval
2016-06-21 20:56 ` Kieran Bingham
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).