* [PATCH] devfreq: Add COMPILE_TEST for build coverage
@ 2016-06-27 13:58 Krzysztof Kozlowski
2016-06-27 18:37 ` kbuild test robot
2016-06-29 11:17 ` Krzysztof Kozlowski
0 siblings, 2 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2016-06-27 13:58 UTC (permalink / raw)
To: MyungJoo Ham, Kyungmin Park, Chanwoo Choi, linux-pm, linux-kernel
Cc: Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz
The SoC-specific devfreq and event drivers can be build tested on all
architectures.
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
Success of compilation tested on ARM, ARM64, i386, x86_64 and powerpc
architectures (allyesconfigs).
---
drivers/devfreq/Kconfig | 4 ++--
drivers/devfreq/event/Kconfig | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
index 78dac0e9da11..8a93d65cf550 100644
--- a/drivers/devfreq/Kconfig
+++ b/drivers/devfreq/Kconfig
@@ -76,7 +76,7 @@ comment "DEVFREQ Drivers"
config ARM_EXYNOS_BUS_DEVFREQ
bool "ARM EXYNOS Generic Memory Bus DEVFREQ Driver"
- depends on ARCH_EXYNOS
+ depends on ARCH_EXYNOS || COMPILE_TEST
select DEVFREQ_GOV_SIMPLE_ONDEMAND
select DEVFREQ_GOV_PASSIVE
select DEVFREQ_EVENT_EXYNOS_PPMU
@@ -92,7 +92,7 @@ config ARM_EXYNOS_BUS_DEVFREQ
config ARM_TEGRA_DEVFREQ
tristate "Tegra DEVFREQ Driver"
- depends on ARCH_TEGRA_124_SOC
+ depends on ARCH_TEGRA_124_SOC || (COMPILE_TEST && HAVE_CLK)
select DEVFREQ_GOV_SIMPLE_ONDEMAND
select PM_OPP
help
diff --git a/drivers/devfreq/event/Kconfig b/drivers/devfreq/event/Kconfig
index 1e8b4f469f38..ad982092359a 100644
--- a/drivers/devfreq/event/Kconfig
+++ b/drivers/devfreq/event/Kconfig
@@ -15,7 +15,7 @@ if PM_DEVFREQ_EVENT
config DEVFREQ_EVENT_EXYNOS_NOCP
bool "EXYNOS NoC (Network On Chip) Probe DEVFREQ event Driver"
- depends on ARCH_EXYNOS
+ depends on ARCH_EXYNOS || COMPILE_TEST
select PM_OPP
help
This add the devfreq-event driver for Exynos SoC. It provides NoC
@@ -23,7 +23,7 @@ config DEVFREQ_EVENT_EXYNOS_NOCP
config DEVFREQ_EVENT_EXYNOS_PPMU
bool "EXYNOS PPMU (Platform Performance Monitoring Unit) DEVFREQ event Driver"
- depends on ARCH_EXYNOS
+ depends on ARCH_EXYNOS || COMPILE_TEST
select PM_OPP
help
This add the devfreq-event driver for Exynos SoC. It provides PPMU
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] devfreq: Add COMPILE_TEST for build coverage
2016-06-27 13:58 [PATCH] devfreq: Add COMPILE_TEST for build coverage Krzysztof Kozlowski
@ 2016-06-27 18:37 ` kbuild test robot
2016-06-28 7:32 ` Krzysztof Kozlowski
2016-06-29 11:17 ` Krzysztof Kozlowski
1 sibling, 1 reply; 5+ messages in thread
From: kbuild test robot @ 2016-06-27 18:37 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: kbuild-all, MyungJoo Ham, Kyungmin Park, Chanwoo Choi, linux-pm,
linux-kernel, Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz
[-- Attachment #1: Type: text/plain, Size: 3426 bytes --]
Hi,
[auto build test ERROR on v4.7-rc5]
[also build test ERROR on next-20160627]
[cannot apply to devfreq/for-rafael]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Krzysztof-Kozlowski/devfreq-Add-COMPILE_TEST-for-build-coverage/20160627-220248
config: sh-allyesconfig (attached as .config)
compiler: sh4-linux-gnu-gcc (Debian 5.3.1-8) 5.3.1 20160205
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=sh
All errors (new ones prefixed by >>):
drivers/devfreq/tegra-devfreq.c: In function 'tegra_actmon_rate_notify_cb':
>> drivers/devfreq/tegra-devfreq.c:391:16: error: 'POST_RATE_CHANGE' undeclared (first use in this function)
if (action != POST_RATE_CHANGE)
^
drivers/devfreq/tegra-devfreq.c:391:16: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/devfreq/tegra-devfreq.c:396:24: error: dereferencing pointer to incomplete type 'struct clk_notifier_data'
tegra->cur_freq = data->new_rate / KHZ;
^
drivers/devfreq/tegra-devfreq.c: In function 'tegra_devfreq_probe':
>> drivers/devfreq/tegra-devfreq.c:654:8: error: implicit declaration of function 'clk_notifier_register' [-Werror=implicit-function-declaration]
err = clk_notifier_register(tegra->emc_clock, &tegra->rate_change_nb);
^
drivers/devfreq/tegra-devfreq.c: In function 'tegra_devfreq_remove':
>> drivers/devfreq/tegra-devfreq.c:734:2: error: implicit declaration of function 'clk_notifier_unregister' [-Werror=implicit-function-declaration]
clk_notifier_unregister(tegra->emc_clock, &tegra->rate_change_nb);
^
cc1: some warnings being treated as errors
vim +/POST_RATE_CHANGE +391 drivers/devfreq/tegra-devfreq.c
6234f380 Tomeu Vizoso 2014-11-24 385 struct clk_notifier_data *data = ptr;
11573e91 Tomeu Vizoso 2015-03-17 386 struct tegra_devfreq *tegra;
11573e91 Tomeu Vizoso 2015-03-17 387 struct tegra_devfreq_device *dev;
6234f380 Tomeu Vizoso 2014-11-24 388 unsigned int i;
6234f380 Tomeu Vizoso 2014-11-24 389 unsigned long flags;
6234f380 Tomeu Vizoso 2014-11-24 390
11573e91 Tomeu Vizoso 2015-03-17 @391 if (action != POST_RATE_CHANGE)
11573e91 Tomeu Vizoso 2015-03-17 392 return NOTIFY_OK;
11573e91 Tomeu Vizoso 2015-03-17 393
11573e91 Tomeu Vizoso 2015-03-17 394 tegra = container_of(nb, struct tegra_devfreq, rate_change_nb);
6234f380 Tomeu Vizoso 2014-11-24 395
6234f380 Tomeu Vizoso 2014-11-24 @396 tegra->cur_freq = data->new_rate / KHZ;
6234f380 Tomeu Vizoso 2014-11-24 397
11573e91 Tomeu Vizoso 2015-03-17 398 for (i = 0; i < ARRAY_SIZE(tegra->devices); i++) {
11573e91 Tomeu Vizoso 2015-03-17 399 dev = &tegra->devices[i];
:::::: The code at line 391 was first introduced by commit
:::::: 11573e9132ae40239195fe5162d48caf2b7d85bb PM / devfreq: tegra: Update to v5 of the submitted patches
:::::: TO: Tomeu Vizoso <tomeu.vizoso@collabora.com>
:::::: CC: MyungJoo Ham <myungjoo.ham@samsung.com>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 40259 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] devfreq: Add COMPILE_TEST for build coverage
2016-06-27 18:37 ` kbuild test robot
@ 2016-06-28 7:32 ` Krzysztof Kozlowski
0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2016-06-28 7:32 UTC (permalink / raw)
To: kbuild test robot
Cc: kbuild-all, MyungJoo Ham, Kyungmin Park, Chanwoo Choi, linux-pm,
linux-kernel, Bartlomiej Zolnierkiewicz
On 06/27/2016 08:37 PM, kbuild test robot wrote:
> Hi,
>
> [auto build test ERROR on v4.7-rc5]
> [also build test ERROR on next-20160627]
> [cannot apply to devfreq/for-rafael]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url: https://github.com/0day-ci/linux/commits/Krzysztof-Kozlowski/devfreq-Add-COMPILE_TEST-for-build-coverage/20160627-220248
> config: sh-allyesconfig (attached as .config)
> compiler: sh4-linux-gnu-gcc (Debian 5.3.1-8) 5.3.1 20160205
> reproduce:
> wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # save the attached .config to linux build tree
> make.cross ARCH=sh
>
> All errors (new ones prefixed by >>):
>
> drivers/devfreq/tegra-devfreq.c: In function 'tegra_actmon_rate_notify_cb':
>>> drivers/devfreq/tegra-devfreq.c:391:16: error: 'POST_RATE_CHANGE' undeclared (first use in this function)
> if (action != POST_RATE_CHANGE)
> ^
> drivers/devfreq/tegra-devfreq.c:391:16: note: each undeclared identifier is reported only once for each function it appears in
>>> drivers/devfreq/tegra-devfreq.c:396:24: error: dereferencing pointer to incomplete type 'struct clk_notifier_data'
> tegra->cur_freq = data->new_rate / KHZ;
> ^
> drivers/devfreq/tegra-devfreq.c: In function 'tegra_devfreq_probe':
>>> drivers/devfreq/tegra-devfreq.c:654:8: error: implicit declaration of function 'clk_notifier_register' [-Werror=implicit-function-declaration]
> err = clk_notifier_register(tegra->emc_clock, &tegra->rate_change_nb);
> ^
> drivers/devfreq/tegra-devfreq.c: In function 'tegra_devfreq_remove':
>>> drivers/devfreq/tegra-devfreq.c:734:2: error: implicit declaration of function 'clk_notifier_unregister' [-Werror=implicit-function-declaration]
> clk_notifier_unregister(tegra->emc_clock, &tegra->rate_change_nb);
> ^
> cc1: some warnings being treated as errors
I sent a follow up [1] for clock which I think fixes this report. In
case it won't be accepted, I'll change the Kconfig dependency to COMMON_CLK.
[1] https://lkml.org/lkml/2016/6/28/73
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] devfreq: Add COMPILE_TEST for build coverage
2016-06-27 13:58 [PATCH] devfreq: Add COMPILE_TEST for build coverage Krzysztof Kozlowski
2016-06-27 18:37 ` kbuild test robot
@ 2016-06-29 11:17 ` Krzysztof Kozlowski
2016-07-12 10:11 ` MyungJoo Ham
1 sibling, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2016-06-29 11:17 UTC (permalink / raw)
To: MyungJoo Ham, Kyungmin Park, Chanwoo Choi, linux-pm, linux-kernel
Cc: Bartlomiej Zolnierkiewicz
On 06/27/2016 03:58 PM, Krzysztof Kozlowski wrote:
> The SoC-specific devfreq and event drivers can be build tested on all
> architectures.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
> ---
>
> Success of compilation tested on ARM, ARM64, i386, x86_64 and powerpc
> architectures (allyesconfigs).
> ---
> drivers/devfreq/Kconfig | 4 ++--
> drivers/devfreq/event/Kconfig | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
Hi all,
The patchset depends "clk: Provide notifier stubs when
!COMMON_CLKclk-notify" [1] which you can get by merging clk-notify
branch of clk tree:
git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-notify
Can you pull while applying?
Best regards,
Krzysztof
[1]
https://git.kernel.org/cgit/linux/kernel/git/clk/linux.git/commit/?h=clk-notify&id=e81b87d22a8fed6bac24197972c9c394a2b92b5d
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] devfreq: Add COMPILE_TEST for build coverage
2016-06-29 11:17 ` Krzysztof Kozlowski
@ 2016-07-12 10:11 ` MyungJoo Ham
0 siblings, 0 replies; 5+ messages in thread
From: MyungJoo Ham @ 2016-07-12 10:11 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Kyungmin Park, Chanwoo Choi, Linux PM list, LKML,
Bartlomiej Zolnierkiewicz
On Wed, Jun 29, 2016 at 8:17 PM, Krzysztof Kozlowski
<k.kozlowski@samsung.com> wrote:
> On 06/27/2016 03:58 PM, Krzysztof Kozlowski wrote:
>> The SoC-specific devfreq and event drivers can be build tested on all
>> architectures.
>>
>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>>
>> ---
>>
>> Success of compilation tested on ARM, ARM64, i386, x86_64 and powerpc
>> architectures (allyesconfigs).
>> ---
>> drivers/devfreq/Kconfig | 4 ++--
>> drivers/devfreq/event/Kconfig | 4 ++--
>> 2 files changed, 4 insertions(+), 4 deletions(-)
>MyungJoo Ham, Ph.D.
Frontier CS Lab, S/W Center, Samsung Electronics
> Hi all,
>
> The patchset depends "clk: Provide notifier stubs when
> !COMMON_CLKclk-notify" [1] which you can get by merging clk-notify
> branch of clk tree:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-notify
>
> Can you pull while applying?
>
It is temporarily pulled at a branch "testing/kozlowki". Anyway, at
which version is this "clk-notify" being merged?
Cheers,
MyungJoo
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-07-12 10:12 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-27 13:58 [PATCH] devfreq: Add COMPILE_TEST for build coverage Krzysztof Kozlowski
2016-06-27 18:37 ` kbuild test robot
2016-06-28 7:32 ` Krzysztof Kozlowski
2016-06-29 11:17 ` Krzysztof Kozlowski
2016-07-12 10:11 ` MyungJoo Ham
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).