* [PATCH] memory: samsung: exynos-srom: fix wrong count of registers
@ 2016-07-05 11:40 ` Seung-Woo Kim
2016-07-06 0:12 ` Chanwoo Choi
2016-07-06 6:17 ` Krzysztof Kozlowski
0 siblings, 2 replies; 3+ messages in thread
From: Seung-Woo Kim @ 2016-07-05 11:40 UTC (permalink / raw)
To: linux-samsung-soc, linux-arm-kernel, linux-kernel, k.kozlowski, kgene
Cc: cw00.choi, sw0312.kim
This patch fixes wrong count of array for srom registers from probe
function.
Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
---
drivers/memory/samsung/exynos-srom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/memory/samsung/exynos-srom.c b/drivers/memory/samsung/exynos-srom.c
index 96756fb..c66d2bd 100644
--- a/drivers/memory/samsung/exynos-srom.c
+++ b/drivers/memory/samsung/exynos-srom.c
@@ -134,7 +134,7 @@ static int exynos_srom_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, srom);
srom->reg_offset = exynos_srom_alloc_reg_dump(exynos_srom_offsets,
- sizeof(exynos_srom_offsets));
+ ARRAY_SIZE(exynos_srom_offsets));
if (!srom->reg_offset) {
iounmap(srom->reg_base);
return -ENOMEM;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] memory: samsung: exynos-srom: fix wrong count of registers
2016-07-05 11:40 ` [PATCH] memory: samsung: exynos-srom: fix wrong count of registers Seung-Woo Kim
@ 2016-07-06 0:12 ` Chanwoo Choi
2016-07-06 6:17 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Chanwoo Choi @ 2016-07-06 0:12 UTC (permalink / raw)
To: Seung-Woo Kim, linux-samsung-soc, linux-arm-kernel, linux-kernel,
k.kozlowski, kgene
On 2016년 07월 05일 20:40, Seung-Woo Kim wrote:
> This patch fixes wrong count of array for srom registers from probe
> function.
>
> Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
> ---
> drivers/memory/samsung/exynos-srom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/memory/samsung/exynos-srom.c b/drivers/memory/samsung/exynos-srom.c
> index 96756fb..c66d2bd 100644
> --- a/drivers/memory/samsung/exynos-srom.c
> +++ b/drivers/memory/samsung/exynos-srom.c
> @@ -134,7 +134,7 @@ static int exynos_srom_probe(struct platform_device *pdev)
> platform_set_drvdata(pdev, srom);
>
> srom->reg_offset = exynos_srom_alloc_reg_dump(exynos_srom_offsets,
> - sizeof(exynos_srom_offsets));
> + ARRAY_SIZE(exynos_srom_offsets));
> if (!srom->reg_offset) {
> iounmap(srom->reg_base);
> return -ENOMEM;
>
On the exynos-srom.c, use the ARRAY_SIZE to get the number of array entry.
Looks good to me.
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Thanks,
Chanwoo Choi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] memory: samsung: exynos-srom: fix wrong count of registers
2016-07-05 11:40 ` [PATCH] memory: samsung: exynos-srom: fix wrong count of registers Seung-Woo Kim
2016-07-06 0:12 ` Chanwoo Choi
@ 2016-07-06 6:17 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2016-07-06 6:17 UTC (permalink / raw)
To: Seung-Woo Kim, linux-samsung-soc, linux-arm-kernel, linux-kernel, kgene
Cc: cw00.choi
On 07/05/2016 01:40 PM, Seung-Woo Kim wrote:
> This patch fixes wrong count of array for srom registers from probe
> function.
>
> Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
> ---
> drivers/memory/samsung/exynos-srom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, applied.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-06 6:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20160705114058epcas1p103f3f6d7cd39bf6d99f36f0fea2493f0@epcas1p1.samsung.com>
2016-07-05 11:40 ` [PATCH] memory: samsung: exynos-srom: fix wrong count of registers Seung-Woo Kim
2016-07-06 0:12 ` Chanwoo Choi
2016-07-06 6:17 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).