* [PATCH] xen-blkback: really don't leak mode property
@ 2016-07-07 7:38 Jan Beulich
2016-07-07 9:17 ` Roger Pau Monne
0 siblings, 1 reply; 3+ messages in thread
From: Jan Beulich @ 2016-07-07 7:38 UTC (permalink / raw)
To: Roger Pau Monne, Konrad Rzeszutek Wilk; +Cc: xen-devel, linux-kernel
Commit 9d092603cc ("xen-blkback: do not leak mode property") left one
path unfixed; correct this.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
drivers/block/xen-blkback/xenbus.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
--- 4.7-rc6-xen.orig/drivers/block/xen-blkback/xenbus.c
+++ 4.7-rc6-xen/drivers/block/xen-blkback/xenbus.c
@@ -715,8 +715,11 @@ static void backend_changed(struct xenbu
/* Front end dir is a number, which is used as the handle. */
err = kstrtoul(strrchr(dev->otherend, '/') + 1, 0, &handle);
- if (err)
+ if (err) {
+ kfree(be->mode);
+ be->mode = NULL;
return;
+ }
be->major = major;
be->minor = minor;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xen-blkback: really don't leak mode property
2016-07-07 7:38 [PATCH] xen-blkback: really don't leak mode property Jan Beulich
@ 2016-07-07 9:17 ` Roger Pau Monne
2016-07-07 15:33 ` Konrad Rzeszutek Wilk
0 siblings, 1 reply; 3+ messages in thread
From: Roger Pau Monne @ 2016-07-07 9:17 UTC (permalink / raw)
To: Jan Beulich; +Cc: Konrad Rzeszutek Wilk, xen-devel, linux-kernel
On Thu, Jul 07, 2016 at 01:38:13AM -0600, Jan Beulich wrote:
> Commit 9d092603cc ("xen-blkback: do not leak mode property") left one
> path unfixed; correct this.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Roger Pau Monné <roger.pau@citrix.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xen-blkback: really don't leak mode property
2016-07-07 9:17 ` Roger Pau Monne
@ 2016-07-07 15:33 ` Konrad Rzeszutek Wilk
0 siblings, 0 replies; 3+ messages in thread
From: Konrad Rzeszutek Wilk @ 2016-07-07 15:33 UTC (permalink / raw)
To: Roger Pau Monne; +Cc: Jan Beulich, xen-devel, linux-kernel
On Thu, Jul 07, 2016 at 11:17:14AM +0200, Roger Pau Monne wrote:
> On Thu, Jul 07, 2016 at 01:38:13AM -0600, Jan Beulich wrote:
> > Commit 9d092603cc ("xen-blkback: do not leak mode property") left one
> > path unfixed; correct this.
> >
> > Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> Acked-by: Roger Pau Monné <roger.pau@citrix.com>
Queued.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-07 15:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-07 7:38 [PATCH] xen-blkback: really don't leak mode property Jan Beulich
2016-07-07 9:17 ` Roger Pau Monne
2016-07-07 15:33 ` Konrad Rzeszutek Wilk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).