From: Chanwoo Choi <cw00.choi@samsung.com>
To: Chris Zhong <zyw@rock-chips.com>,
dianders@chromium.org, tfiga@chromium.org, heiko@sntech.de,
yzq@rock-chips.com, groeck@chromium.org,
myungjoo.ham@samsung.com, wulf@rock-chips.com,
marcheu@chromium.org
Cc: linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [v5 PATCH 1/5] extcon: Add Type-C and DP support
Date: Thu, 14 Jul 2016 10:15:01 +0900 [thread overview]
Message-ID: <5786E795.6040504@samsung.com> (raw)
In-Reply-To: <5786E4E7.30505@rock-chips.com>
Hi Chris,
[snip]
>>>> Thanks,
>>>> Chanwoo Choi
>>> There are 4 modes for Type-C DP alt mode:
>>> 1) USB host only :
>>>
>>> extcon_set_cable_state(edev, EXTCON_USB_HOST, 1);
>>> extcon_set_cable_state(edev, EXTCON_USB, 0);
>>> extcon_set_cable_state(edev, EXTCON_DISP_DP, 0);
>>>
>>> 2) USB device only
>>>
>>> extcon_set_cable_state(edev, EXTCON_USB_HOST, 0);
>>> extcon_set_cable_state(edev, EXTCON_USB, 1);
>>> extcon_set_cable_state(edev, EXTCON_DISP_DP, 0);
>>>
>>> 3) DP only
>>>
>>> extcon_set_cable_state(edev, EXTCON_USB_HOST, 0);
>>> extcon_set_cable_state(edev, EXTCON_USB, 0);
>>> extcon_set_cable_state(edev, EXTCON_DISP_DP, 1);
>>>
>>> 4) USB + DP
>>>
>>> extcon_set_cable_state(edev, EXTCON_USB_HOST, 1);
>>> extcon_set_cable_state(edev, EXTCON_USB, 0);
>>> extcon_set_cable_state(edev, EXTCON_DISP_DP, 1);
>>>
>>>
>>> for 3rd mode: DP only, there is only EXTCON_DISP_DP is attached, the EXTCON_USB_HOST
>>> and EXTCON_USB are detached, Can I set the property into these 2 detached cable?
>>> or just call extcon_set_cable_state(edev, EXTCON_DISP_DP, EXTCON_PROP_TYPEC_POLARITY, 0 or 1);
>> I'm thinking to solve this issue. In result, we can add one more type to specific connector.
>> For EXTCON_DISP_DP, we can add the two type as following. And EXTCON_PROP_TYPEC_POLARITY property
>> should be added to EXTCON_TYPE_USB.
>>
>> + [EXTCON_DISP_DP] = {
>> + .type = EXTCON_TYPE_DISP | EXTCON_TYPE_USB,
>> + .id = EXTCON_DISP_DP,
>> + .name = "DP",
>> + },
>>
>> So, as you mentioned, EXTCON_DISP_DP can set the EXTCON_PROP_TYPEC_POLARITY property as following:
>> - extcon_set_cable_state(edev, EXTCON_DISP_DP, EXTCON_PROP_TYPEC_POLARITY, 0 or 1);
>>
>> I'll again developing the extcon property.
>>
>> Thanks,
>> Chanwoo Choi
>>
> Nice idea, But I am thinking about is it compatible with real DisplayPort without Type-C.
> Maybe we should add a new cable: EXTCON_DISP_DP_ALT
>
> + [EXTCON_DISP_DP] = {
> + .type = EXTCON_TYPE_DISP,
> + .id = EXTCON_DISP_DP,
> + .name = "DP",
> + },
>
> + [EXTCON_DISP_DP_ALT] = {
> + .type = EXTCON_TYPE_DISP | EXTCON_TYPE_USB,
> + .id = EXTCON_DISP_DP,
> + .name = "DP ALT",
> + },
EXTCON_DISP_DP_ALT means EXTCON_DISP_DP connector with EXTCON_PROP_TYPEC_POLARITY property.
So, we can explain the DP alternative mode without EXTCON_DISP_DP_ALT.
I'm wondering to add the new EXTCON_DISP_DP_ALT connector
because alternative mode was defined as mode instead of new h/w connector type.
Thanks,
Chanwoo Choi
next prev parent reply other threads:[~2016-07-14 1:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-12 15:09 [v5 PATCH 0/5] Rockchip Type-C and DisplayPort driver Chris Zhong
2016-07-12 15:09 ` [v5 PATCH 1/5] extcon: Add Type-C and DP support Chris Zhong
2016-07-13 1:11 ` Chanwoo Choi
2016-07-13 1:39 ` Chris Zhong
2016-07-13 2:05 ` Chanwoo Choi
2016-07-13 2:54 ` Chris Zhong
2016-07-14 0:49 ` Chanwoo Choi
2016-07-14 1:03 ` Chris Zhong
2016-07-14 1:15 ` Chanwoo Choi [this message]
2016-07-14 2:07 ` Chris Zhong
2016-07-14 2:10 ` Chanwoo Choi
2016-07-12 15:09 ` [v5 PATCH 2/5] Documentation: bindings: add dt doc for Rockchip USB Type-C PHY Chris Zhong
2016-07-12 15:09 ` [v5 PATCH 3/5] phy: Add USB Type-C PHY driver for rk3399 Chris Zhong
2016-07-12 15:09 ` [v5 PATCH 4/5] Documentation: bindings: add dt documentation for cdn DP controller Chris Zhong
2016-07-12 15:09 ` [v5 PATCH 5/5] drm/rockchip: cdn-dp: add cdn DP support for rk3399 Chris Zhong
2016-07-13 13:59 ` Sean Paul
2016-07-14 3:08 ` Chris Zhong
2016-07-14 14:02 ` Sean Paul
2016-07-15 5:52 ` [v5.1 " Chris Zhong
2016-07-15 8:18 ` [v5.2 " Chris Zhong
2016-07-19 16:44 ` Sean Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5786E795.6040504@samsung.com \
--to=cw00.choi@samsung.com \
--cc=dianders@chromium.org \
--cc=groeck@chromium.org \
--cc=heiko@sntech.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=marcheu@chromium.org \
--cc=myungjoo.ham@samsung.com \
--cc=tfiga@chromium.org \
--cc=wulf@rock-chips.com \
--cc=yzq@rock-chips.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).