linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Jacek Anaszewski <j.anaszewski@samsung.com>
Cc: Shuah Khan <shuahkh@osg.samsung.com>,
	robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
	kgene@kernel.org, mchehab@osg.samsung.com, andrzej.p@samsung.com,
	hans.verkuil@cisco.com, javier@osg.samsung.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: Doc add missing documentation for samsung,exynos4212-jpeg
Date: Fri, 15 Jul 2016 10:17:39 +0200	[thread overview]
Message-ID: <57889C23.3050106@samsung.com> (raw)
In-Reply-To: <57889B73.4090607@samsung.com>

On 07/15/2016 10:14 AM, Jacek Anaszewski wrote:
>> However if these compatibles are exactly equal then
>> only one should be preferred. It makes everything easier. Second can be
>> still documented e.g. as deprecated.
> 
> Still, both of them are present in the driver. Shouldn't it be reflected
> in the documentation?

Right, it is a good practice, so how about:

  - compatible    : should be one of:
          "samsung,s5pv210-jpeg", "samsung,exynos3250-jpeg",
          "samsung,exynos4210-jpeg", "samsung,exynos5420-jpeg",
          "samsung,exynos5433-jpeg";

          Deprecated: "samsung,exynos4212-jpeg"

(or any other formatting)
plus update to DTS changing it to 4210?

Best regards,
Krzysztof

  reply	other threads:[~2016-07-15  8:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-14 20:01 [PATCH] media: Doc add missing documentation for samsung,exynos4212-jpeg Shuah Khan
2016-07-15  6:25 ` Jacek Anaszewski
2016-07-15  7:28 ` Krzysztof Kozlowski
2016-07-15  8:14   ` Jacek Anaszewski
2016-07-15  8:17     ` Krzysztof Kozlowski [this message]
2016-07-15  8:28       ` Jacek Anaszewski
2016-07-15  8:33         ` Krzysztof Kozlowski
2016-07-15  9:18           ` Jacek Anaszewski
2016-07-15  9:30             ` Krzysztof Kozlowski
2016-07-15  9:37               ` Jacek Anaszewski
2016-07-15 22:09                 ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57889C23.3050106@samsung.com \
    --to=k.kozlowski@samsung.com \
    --cc=andrzej.p@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=hans.verkuil@cisco.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=j.anaszewski@samsung.com \
    --cc=javier@osg.samsung.com \
    --cc=kgene@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mchehab@osg.samsung.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=shuahkh@osg.samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).