From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Shuah Khan <shuahkh@osg.samsung.com>,
robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
kgene@kernel.org, mchehab@osg.samsung.com, andrzej.p@samsung.com,
j.anaszewski@samsung.com, hans.verkuil@cisco.com
Cc: javier@osg.samsung.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: Doc add missing documentation for samsung,exynos4212-jpeg
Date: Fri, 15 Jul 2016 09:28:58 +0200 [thread overview]
Message-ID: <578890BA.8040101@samsung.com> (raw)
In-Reply-To: <1468526499-8840-1-git-send-email-shuahkh@osg.samsung.com>
On 07/14/2016 10:01 PM, Shuah Khan wrote:
> Add add missing documentation for samsung,exynos4212-jpeg codec,
> reorder entries to improve readability and make it easier to add
> new entries.
>
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
> ---
> Documentation/devicetree/bindings/media/exynos-jpeg-codec.txt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/exynos-jpeg-codec.txt b/Documentation/devicetree/bindings/media/exynos-jpeg-codec.txt
> index 38941db..093614c 100644
> --- a/Documentation/devicetree/bindings/media/exynos-jpeg-codec.txt
> +++ b/Documentation/devicetree/bindings/media/exynos-jpeg-codec.txt
> @@ -3,9 +3,9 @@ Samsung S5P/EXYNOS SoC series JPEG codec
> Required properties:
>
> - compatible : should be one of:
> - "samsung,s5pv210-jpeg", "samsung,exynos4210-jpeg",
> - "samsung,exynos3250-jpeg", "samsung,exynos5420-jpeg",
> - "samsung,exynos5433-jpeg";
> + "samsung,s5pv210-jpeg", "samsung,exynos3250-jpeg",
> + "samsung,exynos4210-jpeg", "samsung,exynos4212-jpeg",
> + "samsung,exynos5420-jpeg", "samsung,exynos5433-jpeg";
I am not convinced that this is needed because exynos4212-jpeg is equal
to exynos4210-jpeg... It is a little bit weird because Jacek's commit
3246fdaa0ac2d9 ("[media] s5p-jpeg: Add support for Exynos3250 SoC")
changed the driver data for Exynos4210 from S5P to Exynos4 without
explaining it... However if these compatibles are exactly equal then
only one should be preferred. It makes everything easier. Second can be
still documented e.g. as deprecated.
Best regards,
Krzysztof
next prev parent reply other threads:[~2016-07-15 7:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 20:01 [PATCH] media: Doc add missing documentation for samsung,exynos4212-jpeg Shuah Khan
2016-07-15 6:25 ` Jacek Anaszewski
2016-07-15 7:28 ` Krzysztof Kozlowski [this message]
2016-07-15 8:14 ` Jacek Anaszewski
2016-07-15 8:17 ` Krzysztof Kozlowski
2016-07-15 8:28 ` Jacek Anaszewski
2016-07-15 8:33 ` Krzysztof Kozlowski
2016-07-15 9:18 ` Jacek Anaszewski
2016-07-15 9:30 ` Krzysztof Kozlowski
2016-07-15 9:37 ` Jacek Anaszewski
2016-07-15 22:09 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=578890BA.8040101@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=andrzej.p@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=hans.verkuil@cisco.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=j.anaszewski@samsung.com \
--cc=javier@osg.samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@osg.samsung.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=shuahkh@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).