linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] ARM: dts: imx6: RDU2: Fix the audio CODEC's reset pin
@ 2018-08-31 19:17 Andrew F. Davis
  2018-08-31 19:17 ` [PATCH 2/2] ARM: dts: imx: " Andrew F. Davis
  2018-09-03  4:54 ` [PATCH 1/2] ARM: dts: imx6: RDU2: " Shawn Guo
  0 siblings, 2 replies; 4+ messages in thread
From: Andrew F. Davis @ 2018-08-31 19:17 UTC (permalink / raw)
  To: Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team
  Cc: linux-arm-kernel, linux-kernel, Andrew F . Davis

The correct DT property for specifying a GPIO used for reset
is "reset-gpios", fix this here.

Fixes: d763762e3b58 ("ARM: dts: imx6: add ZII RDU2 boards")

Signed-off-by: Andrew F. Davis <afd@ti.com>
---
 arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
index 7fff3717cf7c..a0f5cfda0055 100644
--- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
@@ -384,7 +384,7 @@
 		AVDD-supply = <&reg_3p3v>;
 		IOVDD-supply = <&reg_3p3v>;
 		DVDD-supply = <&vgen4_reg>;
-		gpio-reset = <&gpio1 2 GPIO_ACTIVE_HIGH>;
+		reset-gpios = <&gpio1 2 GPIO_ACTIVE_LOW>;
 	};
 
 	accel@1c {
@@ -572,7 +572,7 @@
 		AVDD-supply = <&reg_3p3v>;
 		IOVDD-supply = <&reg_3p3v>;
 		DVDD-supply = <&vgen4_reg>;
-		gpio-reset = <&gpio1 0 GPIO_ACTIVE_HIGH>;
+		reset-gpios = <&gpio1 0 GPIO_ACTIVE_LOW>;
 	};
 
 	touchscreen@20 {
-- 
2.18.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH 2/2] ARM: dts: imx: Fix the audio CODEC's reset pin
  2018-08-31 19:17 [PATCH 1/2] ARM: dts: imx6: RDU2: Fix the audio CODEC's reset pin Andrew F. Davis
@ 2018-08-31 19:17 ` Andrew F. Davis
  2018-09-03  4:54 ` [PATCH 1/2] ARM: dts: imx6: RDU2: " Shawn Guo
  1 sibling, 0 replies; 4+ messages in thread
From: Andrew F. Davis @ 2018-08-31 19:17 UTC (permalink / raw)
  To: Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team
  Cc: linux-arm-kernel, linux-kernel, Andrew F . Davis

The correct DT property for specifying a GPIO used for reset
is "reset-gpios", fix this here.

Fixes: 50bffb78e2ee ("ARM: dts: imx: add Gateworks Ventana GW5903 support")

Signed-off-by: Andrew F. Davis <afd@ti.com>
---
 arch/arm/boot/dts/imx6qdl-gw5903.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx6qdl-gw5903.dtsi b/arch/arm/boot/dts/imx6qdl-gw5903.dtsi
index 368132274a91..ddabab168a8a 100644
--- a/arch/arm/boot/dts/imx6qdl-gw5903.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-gw5903.dtsi
@@ -310,7 +310,7 @@
 	tlv320aic3105: codec@18 {
 		compatible = "ti,tlv320aic3x";
 		reg = <0x18>;
-		gpio-reset = <&gpio5 17 GPIO_ACTIVE_LOW>;
+		reset-gpios = <&gpio5 17 GPIO_ACTIVE_LOW>;
 		clocks = <&clks IMX6QDL_CLK_CKO>;
 		ai3x-micbias-vg = <2>; /* MICBIAS_2_5V */
 		/* Regulators */
-- 
2.18.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] ARM: dts: imx6: RDU2: Fix the audio CODEC's reset pin
  2018-08-31 19:17 [PATCH 1/2] ARM: dts: imx6: RDU2: Fix the audio CODEC's reset pin Andrew F. Davis
  2018-08-31 19:17 ` [PATCH 2/2] ARM: dts: imx: " Andrew F. Davis
@ 2018-09-03  4:54 ` Shawn Guo
  2018-09-04 13:35   ` Andrew F. Davis
  1 sibling, 1 reply; 4+ messages in thread
From: Shawn Guo @ 2018-09-03  4:54 UTC (permalink / raw)
  To: Andrew F. Davis
  Cc: Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, linux-arm-kernel, linux-kernel

On Fri, Aug 31, 2018 at 02:17:31PM -0500, Andrew F. Davis wrote:
> The correct DT property for specifying a GPIO used for reset
> is "reset-gpios", fix this here.
> 
> Fixes: d763762e3b58 ("ARM: dts: imx6: add ZII RDU2 boards")

This Fixes tag and word 'Fix' in subject is inappropriate to me, as you
are not fixing something wrong from the beginning, but actually
replacing a deprecated property with new one.

Shawn

> 
> Signed-off-by: Andrew F. Davis <afd@ti.com>
> ---
>  arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> index 7fff3717cf7c..a0f5cfda0055 100644
> --- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> @@ -384,7 +384,7 @@
>  		AVDD-supply = <&reg_3p3v>;
>  		IOVDD-supply = <&reg_3p3v>;
>  		DVDD-supply = <&vgen4_reg>;
> -		gpio-reset = <&gpio1 2 GPIO_ACTIVE_HIGH>;
> +		reset-gpios = <&gpio1 2 GPIO_ACTIVE_LOW>;
>  	};
>  
>  	accel@1c {
> @@ -572,7 +572,7 @@
>  		AVDD-supply = <&reg_3p3v>;
>  		IOVDD-supply = <&reg_3p3v>;
>  		DVDD-supply = <&vgen4_reg>;
> -		gpio-reset = <&gpio1 0 GPIO_ACTIVE_HIGH>;
> +		reset-gpios = <&gpio1 0 GPIO_ACTIVE_LOW>;
>  	};
>  
>  	touchscreen@20 {
> -- 
> 2.18.0
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] ARM: dts: imx6: RDU2: Fix the audio CODEC's reset pin
  2018-09-03  4:54 ` [PATCH 1/2] ARM: dts: imx6: RDU2: " Shawn Guo
@ 2018-09-04 13:35   ` Andrew F. Davis
  0 siblings, 0 replies; 4+ messages in thread
From: Andrew F. Davis @ 2018-09-04 13:35 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, linux-arm-kernel, linux-kernel

On 09/02/2018 11:54 PM, Shawn Guo wrote:
> On Fri, Aug 31, 2018 at 02:17:31PM -0500, Andrew F. Davis wrote:
>> The correct DT property for specifying a GPIO used for reset
>> is "reset-gpios", fix this here.
>>
>> Fixes: d763762e3b58 ("ARM: dts: imx6: add ZII RDU2 boards")
> 
> This Fixes tag and word 'Fix' in subject is inappropriate to me, as you
> are not fixing something wrong from the beginning, but actually
> replacing a deprecated property with new one.
> 


reset-gpios was standard before this driver got it backwards, but it
also wasn't required to be one way or the other as far as I can tell, so
I can see your point that this isn't technically "broken". I have no
preference, so I'll change the subject and drop the fixes for v2.

Andrew


> Shawn
> 
>>
>> Signed-off-by: Andrew F. Davis <afd@ti.com>
>> ---
>>  arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
>> index 7fff3717cf7c..a0f5cfda0055 100644
>> --- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
>> +++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
>> @@ -384,7 +384,7 @@
>>  		AVDD-supply = <&reg_3p3v>;
>>  		IOVDD-supply = <&reg_3p3v>;
>>  		DVDD-supply = <&vgen4_reg>;
>> -		gpio-reset = <&gpio1 2 GPIO_ACTIVE_HIGH>;
>> +		reset-gpios = <&gpio1 2 GPIO_ACTIVE_LOW>;
>>  	};
>>  
>>  	accel@1c {
>> @@ -572,7 +572,7 @@
>>  		AVDD-supply = <&reg_3p3v>;
>>  		IOVDD-supply = <&reg_3p3v>;
>>  		DVDD-supply = <&vgen4_reg>;
>> -		gpio-reset = <&gpio1 0 GPIO_ACTIVE_HIGH>;
>> +		reset-gpios = <&gpio1 0 GPIO_ACTIVE_LOW>;
>>  	};
>>  
>>  	touchscreen@20 {
>> -- 
>> 2.18.0
>>

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-09-04 13:35 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-31 19:17 [PATCH 1/2] ARM: dts: imx6: RDU2: Fix the audio CODEC's reset pin Andrew F. Davis
2018-08-31 19:17 ` [PATCH 2/2] ARM: dts: imx: " Andrew F. Davis
2018-09-03  4:54 ` [PATCH 1/2] ARM: dts: imx6: RDU2: " Shawn Guo
2018-09-04 13:35   ` Andrew F. Davis

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).