* [PATCH] phy: sun9i-usb: fix error handling
@ 2016-07-06 6:00 Christophe JAILLET
2016-07-06 6:06 ` Chen-Yu Tsai
0 siblings, 1 reply; 3+ messages in thread
From: Christophe JAILLET @ 2016-07-06 6:00 UTC (permalink / raw)
To: kishon, maxime.ripard, wens
Cc: linux-arm-kernel, linux-kernel, kernel-janitors, Christophe JAILLET
This is likely that checking 'phy->hsic_clk' instead of 'phy->clk' is
expected here.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
v2: Also fix the variable name used by PTR_ERR
Update $subject
---
drivers/phy/phy-sun9i-usb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/phy/phy-sun9i-usb.c b/drivers/phy/phy-sun9i-usb.c
index ac4f31a..28fce4b 100644
--- a/drivers/phy/phy-sun9i-usb.c
+++ b/drivers/phy/phy-sun9i-usb.c
@@ -141,9 +141,9 @@ static int sun9i_usb_phy_probe(struct platform_device *pdev)
}
phy->hsic_clk = devm_clk_get(dev, "hsic_12M");
- if (IS_ERR(phy->clk)) {
+ if (IS_ERR(phy->hsic_clk)) {
dev_err(dev, "failed to get hsic_12M clock\n");
- return PTR_ERR(phy->clk);
+ return PTR_ERR(phy->hsic_clk);
}
phy->reset = devm_reset_control_get(dev, "hsic");
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] phy: sun9i-usb: fix error handling
2016-07-06 6:00 [PATCH] phy: sun9i-usb: fix error handling Christophe JAILLET
@ 2016-07-06 6:06 ` Chen-Yu Tsai
2016-08-12 8:41 ` Kishon Vijay Abraham I
0 siblings, 1 reply; 3+ messages in thread
From: Chen-Yu Tsai @ 2016-07-06 6:06 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Kishon Vijay Abraham I, Maxime Ripard, Chen-Yu Tsai,
linux-arm-kernel, linux-kernel, kernel-janitors
On Wed, Jul 6, 2016 at 2:00 PM, Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
> This is likely that checking 'phy->hsic_clk' instead of 'phy->clk' is
> expected here.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Chen-Yu Tsai <wens@csie.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] phy: sun9i-usb: fix error handling
2016-07-06 6:06 ` Chen-Yu Tsai
@ 2016-08-12 8:41 ` Kishon Vijay Abraham I
0 siblings, 0 replies; 3+ messages in thread
From: Kishon Vijay Abraham I @ 2016-08-12 8:41 UTC (permalink / raw)
To: Chen-Yu Tsai, Christophe JAILLET
Cc: Maxime Ripard, linux-arm-kernel, linux-kernel, kernel-janitors
On Wednesday 06 July 2016 11:36 AM, Chen-Yu Tsai wrote:
> On Wed, Jul 6, 2016 at 2:00 PM, Christophe JAILLET
> <christophe.jaillet@wanadoo.fr> wrote:
>> This is likely that checking 'phy->hsic_clk' instead of 'phy->clk' is
>> expected here.
>>
>> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>
> Acked-by: Chen-Yu Tsai <wens@csie.org>
merged, thanks
-Kishon
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-12 8:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-06 6:00 [PATCH] phy: sun9i-usb: fix error handling Christophe JAILLET
2016-07-06 6:06 ` Chen-Yu Tsai
2016-08-12 8:41 ` Kishon Vijay Abraham I
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).