From: Chanwoo Choi <cw00.choi@samsung.com>
To: Lin Huang <hl@rock-chips.com>, heiko@sntech.de, myungjoo.ham@samsung.com
Cc: tixy@linaro.org, mark.rutland@arm.com, typ@rock-chips.com,
linux-rockchip@lists.infradead.org, airlied@linux.ie,
mturquette@baylibre.com, dbasehore@chromium.org,
sboyd@codeaurora.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, dianders@chromium.org,
kyungmin.park@samsung.com, sudeep.holla@arm.com,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
mark.yao@rock-chips.com
Subject: Re: [PATCH v7 4/8] Documentation: bindings: add dt documentation for dfi controller
Date: Tue, 23 Aug 2016 14:23:11 +0900 [thread overview]
Message-ID: <57BBDDBF.8040105@samsung.com> (raw)
In-Reply-To: <1471836984-6316-5-git-send-email-hl@rock-chips.com>
Hi Lin,
On 2016년 08월 22일 12:36, Lin Huang wrote:
> This patch adds the documentation for rockchip dfi devfreq-event driver.
>
> Signed-off-by: Lin Huang <hl@rock-chips.com>
> ---
> Changes in v7:
> -None
>
> Changes in v6:
> -None
>
> Changes in v5:
> -None
>
> Changes in v4:
> -None
>
> Changes in v3:
> -None
>
> Changes in v2:
> -None
>
> Changes in v1:
> -None
> .../bindings/devfreq/event/rockchip-dfi.txt | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt
>
> diff --git a/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt
> new file mode 100644
> index 0000000..bf42255
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt
> @@ -0,0 +1,20 @@
> +
> +* Rockchip rk3399 DFI device
> +
> +Required properties:
> +- compatible: Must be "rockchip,rk3399-dfi".
> +- reg: physical base address of each DFI and length of memory mapped region
> +- rockchip,pmu: phandle to the syscon managing the "pmu general register files"
> +- clocks: phandles for clock specified in "clock-names" property
> +- clock-names : the name of clock used by the DFI, must be "pclk_ddr_mon";
> +
> +Example:
> + dfi: dfi@0xff630000 {
> + reg = <0x00 0xff630000 0x00 0x4000>;
> + compatible = "rockchip,rk3399-dfi";
> + rockchip,pmu = <&pmugrf>;
> + clocks = <&cru PCLK_DDR_MON>;
> + clock-names = "pclk_ddr_mon";
> + status = "disabled";
> + };
> +
>
I reviewed this patch on previous version[1] already.
[1] https://lkml.org/lkml/2016/8/16/913
There are minor requirement. If you modify it,
I'll finish the review of this patch.
--
Best Regards,
Chanwoo Choi
next prev parent reply other threads:[~2016-08-23 5:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-22 3:36 [PATCH v7 0/8] rk3399 support ddr frequency scaling Lin Huang
2016-08-22 3:36 ` [PATCH v7 1/8] clk: rockchip: add new clock-type for the ddrclk Lin Huang
2016-09-01 9:34 ` Heiko Stübner
2016-08-22 3:36 ` [PATCH v7 2/8] clk: rockchip: rk3399: add SCLK_DDRCLK ID for ddrc Lin Huang
2016-08-31 16:21 ` Heiko Stübner
2016-08-22 3:36 ` [PATCH v7 3/8] clk: rockchip: rk3399: add ddrc clock support Lin Huang
2016-09-01 11:30 ` Heiko Stübner
2016-08-22 3:36 ` [PATCH v7 4/8] Documentation: bindings: add dt documentation for dfi controller Lin Huang
2016-08-23 5:23 ` Chanwoo Choi [this message]
2016-08-22 3:36 ` [PATCH v7 5/8] PM / devfreq: event: support rockchip " Lin Huang
2016-08-22 3:36 ` [PATCH v7 6/8] Documentation: bindings: add dt documentation for rk3399 dmc Lin Huang
2016-08-23 5:27 ` Chanwoo Choi
2016-08-26 21:09 ` Brian Norris
2016-08-22 3:36 ` [PATCH v7 7/8] PM / devfreq: rockchip: add devfreq driver " Lin Huang
2016-08-26 21:17 ` Brian Norris
2016-09-01 9:41 ` Heiko Stübner
2016-08-22 3:36 ` [PATCH v7 8/8] drm/rockchip: Add dmc notifier in vop driver Lin Huang
2016-08-28 3:03 ` kbuild test robot
[not found] ` <CGME20160822033648epcas1p2dde23978d690bc38b34233c0abaf7363@epcas1p2.samsung.com>
2016-08-26 2:00 ` [PATCH v7 5/8] PM / devfreq: event: support rockchip dfi controller MyungJoo Ham
[not found] ` <CGME20160822033650epcas1p38e945746186fb0b2a64d1da3ee50b3e3@epcas1p3.samsung.com>
2016-08-26 7:20 ` [PATCH v7 7/8] PM / devfreq: rockchip: add devfreq driver for rk3399 dmc MyungJoo Ham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57BBDDBF.8040105@samsung.com \
--to=cw00.choi@samsung.com \
--cc=airlied@linux.ie \
--cc=dbasehore@chromium.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hl@rock-chips.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mark.yao@rock-chips.com \
--cc=mturquette@baylibre.com \
--cc=myungjoo.ham@samsung.com \
--cc=sboyd@codeaurora.org \
--cc=sudeep.holla@arm.com \
--cc=tixy@linaro.org \
--cc=typ@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).